[@azure/confidential-ledger-rest] Migrate to latest test recorder and externalize recordings #26305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xirzec
added
Client
xirzec
requested review from
bterlson,
jeremymeng,
HarshaNalluru,
timovv and
joheredi
as code owners
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
|
/azp run js - confidentialledger - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
sdk/confidentialledger/confidential-ledger-rest/test/public/historicalRangeQuery.spec.ts
Outdated
Show resolved
Hide resolved
| /** | ||
| * When a service uses a custom SSL certificate to communicate with the client. | ||
| */ | ||
| tlsValidationCert?: string; |
There was a problem hiding this comment.
Thanks for the change, @xirzec 🍏
I was reading.. Test proxy supports more than this. Adding here for future reference.
https://github.com/Azure/azure-sdk-tools/blob/main/tools/test-proxy/Azure.Sdk.Tools.TestProxy/README.md#recording-options
There was a problem hiding this comment.
Do you mind adding a line in the changelog? 😎
HarshaNalluru
approved these changes
Jun 22, 2023
|
/azp run js - confidentialledger - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
xirzec
force-pushed
the
confidentialLedgerTestProxy
branch
from
cee1bf6
to
66b7091
Compare
xirzec
force-pushed
the
confidentialLedgerTestProxy
branch
from
c72d1f8
to
2b1d69a
Compare
|
/azp run js - confidentialledger - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Packages impacted by this PR
@azure-rest/confidential-ledger@azure-tools/test-recorderIssues associated with this PR
Fixes #20495
Describe the problem that is addressed by this PR
Migrate to the latest test recorder in order to use the test proxy and externalize recordings. I also had to regenerate the RLC in order to fix an issue with
isUnexpectednot working properly for the user endpoint.Getting the test resources to deploy correctly also took some doing since it uses the
oidand not the normal client id of the test app.The tests themselves were a bit busted in places; I shored them up as best I could given the odd behavior of the service.
Lastly, the test recorder didn't have support for any custom transport options, so I had to add one in order to pass the
TLSValidationCertin order for it to work properly with confidential ledger.