-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WaitForARMFeedback #7064
Closed
ejdelrio
wants to merge
58
commits into
Azure:network-august-release
from
ejdelrio:netwok-august-release
Closed
WaitForARMFeedback #7064
ejdelrio
wants to merge
58
commits into
Azure:network-august-release
from
ejdelrio:netwok-august-release
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merging latest changes onto my fork
Merging from source fork
* Fixing errors in swagger examples of Azure Backup * Updating reference path for moved file * Removing trailing commas in examples * Fixing semantic errors in Azure backup example
* adding_version_2019_05_15 * fix_error_in_examples_case_issue * fix_version_in_examples * enother_try_to_fix_examples * another_try * handle_error_201_in_examples * fix_readmego * another_try_fix_readme_files * try_fix_readme * fix_readme_and_resolve_comment * add_ofers_change * add_suppression * add_dor_and_ofer_changes * try_understand_one_error * try_the_other_string * try_add_suppressions * try_another_suppressions_syntax * try_suppressions * try_zim_suggestion * trying_to_fix_example_kusto_data_connection_validation * trying_to_fix_example_kusto_databases_check_name_availability * try2 * try3 * delete_suppressions * try4
* commit with 2018-09-30 files * incremental snapshots going in disk.json * adding incremental examples * upload size bytes and incremental snapshots * adding diskSizeBytes to disk.json * adding descriptions to the disk create option enums * adding diskSizeBytes as a read only field * adding encryptionSettingsVersion * updating readme * add example * removing extra descriptions * Revert "removing extra descriptions" This reverts commit 3a0f6498ff6d12663a4929cc78d05911112124c7. * adding enum descriptions back in * adding descriptions for some enums * fixing incorrect use of name and replacing it with the correct property value * adding unique id * fixing the snapshots examples so that model validation passes - don't send a read only field in the request * fixing typo * removing diskSizeBytes from snapshot\disk update properties and adding a unique id for disk properties * pr comments
…Azure#7013) * New Readme Config File * New Go Language Readme Config File * New Typescript Language Readme Config File * New Python Language Readme Config File * New C# Language Readme Config File * New Ruby Language Readme Config File * New Swagger Spec File * New Swagger Example Spec File * Initialize the swagger spec review for azure data. * fix validation issues. * fixed Linter check. * fix by comments. * fix by comments * fix by comments. * fix CI error. * fix by comments. * fix build issue. * update the resource definition * update examples. * fix swagger * fix examples issue. * Swagger review comments * Moving azure-sdk on line up
…Added priority, eviction policy and billing profile to VirtualMachineProperties. Also, adding optional billing profile to VMSS Create and Update APIs. (Azure#6961)
* Baseline commit * Update swagger and examples * Update readme.md * Stop deleting v2.0 definition from readme.md
* Adding ew Api which adds a connection identifier. This is a unique hash for each connection so we can determine when a connection is deleted or if it is updated. * added 06-01 to readme * added location to list Legacy example * Updated Models * Update readme.typescript.md * Updated Swagger and api-version * pretifies the json. * Updated Docs * removed \r\n from description.
* Version change * Adding properties for SSH Improvements * Correcting naming mistake * Removing null value * Making the property writable by requester
…preview/2019-04-01 (Azure#6995) * update swagger * update * update * update * update * update * update * update
…Pass support changes. (Azure#6742)
* Copy 2019-07-01 -> 2019-08-01 * Create 2019-08-01 resources spec * Add 202 example responses for export * Include final-state-via for export * Address PR feedback
Puling latest changes
Network august release
ejdelrio
requested review from
DavidLiCIG,
huangpf,
hyonholee,
jaredmoo,
MikhailTryakhov,
Tiano2017,
wilcobmsft and
yangyuan
as code owners
August 28, 2019 19:08
Automation for azure-sdk-for-pythonThis PR contains more than 3 context, SDK generation is not enabled. Contexts found:
|
Automation for azure-sdk-for-goThis PR contains more than 3 context, SDK generation is not enabled. Contexts found:
|
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Latest improvements:
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
ARM API Review Checklist
Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.
Please follow the link to find more details on API review process.