Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WaitForARMFeedback #7064

Closed

Conversation

ejdelrio
Copy link

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

ejdelrio and others added 30 commits August 1, 2019 11:40
Merging latest changes onto my fork
Merging from source fork
* Fixing errors in swagger examples of Azure Backup

* Updating reference path for moved file

* Removing trailing commas in examples

* Fixing semantic errors in Azure backup example
* adding_version_2019_05_15

* fix_error_in_examples_case_issue

* fix_version_in_examples

* enother_try_to_fix_examples

* another_try

* handle_error_201_in_examples

* fix_readmego

* another_try_fix_readme_files

* try_fix_readme

* fix_readme_and_resolve_comment

* add_ofers_change

* add_suppression

* add_dor_and_ofer_changes

* try_understand_one_error

* try_the_other_string

* try_add_suppressions

* try_another_suppressions_syntax

* try_suppressions

* try_zim_suggestion

* trying_to_fix_example_kusto_data_connection_validation

* trying_to_fix_example_kusto_databases_check_name_availability

* try2

* try3

* delete_suppressions

* try4
* commit with 2018-09-30 files

* incremental snapshots going in disk.json

* adding incremental examples

* upload size bytes and incremental snapshots

* adding diskSizeBytes to disk.json

* adding descriptions to the disk create option enums

* adding diskSizeBytes as a read only field

* adding encryptionSettingsVersion

* updating readme

* add example

* removing extra descriptions

* Revert "removing extra descriptions"

This reverts commit 3a0f6498ff6d12663a4929cc78d05911112124c7.

* adding enum descriptions back in

* adding descriptions for some enums

* fixing incorrect use of name and replacing it with the correct property value

* adding unique id

* fixing the snapshots examples so that model validation passes - don't send a read only field in the request

* fixing typo

* removing diskSizeBytes from snapshot\disk update properties and adding a unique id for disk properties

* pr comments
…Azure#7013)

* New Readme Config File

* New Go Language Readme Config File

* New Typescript Language Readme Config File

* New Python Language Readme Config File

* New C# Language Readme Config File

* New Ruby Language Readme Config File

* New Swagger Spec File

* New Swagger Example Spec File

* Initialize the swagger spec review for azure data.

* fix validation issues.

* fixed Linter check.

* fix by comments.

* fix by comments

* fix by comments.

* fix CI error.

* fix by comments.

* fix build issue.

* update the resource definition

* update examples.

* fix swagger

* fix examples issue.

* Swagger review comments

* Moving azure-sdk on line up
…Added priority, eviction policy and billing profile to VirtualMachineProperties. Also, adding optional billing profile to VMSS Create and Update APIs. (Azure#6961)
* Baseline commit

* Update swagger and examples

* Update readme.md

* Stop deleting v2.0 definition from readme.md
* Adding ew Api which adds a connection identifier.
This is a unique hash for each connection so we can determine when a connection is deleted or if it is updated.

* added 06-01 to readme

* added location to list Legacy example

* Updated Models

* Update readme.typescript.md

* Updated Swagger and api-version

* pretifies the json.

* Updated Docs

* removed \r\n from description.
* Version change

* Adding properties for SSH Improvements

* Correcting naming mistake

* Removing null value

* Making the property writable by requester
…preview/2019-04-01 (Azure#6995)

* update swagger

* update

* update

* update

* update

* update

* update

* update
@AutorestCI
Copy link

AutorestCI commented Aug 28, 2019

Automation for azure-sdk-for-python

This PR contains more than 3 context, SDK generation is not enabled. Contexts found:

  • managednetwork/resource-manager
  • cognitiveservices/data-plane/ComputerVision
  • reservations/resource-manager
  • machinelearningservices/resource-manager
  • hanaonazure/resource-manager
  • billing/resource-manager
  • azsadmin/resource-manager/network/Microsoft.Network.Admin
  • network/resource-manager
  • hdinsight/resource-manager
  • imds/data-plane
  • resources/resource-manager
  • containerregistry/resource-manager
  • recoveryservicessiterecovery/resource-manager
  • frontdoor/resource-manager
  • azure-kusto/resource-manager
  • peering/resource-manager
  • compute/resource-manager
  • sql/resource-manager
  • azuredata/resource-manager
  • storage/resource-manager
  • logic/resource-manager

@AutorestCI
Copy link

AutorestCI commented Aug 28, 2019

Automation for azure-sdk-for-go

This PR contains more than 3 context, SDK generation is not enabled. Contexts found:

  • sql/resource-manager
  • recoveryservicessiterecovery/resource-manager
  • frontdoor/resource-manager
  • containerregistry/resource-manager
  • imds/data-plane
  • hanaonazure/resource-manager
  • azuredata/resource-manager
  • storage/resource-manager
  • machinelearningservices/resource-manager
  • compute/resource-manager
  • logic/resource-manager
  • billing/resource-manager
  • peering/resource-manager
  • resources/resource-manager
  • hdinsight/resource-manager
  • managednetwork/resource-manager
  • reservations/resource-manager
  • cognitiveservices/data-plane/ComputerVision
  • azsadmin/resource-manager/network/Microsoft.Network.Admin
  • network/resource-manager
  • azure-kusto/resource-manager

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.