Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2019-08-01-preview Peering Service #6886

Merged
merged 14 commits into from
Aug 22, 2019
Merged

2019-08-01-preview Peering Service #6886

merged 14 commits into from
Aug 22, 2019

Conversation

rileymckenna
Copy link
Contributor

@rileymckenna rileymckenna commented Aug 7, 2019 •
edited
Loading

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Aug 7, 2019 •
edited
Loading

In Testing, Please Ignore

[Logs] (Generated from a0ab4de, Iteration 9)

Warning Python: test-repo-billy/azure-sdk-for-python [Logs] [Diff]
  • No packages generated.
Warning Java: test-repo-billy/azure-sdk-for-java [Logs] [Diff]
  • No packages generated.
Warning Go: test-repo-billy/azure-sdk-for-go [Logs] [Diff]
  • Warning preview/peering/mgmt/2019-03-01-preview [Logs]
Failed .NET: test-repo-billy/azure-sdk-for-net [Logs] [Diff]
Failed JavaScript: test-repo-billy/azure-sdk-for-js [Logs] [Diff]
Warning Ruby: test-repo-billy/azure-sdk-for-ruby [Logs] [Diff]
  • No packages generated.

@AutorestCI
Copy link

AutorestCI commented Aug 7, 2019 •
edited
Loading

Automation for azure-sdk-for-python

Nothing to generate for azure-sdk-for-python

@AutorestCI
Copy link

AutorestCI commented Aug 7, 2019 •
edited
Loading

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@PhoenixHe-NV
Copy link
Contributor

@OpenAPIBot sdkautomation rebuild

@rileymckenna
Copy link
Contributor Author

Are we accepted and can we merge?

@sergey-shandar sergey-shandar added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Aug 13, 2019
@openapi-sdkautomation openapi-sdkautomation bot mentioned this pull request Aug 15, 2019
Merged
@PhoenixHe-NV PhoenixHe-NV mentioned this pull request Aug 16, 2019
Closed
@rileymckenna
Copy link
Contributor Author

Can one of the admins verify this patch?

@rileymckenna rileymckenna mentioned this pull request Aug 19, 2019
Closed
@psanapathi
Copy link
Member

@sanjaiganesh Could you please review?

@sanjaiganesh sanjaiganesh added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Aug 22, 2019
@sanjaiganesh sanjaiganesh removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Aug 22, 2019
@rileymckenna
Copy link
Contributor Author

Can one of the admins verify this patch?

@sergey-shandar sergey-shandar merged commit 7eaa16a into Azure:master Aug 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanjaiganesh sanjaiganesh sanjaiganesh left review comments

@sergey-shandar sergey-shandar sergey-shandar approved these changes

Assignees

@sergey-shandar sergey-shandar

Labels
ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@rileymckenna @AutorestCI @azuresdkci @PhoenixHe-NV @psanapathi @sergey-shandar @sanjaiganesh