Remove ReplicaSet Nested Resource #7627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Testing, Please Ignore[Logs] (Generated from a7ad452, Iteration 8)
|
Automation for azure-sdk-for-goThe initial PR has been merged into your service PR: |
|
Adding WaitForARMFeedback #7064 |
|
Can one of the admins verify this patch? |
raych1
reviewed
Oct 25, 2019
...fication/domainservices/resource-manager/Microsoft.AAD/stable/2017-06-01/domainservices.json
Outdated
Show resolved
Hide resolved
raych1
requested changes
Oct 25, 2019
Note that this feature has always been in private preview - from an ARM perspective, I'm fine with making this change. |
anthony-c-martin
added
the
ARMSignedOff
anthony-c-martin
approved these changes
Oct 25, 2019
There was a problem hiding this comment.
Signing off for ARM - assuming you'll be addressing #7627 (comment).
|
Fixed the readonly property issue. |
|
@raych1 Could you complete the merge? |
raych1
approved these changes
Oct 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ReplicaSet is not a public feature and there are no customers using it. It was an internal prototype that we are now removing (behind a feature flag).
I have reviewed the ReplicaSets change with Gaurav Bhatnagar, Chris Eggert, and Anthony Martin.
Let me know if you have any questions.
Latest improvements:
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
ARM API Review Checklist
Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.
Please follow the link to find more details on API review process.