-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Key Vault ID for GET and LIST SapMonitor #6839
Added Key Vault ID for GET and LIST SapMonitor #6839
Conversation
In Testing, Please Ignore[Logs] (Generated from c5d2bc2, Iteration 2)Python: test-repo-billy/azure-sdk-for-python [Logs] [Diff]
Java: test-repo-billy/azure-sdk-for-java [Logs] [Diff]
Go: test-repo-billy/azure-sdk-for-go [Logs] [Diff]
JavaScript: test-repo-billy/azure-sdk-for-js [Logs] [Diff]
|
Automation for azure-sdk-for-pythonA PR has been created for you based on this PR content. Once this PR will be merged, content will be added to your service PR: |
Automation for azure-sdk-for-goThe initial PR has been merged into your service PR: |
Can one of the admins verify this patch? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Hi @pabowers, if you are from ARM side, please remove WaitForARMFeedback label and add ARMSignOff. |
I am not from the ARM side, which is why I did not do that |
...naonazure/resource-manager/Microsoft.HanaOnAzure/preview/2017-11-03-preview/hanaonazure.json
Show resolved
Hide resolved
Signing off from ARM side. |
Why are these tests still in progress? its been a day |
@NullMDR Do you know why CI hasn't been completed for a day? |
There's currently an incident in azure pipeline / github connection. The engineering team are actively resolving this issue. All the tests are actually passed in CI, and if you want to merge it please contact @yungezz for help. |
CI jobs has succeeded for this PR, pls see detail at https://dev.azure.com/azure-sdk/public/_build/results?buildId=87026&view=results. @PakDLiu pls let me know if the PR urgent to merge. I can force merge it. |
The PR has been out for a while. If there is no problems, Can you merge it please? Thanks! |
@yungezz Can you help merge this PR? |
avocado passed per Azure Pipeline result: https://dev.azure.com/azure-sdk/public/_build/results?buildId=87026&view=results. |
Latest improvements:
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
ARM API Review Checklist
Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.
Please follow the link to find more details on API review process.