Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Key Vault ID for GET and LIST SapMonitor #6839

Merged
merged 1 commit into from
Aug 21, 2019
Merged

Added Key Vault ID for GET and LIST SapMonitor #6839

merged 1 commit into from
Aug 21, 2019

Conversation

PakDLiu
Copy link
Contributor

@PakDLiu PakDLiu commented Aug 1, 2019

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@AutorestCI
Copy link

AutorestCI commented Aug 1, 2019

Automation for azure-sdk-for-python

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-python#6877

@AutorestCI
Copy link

AutorestCI commented Aug 1, 2019

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#5574

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@Juliehzl Juliehzl added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Aug 2, 2019
Copy link
Contributor

@pabowers pabowers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Juliehzl
Copy link
Contributor

Juliehzl commented Aug 4, 2019

Hi @pabowers, if you are from ARM side, please remove WaitForARMFeedback label and add ARMSignOff.

@pabowers
Copy link
Contributor

pabowers commented Aug 5, 2019

I am not from the ARM side, which is why I did not do that

@ravbhatnagar ravbhatnagar added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Aug 7, 2019
@ravbhatnagar
Copy link
Contributor

Signing off from ARM side.

@ravbhatnagar ravbhatnagar added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Aug 12, 2019
@PakDLiu
Copy link
Contributor Author

PakDLiu commented Aug 13, 2019

Why are these tests still in progress? its been a day

@Juliehzl
Copy link
Contributor

@NullMDR Do you know why CI hasn't been completed for a day?

@PhoenixHe-NV
Copy link
Contributor

There's currently an incident in azure pipeline / github connection. The engineering team are actively resolving this issue. All the tests are actually passed in CI, and if you want to merge it please contact @yungezz for help.

@yungezz
Copy link
Member

yungezz commented Aug 14, 2019

CI jobs has succeeded for this PR, pls see detail at https://dev.azure.com/azure-sdk/public/_build/results?buildId=87026&view=results. @PakDLiu pls let me know if the PR urgent to merge. I can force merge it.

@PakDLiu
Copy link
Contributor Author

PakDLiu commented Aug 14, 2019

The PR has been out for a while. If there is no problems, Can you merge it please? Thanks!

@Juliehzl
Copy link
Contributor

@yungezz Can you help merge this PR?

@yungezz
Copy link
Member

yungezz commented Aug 21, 2019

avocado passed per Azure Pipeline result: https://dev.azure.com/azure-sdk/public/_build/results?buildId=87026&view=results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants