Initial code to sign user in and wire up the credentials in a sample storage command #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| <InterpreterVersion> | ||
| </InterpreterVersion> | ||
| <EnableNativeCodeDebugging>False</EnableNativeCodeDebugging> | ||
| <Environment>PYTHONPATH=c:\sdk\azure-cli\src</Environment> |
There was a problem hiding this comment.
Please avoid using absolute paths that are unique to your environment/setup.
There was a problem hiding this comment.
i have reverted, i should not have checked this in at the first place.
|
We should make a universal determination regarding providing the code log or not. I would prefer to keep it for now, but I don't have a strong preference here. |
|
One thing bothering me is this will print out the credential to the log file. Also logging code will get dominating for complex VM api, and thus make the main code flow harder to read. My experience, is most diagnostic can be accomplished by either verbose logging, or proxy tools such as fiddler. |
| def get_credentials(self): | ||
| sub = [x for x in CONFIG['subscriptions'] if x['active'] == True ] | ||
|
|
||
| if not sub and subscriptions: |
There was a problem hiding this comment.
Will subscriptions be defined here?
johanste
added a commit
that referenced
this pull request
Feb 19, 2016
Initial code to sign user in and wire up the credentials in a sample storage command
This was referenced Oct 31, 2016
derekbekoe
referenced
this pull request
in derekbekoe/azure-cli
Dec 1, 2016
- Also, the dev versions have all command modules installed by default - If the user really wants to install another module, from some unknown location, they can use pip directly - * pip doesn’t support mixing editable packages with regular packages * pip install --editable and pip install clash for namespace packages #3 pypa/pip#3 And, Fix nightly build version patching as well
derekbekoe
added a commit
that referenced
this pull request
Dec 7, 2016
- Also, the dev versions have all command modules installed by default - If the user really wants to install another module, from some unknown location, they can use pip directly - * pip doesn’t support mixing editable packages with regular packages * pip install --editable and pip install clash for namespace packages #3 pypa/pip#3 And, Fix nightly build version patching as well
Closed
tjprescott
pushed a commit
that referenced
this pull request
Apr 24, 2019
* adding cluster admin option to osa create * adding direcctory read permissions to the aad app (#1) * adding cluster admin option to osa create * adding direcctory read permissions to the aad app * making active directory app always require directory permissions * infra node to 3 * adding new version of python sdk (#3) * adding cluster admin option to osa create * adding direcctory read permissions to the aad app * making app always require directory permissions * clean + infra node to 3 * fixing typo * using new version of acs python sdk * updating history.rst * Change type from scope to role * apply review * pep fix * fix merge conflict * update history and help * update recorded aks tests * Revert "update recorded aks tests" This reverts commit 8643736. * change api version for tests
jiasli
pushed a commit
that referenced
this pull request
Apr 7, 2020
DaeunYim
referenced
this pull request
in DaeunYim/azure-cli
Sep 8, 2020
testcode and some params change
ChenglongLiu
added a commit
to ChenglongLiu/azure-cli
that referenced
this pull request
Feb 1, 2021
* add secret crud test * Add cutom domain test Co-authored-by: Chenglong Liu <chengll@microsoft.com>
zhoxing-ms
pushed a commit
that referenced
this pull request
Dec 30, 2021
…arameter changes (#20682) * DPS track 2 updates * Dps track 2 core changes (#3) * Change rg to be optional Deprecate access-policy to policy Add hub name parameter options to linked hub Bucket arguments * support name or host name in linked hub * update wording to have DPS later * update expiration * Added key filter on DPS tests and re-recorded * Linter and param fixes * Fixed up extra key in tests * Use more specific CLI error types * Added comments to sharedaccesskey processor regex Co-authored-by: Ryan Kelly <rykelly@microsoft.com> Co-authored-by: Victoria Litvinova <73560279+vilit1@users.noreply.github.com>
3 tasks
|
No description provided. |
wu5bocheng
referenced
this pull request
in wu5bocheng/azure-cli
Feb 28, 2023
[Add] Add command group `microsoft.compute/virtualmachines`
evelyn-ys
added a commit
that referenced
this pull request
Jan 25, 2024
* Update SDK version * Update sdk version in setup * add flush command * test flush command * fix linting/code style failures * Add aad enablement test * Add access policy * Add access policy assignments * Add scneario test * Comment out update test * Comment edit * Adds update channel commands and tests (#3) * Add test for update channel * Add argument to cli * Az style fix * Update time for update channel test * Revert change to time for udpate channel * Kj/release 2023 08 01 (#4) * Add test for update channel * Add argument to cli * Az style fix * Update time for update channel test * Revert change to time for udpate channel * Add parameters for update channel * Redis scenario test * Fix spelling * Update test for update channel * Re run pipeline * Fix requirements for windows * Handle linter issues * Push recordings * Push aad recording * Add export import recording * Add update recordings * Cred scan * Cred scan * Add network recordings * Update help text * Update access policy assignment param * Update help text * Address review comments * Linter check Co-authored-by: Yishi Wang <yishiwang@microsoft.com> * Update help text --------- Co-authored-by: Kanchan Joshi <kanchanjoshi@microsoft.com> Co-authored-by: Austin Tolani <austintolani@microsoft.com> Co-authored-by: Oscar Barbosa Aquino <32723476+Darfeikus@users.noreply.github.com> Co-authored-by: Yishi Wang <yishiwang@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merging it in to unblock colleagues' work. I will follow up with tests soon.