[IoT] DPS track 2 update, access-policy deprecation, and linked-hub parameter changes #20682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Change rg to be optional Deprecate access-policy to policy Add hub name parameter options to linked hub Bucket arguments * support name or host name in linked hub * update wording to have DPS later * update expiration
vilit1
reviewed
Dec 9, 2021
c-ryan-k
requested review from
calvinhzy,
digimaun,
evelyn-ys,
jiasli,
jsntcy,
kairu-ms and
zhoxing-ms
as code owners
|
@zhoxing-ms Can we get this into the current milestone targeted for a January release? |
|
Add @jsntcy to help with |
zhoxing-ms
reviewed
Dec 28, 2021
zhoxing-ms
reviewed
Dec 28, 2021
zhoxing-ms
reviewed
Dec 28, 2021
zhoxing-ms
reviewed
Dec 28, 2021
zhoxing-ms
reviewed
Dec 28, 2021
zhoxing-ms
reviewed
Dec 28, 2021
zhoxing-ms
reviewed
Dec 28, 2021
zhoxing-ms
reviewed
Dec 29, 2021
Comment on lines
+36
to
+37
| val = re.sub(r'[S|s]hared[A|a]ccess[K|k]ey=([^\*].+=)', 'SharedAccessKey={}' | ||
| .format(MOCK_KEY), val, flags=re.IGNORECASE) |
There was a problem hiding this comment.
Could you add some comments or samples to explain the regular expression to increase it's readability?
There was a problem hiding this comment.
Sure, though these are just for removing SAS keys from our recorded tests.
The typical connection string response is SharedAccessKey=*** but one of our calls is either using (SDK) or receiving (service) keys in lowercase - sharedaccesskey=*** - and this just stops them from appearing in the test recordings. I can add comments to the function.
zhoxing-ms
reviewed
Dec 29, 2021
Comment on lines
+50
to
+51
| val = re.sub(br'[S|s]hared[A|a]ccess[K|k]ey=([^\*].+=)', 'SharedAccessKey={}' | ||
| .format(MOCK_KEY).encode(), val, flags=re.IGNORECASE) |
zhoxing-ms
approved these changes
Dec 29, 2021
jsntcy
approved these changes
Dec 29, 2021
jiasli
reviewed
Apr 1, 2022
| with self.command_group('iot dps access-policy', | ||
| client_factory=iot_service_provisioning_factory, | ||
| deprecate_info=self.deprecate(redirect='iot dps policy', | ||
| expiration='2.35.0') |
There was a problem hiding this comment.
The expiration causes lots of failures in CI after Azure CLI is updated to 2.35.0:
- FAIL - HIGH severity: faulty_help_example_parameters_rule
Help-Entry: `iot dps access-policy create` -
There is a violation:
"az iot dps access-policy create --dps-name MyDps --resource-group MyResourceGroup --name MyPolicy --rights EnrollmentRead" is not a valid command.
argument _subcommand: unknown parser 'access-policy' (choices: list, show, create, delete, update, linked-hub, certificate, policy).
...
- FAIL - HIGH severity: expired_command_group
Command-Group: `iot dps access-policy` - Deprecated command group is expired and should be removed.
...
- FAIL - HIGH severity: missing_command_help
Command: `iot dps access-policy create` - Missing help
Command: `iot dps access-policy delete` - Missing help
Command: `iot dps access-policy list` - Missing help
Command: `iot dps access-policy show` - Missing help
Command: `iot dps access-policy update` - Missing help
This was referenced Apr 1, 2022
Merged
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates DPS
azure-mgmt-iothubprovisioningservicesto track 2 SDK and adds convenience arguments toiot dps linked-hub createAlso begins the process of deprecating
iot dps access-policyin favor ofiot dps policynamespace for policy commands.Testing Guide
Test new
iot dps policycommands to replace alliot dps access-policycommands by simply replacingaccess-policywithpolicyin the existing commands.Test using
iot dps linked-hub createto link an IoT Hub to a DPS instance with new convenience arguments:--connection_string,--hub_name, and--hub_resource_group_nameHistory Notes
[IoT]
az iot dps access-policy: Being replaced withaz iot dps policy[IoT]
az iot dps linked-hub create: Add convenience arguments for linking hubs.This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.