Skip to content

Dps track 2 core changes #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Dec 7, 2021

Conversation

vilit1
Copy link

@vilit1 vilit1 commented Nov 30, 2021

Notes for Ryan + Paymaun

Changes to DPS core with track 2 (to reflect refactorization and changes to the DPS on the extension side)

  • change resource group to be optional
  • deprecate access-policy in favor of policy. All methods otherwise remain the same.
  • bucket arguments for linked-hub
  • add hub discovery to linked-hub functions:
    • for create, users are not required to pass in a hub connection string, they can pass in a hub name
    • for create, location can be determined from hub discovery if needed
    • for update, show and delete, linked hub no longer needs to be the hostname - hub discovery will find the right host name if needed.

Description

Testing Guide

History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.


This checklist is used to make sure that common guidelines for a pull request are followed.

Deprecate access-policy to policy
Add hub name parameter options to linked hub
Bucket arguments
@vilit1 vilit1 changed the base branch from dev to dps_track_2 November 30, 2021 00:51
@vilit1 vilit1 requested a review from c-ryan-k December 2, 2021 21:30
@vilit1
Copy link
Author

vilit1 commented Dec 2, 2021

passing tests
image

@c-ryan-k c-ryan-k merged commit 3465e0f into c-ryan-k:dps_track_2 Dec 7, 2021
c-ryan-k added a commit that referenced this pull request Jan 11, 2022
…arameter changes (Azure#20682)

* DPS track 2 updates

* Dps track 2 core changes (#3)

* Change rg to be optional
Deprecate access-policy to policy
Add hub name parameter options to linked hub
Bucket arguments

* support name or host name in linked hub

* update wording to have DPS later

* update expiration

* Added key filter on DPS tests and re-recorded

* Linter and param fixes

* Fixed up extra key in tests

* Use more specific CLI error types

* Added comments to sharedaccesskey processor regex

Co-authored-by: Ryan Kelly <rykelly@microsoft.com>
Co-authored-by: Victoria Litvinova <73560279+vilit1@users.noreply.github.com>
c-ryan-k pushed a commit that referenced this pull request Feb 21, 2024
* Update SDK version

* Update sdk version in setup

* add flush command

* test flush command

* fix linting/code style failures

* Add aad enablement test

* Add access policy

* Add access policy assignments

* Add scneario test

* Comment out update test

* Comment edit

* Adds update channel commands and tests (#3)

* Add test for update channel

* Add argument to cli

* Az style fix

* Update time for update channel test

* Revert change to time for udpate channel

* Kj/release 2023 08 01 (Azure#4)

* Add test for update channel

* Add argument to cli

* Az style fix

* Update time for update channel test

* Revert change to time for udpate channel

* Add parameters for update channel

* Redis scenario test

* Fix spelling

* Update test for update channel

* Re run pipeline

* Fix requirements for windows

* Handle linter issues

* Push recordings

* Push aad recording

* Add export import recording

* Add update recordings

* Cred scan

* Cred scan

* Add network recordings

* Update help text

* Update access policy assignment param

* Update help text

* Address review comments

* Linter check

Co-authored-by: Yishi Wang <yishiwang@microsoft.com>

* Update help text

---------

Co-authored-by: Kanchan Joshi <kanchanjoshi@microsoft.com>
Co-authored-by: Austin Tolani <austintolani@microsoft.com>
Co-authored-by: Oscar Barbosa Aquino <32723476+Darfeikus@users.noreply.github.com>
Co-authored-by: Yishi Wang <yishiwang@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants