-
Notifications
You must be signed in to change notification settings - Fork 3.2k
[IoT] BREAKING CHANGE: iot dps access-policy
: Deprecate access-policy in favor of policy
#21928
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c-ryan-k
approved these changes
Apr 4, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thanks for jumping on this so quickly 👍
iot |
digimaun
reviewed
Apr 5, 2022
digimaun
requested changes
Apr 5, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Align on arg alias.
Deprecation version was deferred by #21892. |
iot dps access-policy
: Deprecate access-policy in favor of policy
zhoxing-ms
approved these changes
Apr 6, 2022
digimaun
approved these changes
Apr 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replace access-policy with policy in
az iot dps
to align better with other command groups.Testing Guide
The following command was run to test:
azdev test test_dps_lifecycle test_dps_certificate_lifecycle test_dps_linked_hub_lifecycle
In addition, the entire iot module was tested:
azdev test iot
History Notes
The command group
az iot dps access-policy
has been deprecated and replaced withaz iot dps policy
.Related prs:
#20682
#21892
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.