Skip to content

Conversation

vilit1
Copy link
Contributor

@vilit1 vilit1 commented Apr 4, 2022

Description

Replace access-policy with policy in az iot dps to align better with other command groups.

Testing Guide
The following command was run to test:
azdev test test_dps_lifecycle test_dps_certificate_lifecycle test_dps_linked_hub_lifecycle

In addition, the entire iot module was tested:
azdev test iot

History Notes

The command group az iot dps access-policy has been deprecated and replaced with az iot dps policy .

Related prs:
#20682
#21892


This checklist is used to make sure that common guidelines for a pull request are followed.

@ghost ghost added the Auto-Assign Auto assign by bot label Apr 4, 2022
@ghost ghost requested review from wangzelin007 and yonzhan April 4, 2022 18:08
@ghost ghost assigned zhoxing-ms Apr 4, 2022
@ghost ghost added this to the Apr 2022 (2022-04-26) milestone Apr 4, 2022
@ghost ghost added the IoT label Apr 4, 2022
@vilit1 vilit1 requested a review from c-ryan-k April 4, 2022 18:08
Copy link
Member

@c-ryan-k c-ryan-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for jumping on this so quickly 👍

@yonzhan
Copy link
Collaborator

yonzhan commented Apr 5, 2022

iot

Copy link
Member

@digimaun digimaun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Align on arg alias.

@vilit1 vilit1 requested a review from digimaun April 5, 2022 20:12
@jiasli
Copy link
Member

jiasli commented Apr 6, 2022

Deprecation version was deferred by #21892.

@zhoxing-ms zhoxing-ms changed the title [iot] deprecate access-policy in favor of policy [IoT] BREAKING CHANGE: iot dps access-policy: Deprecate access-policy in favor of policy Apr 6, 2022
@zhoxing-ms zhoxing-ms merged commit 300f1d9 into Azure:dev Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Assign Auto assign by bot IoT
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants