Code bootstrap #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switched to command definitions based on multiple decorators Implemented outline of login command
Splits args parameter into expected and unexpected Adds docs
Implements storage account list command.
Adds tool to extract strings Allows config file to specify locale
johanste
added a commit
that referenced
this pull request
Feb 29, 2016
Create configuring_your_machine.md
4 tasks
6 tasks
hiaga
pushed a commit
to hiaga/azure-cli
that referenced
this pull request
Jul 16, 2021
…AULT_CLI Changes in command
Closed
lakshmikotturu
pushed a commit
to lakshmikotturu/azure-cli
that referenced
this pull request
Apr 7, 2022
{APIM} Fix for the wrong help message
Jing-song
referenced
this pull request
in zhoxing-ms/azure-cli
Feb 16, 2023
3 tasks
3 tasks
sturrent
added a commit
to sturrent/azure-cli
that referenced
this pull request
Oct 21, 2025
…gnostics Issue Azure#1: Duplicate 'Found route table' messages - RouteTableAnalyzer was called twice: once in Phase 3, once in Phase 4 - Outbound analyzer now receives pre-computed route_table_analysis from orchestrator - Removed redundant _analyze_node_subnet_udrs() method - Result: Route tables analyzed once, cleaner execution output Issue Azure#2: Misleading API server connectivity failure recommendation - CONNECTIVITY_API_SERVER_FAILURE always recommended DNS fixes - Now checks if DNS test passed before recommending DNS troubleshooting - If DNS passed but API server failed: recommends firewall/NSG/port 443 checks - If DNS failed or no DNS test: recommends DNS configuration fixes - Result: More accurate, context-aware recommendations User-reported issues from aks-fw cluster (userDefinedRouting with blocked firewall): 1. 'az aks net-diagnostics -n aks-fw -g aks-fw-rg' showed 3x 'Found route table' 2. Probe test with working DNS but blocked HTTPS incorrectly suggested DNS issues Both issues now resolved and validated.
sturrent
added a commit
to sturrent/azure-cli
that referenced
this pull request
Oct 21, 2025
Issue Azure#1: Silent test execution - Phase 9 (connectivity tests) was silent - users saw no feedback during test execution - Changed logger.info() to logger.warning() for test execution messages - Now shows: ' Running test: X' followed by '[PASSED]' or '[FAILED] - reason' - Provides immediate feedback as each test completes Issue Azure#2: Noisy summary with 'Errors: 0' - Summary always showed 'Passed: X, Failed: Y, Errors: Z' even when Z=0 - Modified breakdown to only show non-zero components - Example: 'Passed: 2, Failed: 2' instead of 'Passed: 2, Failed: 2, Errors: 0' - Cleaner, less cluttered output User feedback from testing aks-fw cluster (userDefinedRouting with firewall): 1. '[9/9] Running connectivity tests...' followed by silence was confusing 2. 'Errors: 0' in summary was noise and didn't add value Both issues now resolved. Test execution is visible and summary is cleaner.
sturrent
added a commit
to sturrent/azure-cli
that referenced
this pull request
Oct 24, 2025
Bug Azure#1: Severity Display Inconsistency - Fixed report_generator.py to map severity correctly in summary mode - Now shows [CRITICAL] vs [ERROR] labels based on actual severity - Before: All critical findings showed as [ERROR] - After: Critical findings show as [CRITICAL], errors as [ERROR] Bug Azure#2: Missing VNet Link Detection - Implemented _get_cluster_vnets_with_dns() method in misconfiguration_analyzer.py - Was stub method that always returned empty list - Now parses agent pool VNet subnet IDs and queries VNet DNS configuration - Fixed parameter passing - cluster_info now passed to helper methods - Updated method signatures: * _analyze_private_dns_issues() * _check_system_private_dns_issues() * _check_dns_server_vnet_links() * _get_cluster_vnets_with_dns() Test Results: - Severity labels now display correctly in summary mode - VNet link detection works for private clusters with custom DNS - Successfully detects when DNS server host VNet is not linked to private DNS zone Updated PHASE7-PROGRESS.md with detailed bug reports and fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provides initial structure for the tool.