Skip to content

Conversation

@simison
Copy link
Member

@simison simison commented Jan 30, 2026

Follow-up to FORMS-442

Regular jetpack build packages/forms already includes the new WP Build (since #46528), but we left watching out for now since it was just a couple of contributors working with it.

Previously, you had to run pnpm run watch:wp-build from the forms folder.

Proposed changes:

  • Include wp build watch command in regular jetpack watch packages/forms

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

  • Run watch command:
jetpack watch packages/forms

Then make changes to src folder and routes folder under forms package.

Fixes:

> Entries in 'scripts' are not in lexicographical order and grouped by lifecycleseslintpackage-json/sort-collections
@github-actions
Copy link
Contributor

github-actions bot commented Jan 30, 2026

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack), and enable the update/forms-wp-build-watch branch.
  • To test on Simple, run the following command on your sandbox:
bin/jetpack-downloader test jetpack update/forms-wp-build-watch

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions
Copy link
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds the wp-build watch command to the regular watch script for the Forms package, making it easier for developers to work with the new WP Build dashboard feature without running a separate watch command.

Changes:

  • Updated the watch script in package.json to include wp-build --watch alongside the other build watchers
  • Minor reordering of the build-production script for consistency
  • Added changelog entry documenting the change

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
projects/packages/forms/package.json Added wp-build watch to the concurrently watch command and reordered build-production script
projects/packages/forms/changelog/update-forms-watch-include-wp-build Added changelog entry documenting the watch command update

Significance: patch
Type: changed

Forms: include wp-build watch in regular watch command.
Copy link

Copilot AI Jan 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changelog entry should start with a capital letter after the "Forms:" prefix. Change "include" to "Include" to match the conventions used in other changelog entries in this package.

Copilot generated this review using guidance from repository custom instructions.
@jp-launch-control
Copy link

Code Coverage Summary

This PR did not change code coverage!

That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷

Full summary · PHP report · JS report

Copy link
Contributor

@CGastrell CGastrell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :shipit:

@simison simison merged commit 44d21cd into trunk Jan 30, 2026
82 of 83 checks passed
@simison simison deleted the update/forms-wp-build-watch branch January 30, 2026 15:10
@github-actions github-actions bot added [Status] UI Changes Add this to PRs that change the UI so documentation can be updated. and removed [Status] Needs Review This PR is ready for review. labels Jan 30, 2026
@manzoorwanijk manzoorwanijk mentioned this pull request Jan 30, 2026
1 task
@anomiex anomiex mentioned this pull request Jan 30, 2026
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Feature] Contact Form [Package] Forms [Status] UI Changes Add this to PRs that change the UI so documentation can be updated. [Type] Janitorial

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants