-
Notifications
You must be signed in to change notification settings - Fork 853
Forms: Add wp build to production build script #46528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! Jetpack plugin: The Jetpack plugin has different release cadences depending on the platform:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds the build:wp-build script to the forms package build process as a follow-up to #46509, making the WP dashboard available in CI builds. The change includes updating both the regular build and production build scripts to incorporate the new wp-build step.
Key Changes
- Added
build:wp-buildto the regularbuildscript - Added
build:wp-buildto thebuild-productionscript - Added a changelog entry documenting the addition
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| projects/packages/forms/package.json | Updates build scripts to include build:wp-build in both regular and production builds |
| projects/packages/forms/changelog/update-forms-wp-build-script | Adds changelog entry documenting the new beta build addition |
07dc489 to
c9ecacd
Compare
Code Coverage SummaryThis PR did not change code coverage! That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷 |
|
@claude please review this PR |
|
Claude finished @lezama's task in 1m 3s —— View job PR Review
Review SummaryThis PR successfully adds Analysis✅ Code Changes (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 4 out of 7 changed files in this pull request and generated 1 comment.
projects/js-packages/components/changelog/update-forms-wp-build-script
Outdated
Show resolved
Hide resolved
|
There are some build failures only caught by the CI pipeline, they do not happen locally, so I'm attempting fixes directly in this PR: The first attempt is to rename the I tried first changing the import statements to something like |
a04b1eb to
8129fd0
Compare
8129fd0 to
974178f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 8 out of 11 changed files in this pull request and generated 1 comment.
|
Converting the components to |
f103931 to
e001cd8
Compare
e001cd8 to
0328cba
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
simison
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.

Follow-up to #46509
Proposed changes:
Adds the script to the build script and the build folder to the distributed package, making the dashboard available on CI builds.
Other information:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
Testing instructions:
add_filter('jetpack_forms_alpha', '__return_true');inwp-content/mu-plugins/0-sandbox.php