Skip to content

Conversation

@anomiex
Copy link
Contributor

@anomiex anomiex commented Jan 30, 2026

Closes MONOREP-335

Proposed changes:

We lint .json and various other file types, but the CI check isn't triggering on them. Fix that.

Also expand the check for the excludelist. It probably matched the extensions that were actually in the list at some point, but it should be comprehensive in case people add new things.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Maybe? This is how #46857 managed to get merged and break linting in trunk.

Does this pull request change what data or activity we track or use?

Testing instructions:

  • Make a PR depending on this one that only touches a .json file, and see if the eslint job runs.

We lint `.json` and various other file types, but the CI check isn't
triggering on them. Fix that.

Also expand the check for the excludelist. It probably matched the
extensions that were actually in the list at some point, but it should
be comprehensive in case people add new things.
@anomiex anomiex requested a review from a team January 30, 2026 16:56
@anomiex anomiex self-assigned this Jan 30, 2026
@anomiex anomiex added [Type] Bug When a feature is broken and / or not performing as intended [Status] Needs Review This PR is ready for review. [Pri] Normal labels Jan 30, 2026
@github-actions github-actions bot added the Actions GitHub actions used to automate some of the work around releases and repository management label Jan 30, 2026
@github-actions
Copy link
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

@anomiex anomiex merged commit ac35436 into trunk Jan 30, 2026
97 of 98 checks passed
@anomiex anomiex deleted the fix/ci-eslint-skipping branch January 30, 2026 17:20
@github-actions github-actions bot removed the [Status] Needs Review This PR is ready for review. label Jan 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Actions GitHub actions used to automate some of the work around releases and repository management [Pri] Normal [Type] Bug When a feature is broken and / or not performing as intended

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants