Forms: add forms DataViews table to wpbuild dashboard #46837

edanzer · 2026-01-29T20:31:48Z

Proposed changes:

Adds the forms DataViews to table to the forms screen/route in the wp-build version of the dashboard. This code is copied from the non wp-build version of the screen here, and then adapted to the wp-build environment.

This includes:

Table. DataViews table that shows the list of jetpack_form posts
Status filter. Primary/locked filter for status (published, trashed, etc)
Trash actions. Trash, Permanently Delete, and Restore actions are all working
Bulk trash actions. Trash, Permanently Delete, and Restore actions are all working
Edit action. The Edit action will take you to the correct jetpack_forms post edit screen

Not done: View responses. This action shows but does not work. We need to add the single form screen separately.

Screenshot
Note list but also filters, actions, and bulk actions.

Other information:

Have you written new tests for your changes, if applicable?
Have you checked the E2E test CI results, and verified that your changes do not break them?
Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

Enable this feature flag to wp-build dashboard:

add_filter( 'jetpack_forms_alpha', '__return_true', 20 );

Test:

Go to Jetpack > Forms (WP-Build)
On the Forms tab, confirm you a list of any jetpack_form posts you've created.
- If you need to create some go to : YOURDOMAIN.COM/wp-admin/post-new.php?post_type=jetpack_form
Confirm Status filter works (ie, check publish and trash)
Confirm Trash, Restore, and Permanently Delete actions work
Confirm Edit action takes you to that form's edit screen

github-actions · 2026-01-29T20:32:40Z

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack), and enable the add/forms-list-wpbuild-dashboard branch.
To test on Simple, run the following command on your sandbox:

bin/jetpack-downloader test jetpack add/forms-list-wpbuild-dashboard

Interested in more tips and information?

In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
Read more about our development workflow here: PCYsg-eg0-p2
Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

github-actions · 2026-01-29T20:32:52Z

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

✅ Include a description of your PR changes.
✅ Add a "[Status]" label (In Progress, Needs Review, ...).
✅ Add testing instructions.
✅ Specify whether this PR includes any changes to data or privacy.
✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

Follow this PR Review Process:

Ensure all required checks appearing at the bottom of this PR are passing.
Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
You can use GitHub's Reviewers functionality to request a review.
When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

jp-launch-control · 2026-01-29T20:43:24Z

Code Coverage Summary

This PR did not change code coverage!

That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷

Full summary · PHP report · JS report

Copilot

Pull request overview

This PR adds a DataViews-based forms list table to the wp-build version of the Jetpack Forms dashboard. The implementation is adapted from the existing non-wpbuild forms screen to work within the wp-build environment, which uses @wordpress/route for routing instead of react-router.

Changes:

Added complete DataViews table implementation with forms list, status filtering, and CRUD actions (Trash, Restore, Delete Permanently, Edit)
Integrated URL-based search parameter synchronization using @wordpress/route
Added necessary dependencies to package.json (@wordpress/components, @wordpress/core-data, @wordpress/data, @wordpress/date, @wordpress/notices)

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File	Description
projects/packages/forms/routes/forms/stage.tsx	Replaced placeholder with full DataViews table implementation including forms list, filtering, actions, and confirmation dialogs
projects/packages/forms/routes/forms/package.json	Added required WordPress dependencies for DataViews, data management, and notifications
projects/packages/forms/changelog/add-forms-list-wpbuild-dashboard	Added changelog entry for the new feature

projects/packages/forms/routes/forms/stage.tsx

projects/packages/forms/changelog/add-forms-list-wpbuild-dashboard

enejb

This looks great and works as expected for me! Nicely done!

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.

simison · 2026-01-30T17:24:18Z

projects/packages/forms/package.json

 		"build:dashboard": "webpack --config ./tools/webpack.config.dashboard.js",
 		"build:form-editor": "webpack --config ./tools/webpack.config.form-editor.js",
 		"build:wp-build": "wp-build",
+		"build-production": "NODE_ENV=production BABEL_ENV=production pnpm run build && pnpm run validate",


This is odd; I just had the same lint error and fixed it, but the other way around, as if the linter couldn't decide which way around is correct. I simply fixed it with jetpack lint --fix 🤷

(PR was #46857)

Anyway, thanks for fixing it. Let's see if it now stays stable.

The behavior here changed in sort-package-json v3.5.2, and we recently updated from v3.5.0 to v3.6.1 in #46785.

The part I can't figure out is how you managed to need 006519e, as the pnpm-lock there shows v3.6.1 should have been used and we have pnpm configured with verifyDepsBeforeRun: install.

Maybe it fell in some odd space between packages not being updated, and me pushing & opening the PR with old packages still locally installed. Though I would've expected whole PR fail. 🤷

Actually IDE is still complaining with trunk:

It's weekend, I'll restart everything, maybe it'll go away :-D

And I see you filed #46868 :-)

A pnpm install will probably fix things. If not, maybe you have to restart your IDE to get it to pick up the changed package.

OTOH, regardless of the IDE, when you git commit then the pre-commit hook running pnpm run lint-file should have triggered the install and then fixed it back.

edanzer self-assigned this Jan 29, 2026

edanzer added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Status] In Progress [Pri] Normal [Package] Forms labels Jan 29, 2026

github-actions bot added the [Feature] Contact Form label Jan 29, 2026

edanzer marked this pull request as ready for review January 29, 2026 21:38

Copilot AI review requested due to automatic review settings January 29, 2026 21:38

Copilot started reviewing on behalf of edanzer January 29, 2026 21:38 View session

Copilot AI reviewed Jan 29, 2026

View reviewed changes

projects/packages/forms/routes/forms/stage.tsx Show resolved Hide resolved

projects/packages/forms/changelog/add-forms-list-wpbuild-dashboard Show resolved Hide resolved

enejb previously approved these changes Jan 30, 2026

View reviewed changes

edanzer added 3 commits January 30, 2026 08:33

Forms: add forms list to wpbuild dashboard

81a5ba9

changelog

f1f8ca7

Remove CFM feature flag check

a8e0961

edanzer dismissed enejb’s stale review via a8e0961 January 30, 2026 15:33

edanzer force-pushed the add/forms-list-wpbuild-dashboard branch from 0bc13b1 to a8e0961 Compare January 30, 2026 15:33

Fix lint issues

27cdf91

Copilot AI review requested due to automatic review settings January 30, 2026 16:19

Copilot started reviewing on behalf of edanzer January 30, 2026 16:19 View session

Copilot AI reviewed Jan 30, 2026

View reviewed changes

edanzer merged commit dc46575 into trunk Jan 30, 2026
77 checks passed

edanzer deleted the add/forms-list-wpbuild-dashboard branch January 30, 2026 16:45

github-actions bot added [Status] UI Changes Add this to PRs that change the UI so documentation can be updated. and removed [Status] In Progress labels Jan 30, 2026

simison reviewed Jan 30, 2026

View reviewed changes

Forms: add forms DataViews table to wpbuild dashboard #46837

Forms: add forms DataViews table to wpbuild dashboard #46837

Uh oh!

Conversation

edanzer commented Jan 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed changes:

Other information:

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

Uh oh!

github-actions bot commented Jan 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jan 29, 2026

Uh oh!

jp-launch-control bot commented Jan 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Coverage Summary

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

enejb left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

simison Jan 30, 2026

Choose a reason for hiding this comment

Uh oh!

anomiex Jan 30, 2026

Choose a reason for hiding this comment

Uh oh!

simison Jan 30, 2026

Choose a reason for hiding this comment

Uh oh!

simison Jan 30, 2026

Choose a reason for hiding this comment

Uh oh!

simison Jan 30, 2026

Choose a reason for hiding this comment

Uh oh!

anomiex Jan 30, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

edanzer commented Jan 29, 2026 •

edited

Loading

github-actions bot commented Jan 29, 2026 •

edited

Loading

jp-launch-control bot commented Jan 29, 2026 •

edited

Loading