Skip to content

Forms: add forms DataViews table to wpbuild dashboard #46837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
edanzer merged 4 commits into from
Jan 30, 2026
Merged

Forms: add forms DataViews table to wpbuild dashboard #46837

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
81a5ba9
Forms: add forms list to wpbuild dashboard
edanzer Jan 29, 2026
f1f8ca7
changelog
edanzer Jan 29, 2026
a8e0961
Remove CFM feature flag check
edanzer Jan 30, 2026
27cdf91
Fix lint issues
edanzer Jan 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions projects/packages/forms/changelog/add-forms-list-wpbuild-dashboard
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Significance: minor
Type: added

Forms: add form DataViews table to wp-build dashboard.
2 changes: 1 addition & 1 deletion projects/packages/forms/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,12 +17,12 @@
"type": "module",
"scripts": {
"build": "pnpm run clean && pnpm run build:blocks && pnpm run build:contact-form && pnpm run build:dashboard && pnpm run build:wp-build && pnpm run build:form-editor && pnpm run module:build",
"build-production": "NODE_ENV=production BABEL_ENV=production pnpm run build && pnpm run validate",
"build:blocks": "webpack --config ./tools/webpack.config.blocks.js",
"build:contact-form": "webpack --config ./tools/webpack.config.contact-form.js",
"build:dashboard": "webpack --config ./tools/webpack.config.dashboard.js",
"build:form-editor": "webpack --config ./tools/webpack.config.form-editor.js",
"build:wp-build": "wp-build",
"build-production": "NODE_ENV=production BABEL_ENV=production pnpm run build && pnpm run validate",
Copy link
Member

@simison simison Jan 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is odd; I just had the same lint error and fixed it, but the other way around, as if the linter couldn't decide which way around is correct. I simply fixed it with jetpack lint --fix 🤷

(PR was #46857)

Anyway, thanks for fixing it. Let's see if it now stays stable.

Copy link
Contributor

@anomiex anomiex Jan 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The behavior here changed in sort-package-json v3.5.2, and we recently updated from v3.5.0 to v3.6.1 in #46785.

The part I can't figure out is how you managed to need 006519e, as the pnpm-lock there shows v3.6.1 should have been used and we have pnpm configured with verifyDepsBeforeRun: install.

Copy link
Member

@simison simison Jan 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it fell in some odd space between packages not being updated, and me pushing & opening the PR with old packages still locally installed. Though I would've expected whole PR fail. 🤷

Copy link
Member

@simison simison Jan 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually IDE is still complaining with trunk:

image

It's weekend, I'll restart everything, maybe it'll go away :-D

Copy link
Member

@simison simison Jan 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And I see you filed #46868 :-)

Copy link
Contributor

@anomiex anomiex Jan 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A pnpm install will probably fix things. If not, maybe you have to restart your IDE to get it to pick up the changed package.

OTOH, regardless of the IDE, when you git commit then the pre-commit hook running pnpm run lint-file should have triggered the install and then fixed it back.

"clean": "rm -rf dist/ build/ .cache/",
"module:build": "webpack --config ./tools/webpack.config.modules.js",
"module:watch": "webpack --watch --config ./tools/webpack.config.modules.js",
Expand Down
5 changes: 5 additions & 0 deletions projects/packages/forms/routes/forms/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,15 @@
"@base-ui-components/react": "^1.0.0-beta.4",
"@types/react": "18.3.26",
"@wordpress/admin-ui": "1.6.0",
"@wordpress/components": "32.0.0",
"@wordpress/core-data": "7.38.0",
"@wordpress/data": "10.38.0",
"@wordpress/dataviews": "11.2.0",
"@wordpress/date": "5.38.0",
"@wordpress/element": "6.38.0",
"@wordpress/i18n": "6.11.0",
"@wordpress/icons": "11.5.0",
"@wordpress/notices": "5.38.0",
"@wordpress/route": "0.4.0",
"@wordpress/ui": "0.5.0",
"clsx": "2.1.1"
Expand Down
Loading
Loading