-
Notifications
You must be signed in to change notification settings - Fork 233
feat: sync language support #2123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: sync language support #2123
Conversation
|
I'm not sure why the Chrome plugin test failed, but I don't think it's because of something I changed since I didn't change anything it relies on. I checked my previous PR and it seems there's a failed test there too, but the CI didn't fail. Perhaps this is due to a config or environment error @elijah-potter? |
elijah-potter
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good stuff as always @mcecode. Thanks!
Don't worry about that failing test. It was entirely unrelated to your PR.
This MR contains the following updates: | Package | Update | Change | |---|---|---| | [Automattic/harper/harper-ls](https://github.com/Automattic/harper) | minor | `v0.70.0` -> `v0.71.0` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>Automattic/harper (Automattic/harper/harper-ls)</summary> ### [`v0.71.0`](https://github.com/Automattic/harper/releases/tag/v0.71.0) [Compare Source](Automattic/harper@v0.70.0...v0.71.0) #### What's Changed - build(deps): bump clap from 4.5.48 to 4.5.50 by [@​dependabot](https://github.com/dependabot)\[bot] in [#​2112](Automattic/harper#2112) - build(deps): bump getrandom from 0.3.3 to 0.3.4 by [@​dependabot](https://github.com/dependabot)\[bot] in [#​2113](Automattic/harper#2113) - feat(vscode): support more platforms by [@​mcecode](https://github.com/mcecode) in [#​2116](Automattic/harper#2116) - feat: introduce stale bot by [@​elijah-potter](https://github.com/elijah-potter) in [#​2117](Automattic/harper#2117) - Add wasm-bindgen-cli to nix flake by [@​bjtitus](https://github.com/bjtitus) in [#​2108](Automattic/harper#2108) - fix(core): refine acronym detection in `AnA` by [@​86xsk](https://github.com/86xsk) in [#​2109](Automattic/harper#2109) - feat(core): create `SplitWords` linter by [@​elijah-potter](https://github.com/elijah-potter) in [#​2118](Automattic/harper#2118) - Change tact by [@​hippietrail](https://github.com/hippietrail) in [#​2130](Automattic/harper#2130) - feat: quite many→quite a few by [@​hippietrail](https://github.com/hippietrail) in [#​2129](Automattic/harper#2129) - Fix typo in front page FAQ by [@​adamchainz](https://github.com/adamchainz) in [#​2125](Automattic/harper#2125) - build(deps): bump clap from 4.5.50 to 4.5.51 by [@​dependabot](https://github.com/dependabot)\[bot] in [#​2127](Automattic/harper#2127) - feat: sync language support by [@​mcecode](https://github.com/mcecode) in [#​2123](Automattic/harper#2123) - feat: passerbys→passersby by [@​hippietrail](https://github.com/hippietrail) in [#​2135](Automattic/harper#2135) - chore: reduce dependency load for new contributors by [@​elijah-potter](https://github.com/elijah-potter) in [#​2131](Automattic/harper#2131) - feat(web): Add testimonials by [@​elijah-potter](https://github.com/elijah-potter) in [#​2139](Automattic/harper#2139) - feat(core): more rules by [@​elijah-potter](https://github.com/elijah-potter) in [#​2107](Automattic/harper#2107) - feat: let/lets `<pronoun>` to do→let/lets `<pronoun>` do by [@​hippietrail](https://github.com/hippietrail) in [#​2140](Automattic/harper#2140) - feat:a lot of/most of the times→time by [@​hippietrail](https://github.com/hippietrail) in [#​2141](Automattic/harper#2141) - fix(obsidian): ignore files by [@​Vinzent03](https://github.com/Vinzent03) in [#​2143](Automattic/harper#2143) - fix: "reservation" annotations; issue [#​2120](Automattic/harper#2120) by [@​hippietrail](https://github.com/hippietrail) in [#​2134](Automattic/harper#2134) - feat(chrome-ext): 'block rule' button by [@​elijah-potter](https://github.com/elijah-potter) in [#​2145](Automattic/harper#2145) - fix: `description` and `message` were copypasted from another linter! by [@​hippietrail](https://github.com/hippietrail) in [#​2147](Automattic/harper#2147) - feat: redundant "after <duration> later" by [@​hippietrail](https://github.com/hippietrail) in [#​2146](Automattic/harper#2146) #### New Contributors - [@​bjtitus](https://github.com/bjtitus) made their first contribution in [#​2108](Automattic/harper#2108) - [@​adamchainz](https://github.com/adamchainz) made their first contribution in [#​2125](Automattic/harper#2125) - [@​Vinzent03](https://github.com/Vinzent03) made their first contribution in [#​2143](Automattic/harper#2143) **Full Changelog**: <Automattic/harper@v0.70.0...v0.71.0> </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MS4xNzMuMCIsInVwZGF0ZWRJblZlciI6IjQxLjE3My4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJSZW5vdmF0ZSBCb3QiXX0=-->
Issues
Fixes #2121
Description
scalasupport #970) support to the extension. As the linked issues indicate, they have been previously added toharper-lsbut not to the extension.harper-comments) Add support for the Scala.scextension since the official Scala Syntax extension supports it.harper-ls) Add support for using thejj-commitlanguage ID for Jujutsu Description since it's what's used by the only VS Code extension that I found that givesjjdescriptionfile support.harper-comments/src/comment_parser.rs,harper-ls/src/backend.rs,packages/vscode-plugin/package.jsonandpackages/web/src/routes/docs/integrations/language-server/+page.mdto hopefully make it easier to maintain and sync them in the future.Notes
vsoinsteadorgas the language ID for Org Mode (e.g., Org-vscode). I opted not to add support for this since it doesn't seem as standard and it would be easy to add in the future if a user wants support for it.Checklist