feat: let/lets <pronoun> to do→let/lets <pronoun> do
#2140
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
Fixes #425
Description
This doesn't attempt to fix all errors with "let" and "lets", just the ones using a pronoun and an ungrammatical "to" before the verb such as "Let me to do it" and "This lets anybody to do it".
It even works with common errors such as "let's" in place of "lets", "noone" in place of "no one", "some body" in place of "somebody", etc.
It does not lint nouns or noun phrases, only pronouns:
Those are probably more complex and should probably be done as a separate linter, at which point both linters should probably be put into a
LintGroupso that one named option enables/disables both.How Has This Been Tested?
I've added unit tests for many combinations, preferably from sentences found on GitHub, but using a few other sites too.
Checklist