Skip to content

Conversation

@Tijs-B
Copy link
Contributor

@Tijs-B Tijs-B commented Oct 15, 2025

Issues

jjdescription was briefly mentioned in #79.

Description

jjdescription file types are used by jujutsu (a VCS) to write messages in, similar to git commits. We can use tree-sitter-jjdescription and the existing markdown parser to parse these kinds of files. It is super helpful to have spell checking on these files as most of the plain English I write as a developer is in jj descriptions.

Demo

How Has This Been Tested?

I'm running this already for some time (in helix), found no issues.

Checklist

  • I have performed a self-review of my own code
  • I have added tests to cover my changes

@Tijs-B Tijs-B force-pushed the push-qrutlxlwtvtn branch 2 times, most recently from 8b3e599 to 953503b Compare October 16, 2025 18:02
Copy link
Collaborator

@elijah-potter elijah-potter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the most part, this looks good. I'm glad to hear that you've already been testing it extensively. Thanks!

jjdescription file types are used by jujutsu to write messages in,
similar to git commits. We use tree-sitter-jjdescription and the
existing markdown parser to parse these kinds of files.
@Tijs-B Tijs-B force-pushed the push-qrutlxlwtvtn branch from c1f17b2 to 41e11e1 Compare October 22, 2025 13:46
Copy link
Collaborator

@elijah-potter elijah-potter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Thanks for pushing that crate!

@elijah-potter elijah-potter added this pull request to the merge queue Oct 22, 2025
Merged via the queue into Automattic:master with commit 506dae1 Oct 22, 2025
17 checks passed
@mcecode mcecode mentioned this pull request Oct 31, 2025
2 tasks
tmeijn pushed a commit to tmeijn/dotfiles that referenced this pull request Nov 3, 2025
This MR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [Automattic/harper/harper-ls](https://github.com/Automattic/harper) | minor | `v0.68.0` -> `v0.70.0` |

MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot).

**Proposed changes to behavior should be submitted there as MRs.**

---

### Release Notes

<details>
<summary>Automattic/harper (Automattic/harper/harper-ls)</summary>

### [`v0.70.0`](https://github.com/Automattic/harper/releases/tag/v0.70.0)

[Compare Source](Automattic/harper@v0.69.0...v0.70.0)

#### What's Changed

- fix(chrome-ext): use Harper-specific HTML tag to avoid CSS conflicts by [@&#8203;elijah-potter](https://github.com/elijah-potter) in [#&#8203;2101](Automattic/harper#2101)
- feat(ls): add lint origin tags to the diagnostics by [@&#8203;elijah-potter](https://github.com/elijah-potter) in [#&#8203;2102](Automattic/harper#2102)
- fix(chrome-ext): don't override with activation from WordPress page by [@&#8203;elijah-potter](https://github.com/elijah-potter) in [#&#8203;2103](Automattic/harper#2103)
- fix(obsidian): problems when converting from Rust char indexes by [@&#8203;elijah-potter](https://github.com/elijah-potter) in [#&#8203;2104](Automattic/harper#2104)
- fix(obsidian): store user dictionary in sorted order by [@&#8203;elijah-potter](https://github.com/elijah-potter) in [#&#8203;2106](Automattic/harper#2106)
- feat(obsidian): add method to ignore all errors in file by [@&#8203;elijah-potter](https://github.com/elijah-potter) in [#&#8203;2105](Automattic/harper#2105)

**Full Changelog**: <Automattic/harper@v0.69.0...v0.70.0>

### [`v0.69.0`](https://github.com/Automattic/harper/releases/tag/v0.69.0)

[Compare Source](Automattic/harper@v0.68.0...v0.69.0)

#### What's Changed

- feat(core): create new rule for detecting missing nouns by [@&#8203;elijah-potter](https://github.com/elijah-potter) in [#&#8203;2023](Automattic/harper#2023)
- docs(integrations): fix `ignoredLintsPath` and add `excludePatterns` in sample configs by [@&#8203;mcecode](https://github.com/mcecode) in [#&#8203;2097](Automattic/harper#2097)
- build(deps): bump lru from 0.16.1 to 0.16.2 by [@&#8203;dependabot](https://github.com/dependabot)\[bot] in [#&#8203;2092](Automattic/harper#2092)
- build(deps): bump indexmap from 2.11.4 to 2.12.0 by [@&#8203;dependabot](https://github.com/dependabot)\[bot] in [#&#8203;2095](Automattic/harper#2095)
- build(deps): bump bitflags from 2.9.4 to 2.10.0 by [@&#8203;dependabot](https://github.com/dependabot)\[bot] in [#&#8203;2093](Automattic/harper#2093)
- feat: add jjdescription parser by [@&#8203;Tijs-B](https://github.com/Tijs-B) in [#&#8203;2082](Automattic/harper#2082)
- build(deps): bump tokio from 1.47.1 to 1.48.0 by [@&#8203;dependabot](https://github.com/dependabot)\[bot] in [#&#8203;2091](Automattic/harper#2091)
- build(deps): bump globset from 0.4.16 to 0.4.17 by [@&#8203;dependabot](https://github.com/dependabot)\[bot] in [#&#8203;2094](Automattic/harper#2094)
- feat(core): add `threw` as a suggestion by [@&#8203;elijah-potter](https://github.com/elijah-potter) in [#&#8203;2088](Automattic/harper#2088)
- refactor(web): build out feedback mechanisms  by [@&#8203;elijah-potter](https://github.com/elijah-potter) in [#&#8203;2069](Automattic/harper#2069)
- feat(core): more rules by [@&#8203;elijah-potter](https://github.com/elijah-potter) in [#&#8203;2090](Automattic/harper#2090)

#### New Contributors

- [@&#8203;Tijs-B](https://github.com/Tijs-B) made their first contribution in [#&#8203;2082](Automattic/harper#2082)

**Full Changelog**: <Automattic/harper@v0.68.0...v0.69.0>

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this MR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box

---

This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MS4xNTcuMCIsInVwZGF0ZWRJblZlciI6IjQxLjE1Ny4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJSZW5vdmF0ZSBCb3QiXX0=-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants