Plane: Add tkoff. and land. to landed_state method #29534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the landed_state method in the MAVLink GCS module to accurately reflect the vehicle's status during takeoff and landing in the MAV_LANDED_STATE field of EXTENDED_SYS_STATE. The method now returns MAV_LANDED_STATE_TAKEOFF if the vehicle is taking off and MAV_LANDED_STATE_LANDING if it is landing, matching the ArduCopter and Blimp implementations.
IamPete1
approved these changes
Mar 17, 2025
There was a problem hiding this comment.
LGTM. This is a improvement, although i'm not sure we populate the methods correctly for all modes. @Hwurzburg looks like we might need to add the is_landing method to the new autoland mode.
tridge
approved these changes
Mar 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the landed_state method in the MAVLink GCS module to accurately reflect the vehicle's status during takeoff and landing in the MAV_LANDED_STATE field of EXTENDED_SYS_STATE. The method now returns MAV_LANDED_STATE_TAKEOFF if the vehicle is taking off and MAV_LANDED_STATE_LANDING if it is landing, matching the ArduCopter and Blimp implementations.
In combination with mavlink/qgroundcontrol#12567, this makes it possible to abort landings in QGroundControl with ArduPilot aircraft.