Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AP_RC_Protocol: protect SBUS against bad values #25169

Merged
merged 7 commits into from
Oct 12, 2023
Merged

AP_RC_Protocol: protect SBUS against bad values #25169

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
e993dfc
AP_RCProtocol: protect against invalid data in SBUS
tridge Oct 3, 2023
82ea0d6
AP_RCProtocol: make sbus_decode public to allow for a test suite
tridge Oct 4, 2023
b26cc53
AP_SBusOut: make sbus output exactly match sbus input decoding
tridge Oct 4, 2023
290289a
HAL_Linux: use the AP_RCProtocol sbus decoder for Linux
tridge Oct 4, 2023
849082b
AP_RCProtocol: added a test suite for SBUS encode/decode
tridge Oct 4, 2023
458cbee
Tools: rebuild IO firmware
tridge Oct 3, 2023
3037d5b
AP_RCProtocol: prevent decoding past end of output array
tridge Oct 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
AP_RCProtocol: prevent decoding past end of output array 
this fixes test_sbus on clang
  • Loading branch information
@tridge
tridge committed Oct 4, 2023
commit 3037d5b50a225fead830b41a98cb306f84abfd3c
2 changes: 1 addition & 1 deletion libraries/AP_RCProtocol/AP_RCProtocol_SBUS.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ bool AP_RCProtocol_SBUS::sbus_decode(const uint8_t frame[25], uint16_t *values,

uint16_t chancount = SBUS_INPUT_CHANNELS;

decode_11bit_channels((const uint8_t*)(&frame[1]), SBUS_INPUT_CHANNELS, values,
decode_11bit_channels((const uint8_t*)(&frame[1]), max_values, values,
SBUS_TARGET_RANGE, SBUS_RANGE_RANGE, SBUS_SCALE_OFFSET);

/* decode switch channels if data fields are wide enough */
Expand Down