Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HAL_ChibiOS: don't send dshot commands when safety is on #18102

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tridge
Copy link
Contributor

@tridge tridge commented Jul 24, 2021

we shouldn't be sending anything till safety is off

we shouldn't be sending anything till safety is off
@tridge tridge added the ChibiOS label Jul 24, 2021
@tridge tridge requested a review from andyp1per July 24, 2021 07:17
@github-actions
Copy link

Heads up @bugobliterator - the "ChibiOS" label was applied to this issue.

@andyp1per
Copy link
Collaborator

@tridge this stops the LEDs working until the safety is pressed which rather defeats the purpose - so I don't think this is the right change. What are you trying to achieve?

@tridge
Copy link
Contributor Author

tridge commented Jul 24, 2021

@tridge this stops the LEDs working until the safety is pressed which rather defeats the purpose - so I don't think this is the right change. What are you trying to achieve?

ahh, I'd forgotten about the LEDs.
I've had a lot of problems with the ESCs (holybro 4-in-1 blheli32) not initialising properly on boot. I thought this helped, but its intermittent, so hard to track down

@andyp1per
Copy link
Collaborator

I've had a lot of problems with the ESCs (holybro 4-in-1 blheli32) not initialising properly on boot. I thought this helped, but its intermittent, so hard to track down

If there is a problem we should try and fix it since many boards do not have safety switches. So what issue do you see? dshot initializes quite late - I have never seen an issue with the LEDs on my TMotor 4-in-1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants