[pull] master from web-platform-tests:master #1780
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…#56769) This is manual export of test fix done in https://commits.webkit.org/303858@main on WebKit upstream, automation script was failing, so doing this manually. This test was previously relying on constructor of HighlightRegistry, which is not in specification anymore. Additionally, it also properly restore Map.prototype to its original state after the test completes. See more detailed info on WebKIt commit.
Chromium-based browsers automatically focus the URL bar on launch which can prevent focus events from firing. Fix this by ensuring the page has focus first and in some cases simply change the expectation to use document.activeElement instead.
Differential Revision: https://phabricator.services.mozilla.com/D276467 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=2006097 gecko-commit: ad61b7aa643419cdaebb5b371547f93566da1f95 gecko-reviewers: layout-anchor-positioning-reviewers, layout-reviewers, emilio
The align-self cases were not tested since all of them ended up outside the viewport. Split into two files. Bug: 467085787 Change-Id: I1641dcec2c19340ffdac3bd6126c01d1bbb1d96c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7261995 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by: Alison Maher <almaher@microsoft.com> Cr-Commit-Position: refs/heads/main@{#1559175}
Per spec[1]: "If the box is not absolutely positioned, or does not have a default anchor box, this value behaves as center and has no additional effect on how inset properties resolve." The change from 75% to 80% in the tests is to avoid relying on sub-pixel rendering. [1] https://www.w3.org/TR/css-anchor-position-1/#anchor-center Bug: 467085787 Change-Id: Id7a02c3bf14a3ee44cbad02068637154bcaafe15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7254557 Reviewed-by: Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/main@{#1559229}
Currently, SoftNavigationContext tracks the current largest text and
image records, and uses those to emit the ICP performance entry and
update metrics if and when the soft navigation entry is emitted. This CL
changes this flow so that now we track the latest un-emitted
InteractionContentfulPaint object and emit that directly. To do this,
the LCP calculator continuously updates its state and calls the Delegate
EmitPerformanceEntry method, but actual ICP emission is guarded there,
where we either create and emit it synchronously or buffer it for later.
This is being done because:
1. To unify ICP and LCP and to better control lifetime of
PaintTimingRecords (in advance of strongifying some of its fields),
we want to move the largest text and image tracking into the LCP
calculator. We don't plan to expose these values, as the records
themselves shouldn't be persisted beyond getting presentation
feedback, but SNC needs to buffer the latest candidate indefinitely.
2. We plan to guarantee the Node and MediaObject are alive through this
callback, which might not be the case now if the node is removed,
and capturing the state here ensures we have what we need for
emission.
Bug: 454082771, 454082773
Change-Id: I093d37960f774e5ca8946d8a0aa27cd9d592125f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7120640
Reviewed-by: Michal Mocny <mmocny@chromium.org>
Commit-Queue: Scott Haseley <shaseley@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1559386}
Differential Revision: https://phabricator.services.mozilla.com/D276494 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=2004112 gecko-commit: 0a17b44475f576fe5f882d7bee8940053741941b gecko-reviewers: freddyb
Also, we drop ProgressTimelineScheduler since we don't need it anymore. The update in the test is necessary (just like what we do for wpt) for make sure getComputedStyle() works after we sample the scroll timelines, because the updating of stale timelines has no effect on forced style and layout calculations triggered by getComputedStyle() or similar. In other words, initially stale timelines are visible as such through those APIs. Note: there are two new test failures because the timing of caching the current time is later than the moment we trigger the animation and scrollTo API. I will try to fix them in the following patch. In this patch we focus on switching the sampling way and to make sure we don't cause lots of regressions. Differential Revision: https://phabricator.services.mozilla.com/D269666 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1817051 gecko-commit: 239cc012563870819ca11a9eaf5658c4a9090682 gecko-reviewers: firefox-style-system-reviewers, layout-reviewers, hiro, emilio
This CL renames the aforementioned properties based on feedback given in w3c/csswg-drafts#12603 (comment) This is just a rename CL, there are no behavior changes. Bug: 357648037 Change-Id: Idf63e657ffa3a94ebe83be6799d1887cd6e26379 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7265568 Reviewed-by: Kevin Babbitt <kbabbitt@microsoft.com> Reviewed-by: Alison Maher <almaher@microsoft.com> Commit-Queue: Javier Contreras <javiercon@microsoft.com> Cr-Commit-Position: refs/heads/main@{#1559509}
Previously we had ad-hoc logic within LayoutBlockFlow and LayoutFlexibleBox to merge (some) anonymous objects. This logic was incomplete, and didn't work for all types which needed this behaviour (e.g. LayoutGrid). A complex case for this patch is: ``` <div style="display: table-cell;">1</div> <span id="remove"></span> <div style="display: table-cell;">2</div> <script>remove.remove();</script> ``` Before removal the table-cells are each within their own anonymous table, section, and row. After removal, they should be within the same table, section, and row. To do this we attempt to merge objects directly after an object has been removed from LayoutObjectChildList. Objects are merged if they they are anonymous, and compatible with the other object (e.g. the same type typically). This check is implemented as LayoutBoxModelObject::CanMergeWith. Document destruction is a useful stress-test of this new code as removing objects during this phase tests more of the merging code. As such - this patch depends on the DisableDocumentBeingDestroyed feature. All behaviour changes should be behind the flag: LayoutMergeAnonymousFix Bug: 468061895 Change-Id: Ic9ac47529509b65943481e114f563ed535c849f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7244131 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/main@{#1559408}
* first pass at mapping "open-pseudo" * adds additional mappings Noting that the spec is referenced in all of these tests: https://drafts.csswg.org/selectors-4/#open-state
The current name is a bit of a misnomer, since the "active" suffix is used whenever the request had the `Sec-Fetch-Storage-Access: active` header; it is not necessary that the request was retried. (See https://crsrc.org/c/third_party/blink/web_tests/external/wpt/storage-access-api/resources/handle-headers-retry.py;drc=5bb5f07e46bc5359319ba8e444e99d00cc9cc135;l=32-33.) Change-Id: I227344465ace3568b4ca76c136db2edd1250c08e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7265210 Commit-Queue: Dylan Cutler <dylancutler@google.com> Auto-Submit: Chris Fredrickson <cfredric@chromium.org> Reviewed-by: Dylan Cutler <dylancutler@google.com> Cr-Commit-Position: refs/heads/main@{#1559726}
Signed-off-by: Taym Haddadi <haddadi.taym@gmail.com>
…liably overflow. (#56798) * Increase large size in anchor-scroll-position-try-004.html to more reliably overflow. Before this change, the test implicitly assumes that the viewport is smaller than 1100px wide. If you run the test in a browser with a viewport wider than 1100px, the final subtest will fail. This patch increases the "big sizes" in the test to use viewport-unit lengths that will reliably trigger overflow (as the tests intend to) regardless of browser window size. Fixes web-platform-tests/interop#1236
…sers treats SVG elements (#50555) * SVG examples * Update roles.tentative.html
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
19 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )