Increase large size in anchor-scroll-position-try-004.html to more reliably overflow. #56798
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…liably overflow. Before this change, the test implicitly assumes that the viewport is smaller than 1100px wide. If you run the test in a browser with a viewport wider than 1100px, the final subtest will fail. This patch increases the "big sizes" in the test to be 4000px instead of 1000px. That makes them more-reliably trigger overflow (as they intend to) in any reasonably-sized browser window. Fixes web-platform-tests/interop#1236
Collaborator
|
There are no reviewers for this pull request. Please reach out on the chat room to get help with this. Thank you! |
Member
|
web-platform-tests/rfcs#188 is kinda related, though that's about minimum size, not maximum size. |
gsnedders
approved these changes
Dec 17, 2025
Member
gsnedders
left a comment
gsnedders
left a comment
There was a problem hiding this comment.
This looks fine to me.
However:
Contributor
Author
|
Here are wpt.fyi results, FWIW. First patch (using 4000px), green in Chrome/Firefox/Safari: After addressing review feedback & switching to 120 lvw / lvh, green in Chrome/Firefox/Safari: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change, the test implicitly assumes that the viewport is smaller than 1100px wide. If you run the test in a browser with a viewport wider than 1100px, the final subtest will fail.
This patch increases the "big sizes" in the test to be 4000px instead of 1000px. That makes them more-reliably trigger overflow (as they intend to) in any reasonably-sized browser window.
Fixes web-platform-tests/interop#1236