Skip to content

Conversation

@howard-e
Copy link
Contributor

@howard-e howard-e commented Dec 10, 2025

Hello, reviewers! As of 2025-12-05, the wpt-pr-bot is requesting reviews from code owners for changes to WEB_FEATURES.yml files. To learn more about the purpose of these files, check out this presentation from TPAC 2025, Annotating WPT to Surface the Status of the Platform.

Feature: "@font-face"
Reference: https://github.com/web-platform-dx/web-features/blob/main/features/font-face.yml

Notable exclusions:

  • css/css-fonts/test_datafont_same_origin.html, testing font-face and font-family

Copy link
Member

@dbaron dbaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This mostly looks good, but I have questions about 2 of the mappings.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the idea of the feature mapping that we map each test to a single feature, or potentially multiple features? These tests are primarily targeting the WOFF font format, so I'd probably be inclined not to call them font-face tests unless we also call them WOFF tests.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the idea of the feature mapping that we map each test to a single feature, or potentially multiple features? These tests are primarily targeting the WOFF font format, so I'd probably be inclined not to call them font-face tests unless we also call them WOFF tests.

The idea is to map to a single feature and going back over this, I agree.

files:
- font-face-*
- downloadable-font-*
- first-available-font-*
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these first-available-font-* tests also aren't primarily targeting the font-face feature. (see previous comment).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed

@dbaron
Copy link
Member

dbaron commented Dec 11, 2025

Notable exclusions:

  • css/css-fonts/test_datafont_same_origin.html, testing font-face and font-family

Also, I think this probably should count as a font-face test.

@howard-e
Copy link
Contributor Author

@dbaron thanks for the feedback! Addressed the items you mentioned in 7c7a672

# Conflicts:
#	css/css-fonts/WEB_FEATURES.yml
#	css/cssom/WEB_FEATURES.yml
@dbaron dbaron merged commit 86e98d4 into web-platform-tests:master Dec 16, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants