-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Map font-face web feature
#56644
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Map font-face web feature
#56644
Conversation
dbaron
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This mostly looks good, but I have questions about 2 of the mappings.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the idea of the feature mapping that we map each test to a single feature, or potentially multiple features? These tests are primarily targeting the WOFF font format, so I'd probably be inclined not to call them font-face tests unless we also call them WOFF tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the idea of the feature mapping that we map each test to a single feature, or potentially multiple features? These tests are primarily targeting the
WOFFfont format, so I'd probably be inclined not to call themfont-facetests unless we also call themWOFFtests.
The idea is to map to a single feature and going back over this, I agree.
css/css-fonts/WEB_FEATURES.yml
Outdated
| files: | ||
| - font-face-* | ||
| - downloadable-font-* | ||
| - first-available-font-* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think these first-available-font-* tests also aren't primarily targeting the font-face feature. (see previous comment).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed
Also, I think this probably should count as a |
# Conflicts: # css/css-fonts/WEB_FEATURES.yml # css/cssom/WEB_FEATURES.yml
Feature: "@font-face"
Reference: https://github.com/web-platform-dx/web-features/blob/main/features/font-face.yml
Notable exclusions:
css/css-fonts/test_datafont_same_origin.html, testing font-face and font-family