classifies "open-pseudo" web feature #56793
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Noting that the spec is referenced in all of these tests: https://drafts.csswg.org/selectors-4/#open-state
wpt-pr-bot
requested review from
annevk,
fantasai,
foolip,
frivoal,
jdm,
jgraham,
plinss,
tabatkins and
tkent-google
foolip
approved these changes
Dec 16, 2025
ChrisC
commented
Dec 16, 2025
| - modal-dialog-generated-content.html | ||
| - name: open-pseudo | ||
| files: | ||
| - dialog-open-pseudo-invalidation.html |
Contributor
Author
There was a problem hiding this comment.
Noting that I followed the convention already in place in this yml (dialog applies to all the tests in this subdirectory). This line adds the open-pseudo classifier to a test that is also mapped to dialog.
Not sure if that's what we want to do here. See related question in a PR mapping the button element.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Web feature documentation: https://github.com/web-platform-dx/web-features/blob/main/features/open-pseudo.yml
(Noting that the second commit here adds additional mappings to tests that directly reference the spec associated with this feature, indicating that the open-pseudo is the primary focus of the test.)
As of 2025-12-05, the wpt-pr-bot is requesting reviews from code owners for changes to WEB_FEATURES.yml files. To learn more about the purpose of these files, check out this presentation from TPAC 2025, Annotating WPT to Surface the Status of the Platform