Skip to content

Conversation

@ChrisC
Copy link
Contributor

@ChrisC ChrisC commented Dec 13, 2025

- '!button-validationmessage.html'
- '!button-validity.html'
- '!button-willvalidate-readonly-attribute.html'
- '!button-willvalidate.html'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we exclude these tests from the button feature?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question! Generally, we've been trying to avoid mapping tests to multiple web features, but I wonder if web features for HTML elements should be an exception to that practice? cc @foolip

I see that the dialog element is mapped to dialog and to various other related web features, for example. So perhaps we should do something similar here?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally we have tried to identify the primary feature being tested instead of allowing overlapping tests.

In this case the tests for constraint validation are spread across directories, but I think do make sense as currently mapped:
https://wpt.fyi/results/html/semantics?label=experimental&label=master&aligned&q=feature%3Aconstraint-validation

So I think it's best to exclude these tests from the <button> tests, and that we should do the same for <dialog> too ideally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants