Skip to content

classifies button-element web feature #56727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ChrisC wants to merge 2 commits into
base: master
Choose a base branch
from
Open

classifies button-element web feature #56727

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d2ad04b
classifies "button" web feature
ChrisC Dec 13, 2025
a688685
maps tests in `html/rendering`
ChrisC Dec 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions html/rendering/bindings/the-button-element/WEB_FEATURES.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
features:
- name: button
files: "**"
3 changes: 3 additions & 0 deletions html/rendering/widgets/button-layout/WEB_FEATURES.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
features:
- name: button
files: "**"
10 changes: 10 additions & 0 deletions html/semantics/forms/the-button-element/WEB_FEATURES.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,14 @@
features:
- name: button
files:
- '*'
- '!button-checkvalidity.html'
- '!button-setcustomvalidity.html'
- '!button-validation.html'
- '!button-validationmessage.html'
- '!button-validity.html'
- '!button-willvalidate-readonly-attribute.html'
- '!button-willvalidate.html'
Copy link
Contributor

@tkent-google tkent-google Dec 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we exclude these tests from the button feature?

Copy link
Contributor Author

@ChrisC ChrisC Dec 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question! Generally, we've been trying to avoid mapping tests to multiple web features, but I wonder if web features for HTML elements should be an exception to that practice? cc @foolip

I see that the dialog element is mapped to dialog and to various other related web features, for example. So perhaps we should do something similar here?

Copy link
Member

@foolip foolip Dec 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally we have tried to identify the primary feature being tested instead of allowing overlapping tests.

In this case the tests for constraint validation are spread across directories, but I think do make sense as currently mapped:
https://wpt.fyi/results/html/semantics?label=experimental&label=master&aligned&q=feature%3Aconstraint-validation

So I think it's best to exclude these tests from the <button> tests, and that we should do the same for <dialog> too ideally.

- name: constraint-validation
files:
- button-checkvalidity.html
Expand Down