Add AdGuard-trusted scriptlets to replace the old JS rules

[ameshkov]

https://github.com/AdguardTeam/AdguardFilters/blob/master/AnnoyancesFilter/sections/cookies_specific.txt#L4707

There are tons of JS rules in the Annoyances filter that deal with cookie consent screens.

We should find a way to use scriptlets for that. We may need to introduce a "trusted" type of scriptlets for that, allowed to the user filter and our filter lists only, i.e. trustLevel: full.

• click() an element: over 180 rules using this Add new scriptlet — for click action #23
• localStorage.setItem: over 200 rules using localStorage.setItem
• Setting cookies: over 200 rules using document.cookie.
• setting HTML elements attributes, example: Fix #69545 myuploadedpremium.de AdguardFilters#69608 — Add new scriptlet — 'trusted-set-attr' #281
• creating bait elements Add new scriptlet — 'trusted-create-element' #278
• Add new scriptlet — trusted version of 'set-constant' for none-predefined values #137
• Add new scriptlet — append/load scripts #196
• Add new scriptlet — trusted-replace-xhr-response #202

[krystian3w]

https://github.com/AdguardTeam/AdguardFilters/blob/70ee34ef97c141408bbe45f646a7f4354cd3e8cb/AnnoyancesFilter/sections/cookies_specific.txt#L4704-L5073 - daily file have new lines above 4707

[ameshkov]

I'll keep a checklist with categorized ideas in the top comment.

But I'll need examples for every kind of it.

[slavaleleka]

I suggest to mark new AdGuard-trusted scriptlets with a prefix ag- or agtrusted- so final names will be like ag-set-cookie-free or agtrusted-click-element. they also should have no aliases to emphasize that there are no analogs and as a result to prevent converting and supporting in third-party filters lists

[ameshkov]

Let's go with trusted-, it's a bit longer, but the meaning is clearer.

[AdamWr]

Regarding creating bait elements, I think that at the moment this website might be a good example - AdguardTeam/AdguardFilters#75764
Their script is obfuscated, but if I understand correctly, they are doing something like:

if ( document.getElementsByClassName("mghead").length < 1 ) {
    console.log("adblock detected");
}

so creating element with class mghead fixes anti-adblock.

[bestpika]

Can you please add sessionStorage along with it? #118

[slavaleleka]

Adblock Plus has a snippet simulate-event-poc which is related to click-an-element subtask
abp-filters/abp-filters-anti-cv@246d6ae

[ameshkov]

@slavaleleka this one is interesting, but it should definitely be limited to trusted lists only.

[krystian3w]

ABP still support all snippets form only anti-cv file or from own addons settings in place "my added rules".

So no need fastly write system for privileges (can wait as mark use other snippet as safe loaded form any filter list file).

[ameshkov]

We're adding support for "trusted" scriptlets to CoreLibs: AdguardTeam/CoreLibs#1612

Once it's added, we should start working on the new scriptlets.

[krystian3w]

I suppose all world wait for official syntax.

[AdamWr]

Regarding setting HTML elements attributes, it would be useful if we could also set attribute by getting one of the current attributes from element.

For example, here - https://hdfilmifullizle.com/13-mezar-izle
This website stores video source in data-sonrayukle attribute (and add src attribute after an ad is finished), so that would be nice, if we could also in this scriptlet get attribute from an element and add src attribute with that attribute.

Screenshot

[stanislav-atr]

These were implemented in 1.7.3 release:

• trusted-click-element
• trusted-replace-xhr-response
• trusted-replace-fetch-response
• trusted-set-local-storage-item
• trusted-set-cookie

The rest will be added in 1.8

[slavaleleka]

issues for the rest trusted scriptlets

• Add new scriptlet — trusted version of 'set-constant' for none-predefined values #137
• Add new scriptlet — 'trusted-create-element' #278
• Add new scriptlet — 'trusted-set-attr' #281

[Yuki2718]

Regarding setting HTML elements attributes, it would be useful if we could also set attribute by getting one of the current attributes from element.

With this we can replace script rules for AdguardTeam/AdguardFilters#132525, AdguardTeam/AdguardFilters#132814, AdguardTeam/AdguardFilters#135699
Maybe should add TODO comment.