Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new scriptlet — 'trusted-json-set' #308

Open
contribucious opened this issue Apr 10, 2023 · 0 comments
Open

Add new scriptlet — 'trusted-json-set' #308

contribucious opened this issue Apr 10, 2023 · 0 comments
Assignees
Labels

Comments

@contribucious
Copy link
Contributor

contribucious commented Apr 10, 2023

Hello,

Basically, in the continuity of the json-prune scriptlet (and the $jsonprune modifier, allowing more advanced queries currently), it can be pretty neat and logical to have a trusted-json-set scriptlet (and a $jsonset modifier), I would say. To either define new or modify existing JSON properties, instead of pruning them.

Some websites / web apps (TF1, M6 too nowadays, etc.) require certain (ad-related) JSON properties to be both present and boolean.
↪️ Currently fixed using JS rules but hey … let's improve/simplify that! 😉

Thank you very much! 👍

P.S. In a discussion I had a while ago with @ameshkov, there was talk of a possible untrusted version limited to true/false/etc. (i.e. a basic json-set scriptlet, thus following the same pattern as set-constant and trusted-set-constant), but probably still too risky though, I would say.

 

Related discussions:

@adguard-bot adguard-bot assigned maximtop and unassigned zzebrum Apr 28, 2023
@adguard-bot adguard-bot changed the title Add new scriptlet — 'trusted-json-set' (suggestion) Add new scriptlet — 'trusted-json-set' Oct 21, 2024
@slavaleleka slavaleleka added the Feature request Adding new feature label Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants