Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new scriptlet — append/load scripts #196

Closed
AdamWr opened this issue Feb 17, 2022 · 2 comments
Closed

Add new scriptlet — append/load scripts #196

AdamWr opened this issue Feb 17, 2022 · 2 comments

Comments

@AdamWr
Copy link
Member

AdamWr commented Feb 17, 2022

Sometimes apps cannot detect source of the request, so we need a scriptlet which we load these scripts, so source will be detected.

For example here - AdguardTeam/AdguardFilters#110659
Source of connatix.com script is not detected, so we cannot easily fix it with apps.

Screenshot

image


Another case - AdguardTeam/AdguardFilters#109135
After clicking on "Produkt bewerten" button, mpsnare.iesnare.com/snare.js is loaded and source is not detected.

Screenshot

image

@slavaleleka slavaleleka changed the title Add a scriptlet to appends/loads scripts Add new scriptlet — appends/loads scripts Apr 11, 2022
@slavaleleka slavaleleka changed the title Add new scriptlet — appends/loads scripts Add new scriptlet — append/load scripts Apr 11, 2022
@ameshkov
Copy link
Member

Actually, I think this is a wrong place to solve this kind of issues. We're trying to fix CoreLibs bug in Scriptlets which are used in all products.

Here's a better alternative solution:
AdguardTeam/CoreLibs#135 (comment)

@AdamWr could you please add similar examples to that CL issue?

@AdamWr
Copy link
Member Author

AdamWr commented Oct 12, 2022

Unfortunately, currently I don't have any other examples, but if I will find something then I will add it to mentioned issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants