Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a scriptlet to honor noscript tag #274

Closed
Yuki2718 opened this issue Jan 1, 2023 · 2 comments
Closed

Add a scriptlet to honor noscript tag #274

Yuki2718 opened this issue Jan 1, 2023 · 2 comments

Comments

@Yuki2718
Copy link

Yuki2718 commented Jan 1, 2023

Related issues:
AdguardTeam/AdguardFilters#137213
AdguardTeam/AdguardFilters#135699
AdguardTeam/AdguardFilters#134426
Curretly there's no fix for i) iOS user with DNS filtering enabled and ii) Firefox user with ETP enabled. The latter can probably be addressed with $replace and script filter, nevertheless, having such a scriptlet solves the problem completely and script filter on Firefox is available only on the next ext. release. TBH not sure about general utility as most sites hosting anti-adb rather require JS to be enabled, but I suggest to have an argument to specify selector, e.g.
#%#//scriptlet('render-noscript', 'img + noscript')
If omitted, should apply to all noscript tags.

@slavaleleka
Copy link
Contributor

could you please describe the issue and what proposed scriptlet should do?

@Yuki2718
Copy link
Author

Yuki2718 commented Feb 2, 2023

The sites in the issues hide images and one possible solution without vanilla script is disabling JS; however, it can be fixed by #106 (comment) too so I'm closing this because the latter has better general utility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants