WIP: Add reactions to messages #707
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaustubh-nair
force-pushed
the
add-reactions-to-messages
branch
3 times, most recently
from
a01b829
to
fbcc1c7
Compare
Merged
kaustubh-nair
force-pushed
the
add-reactions-to-messages
branch
from
fbcc1c7
to
5f9c68c
Compare
Presently, the emoji code and type for 'thumbs-up' is hard-coded in the react_to_message method. This commit uses the stored emoji data(in emoji_names.py) to look-up the emoji code. This change makes it easier to use model.react_to_message, in the future, for emojis other than the currently supported 'thumbs-up'.
A new pop-up EmojiPickerView will be triggered on pressing `:` key on a message. This view will be used to search and select the emoji that a user wants to add to a message. This commit includes a minimal view that only includes the 'thumbs-up' emoji. Buttons for this emoji, and a search bar for more emojis will be added in subsequent commits. Tests added.
Change the 'thumbs-up' emoji in EmojiPickerView from text to a button which on pressing can toggle the reaction on current message.
Instead of 'thumbs-up', the user can add the first 10 reactions from EMOJI_NAMES. A search box will be added subsequently to support adding other reactions. This includes '+1', al alternative to 'thumbs-up' so this commit should not cause any reduction in available features available to the user.
This ensures there is no scrolling if the pop-up contains an edit box.
kaustubh-nair
force-pushed
the
add-reactions-to-messages
branch
from
5f9c68c
to
a512681
Compare
|
@kaustubh-nair This was towards fixing #559? Was this blocked on something, or lost track of towards the end of GSoC? |
|
@neiljp This was blocked because of PopUpView refactor, but still according to the current design it is not yet compatible with it. It requires some refactoring of Popupview for it to work properly. |
|
Heads up @kaustubh-nair, we just merged some commits that conflict with the changes your made in this pull request! You can review this repository's recent commits to see where the conflicts occur. Please rebase your feature branch against the |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.