Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Add reactions to messages #707

Closed
wants to merge 11 commits into from
Closed

WIP: Add reactions to messages #707

wants to merge 11 commits into from

Commits on Oct 21, 2020

  1. model: Use stored emojis to fetch emoji data for reactions. 

    Presently, the emoji code and type for 'thumbs-up' is hard-coded
in the react_to_message method. This commit uses the stored emoji
data(in emoji_names.py) to look-up the emoji code.

This change makes it easier to use model.react_to_message, in the
future, for emojis other than the currently supported 'thumbs-up'.
    @kaustubh-nair
    kaustubh-nair committed Oct 21, 2020
    Configuration menu
    Copy the full SHA
    a825d8e View commit details
    Browse the repository at this point in the history

  2. views: Use urwid.Frame for PopUpView.

    @kaustubh-nair
    kaustubh-nair committed Oct 21, 2020
    Configuration menu
    Copy the full SHA
    5061998 View commit details
    Browse the repository at this point in the history

  3. views: Add EmojiPickerView to add reactions to messages. 

    A new pop-up EmojiPickerView will be triggered on pressing `:` key on a
message. This view will be used to search and select the emoji that a
user wants to add to a message.

This commit includes a minimal view that only includes the 'thumbs-up'
emoji. Buttons for this emoji, and a search bar for more emojis will be
added in subsequent commits.

Tests added.
    @kaustubh-nair
    kaustubh-nair committed Oct 21, 2020
    Configuration menu
    Copy the full SHA
    168b3be View commit details
    Browse the repository at this point in the history

  4. views: buttons: Toggle reaction on pressing emoji button. 

    Change the 'thumbs-up' emoji in EmojiPickerView from text to a button
which on pressing can toggle the reaction on current message.
    @kaustubh-nair
    kaustubh-nair committed Oct 21, 2020
    Configuration menu
    Copy the full SHA
    ad092e1 View commit details
    Browse the repository at this point in the history

  5. buttons: Display tick on emoji button if pressed.

    @kaustubh-nair
    kaustubh-nair committed Oct 21, 2020
    Configuration menu
    Copy the full SHA
    dfa56db View commit details
    Browse the repository at this point in the history

  6. model: refactor: Use helper method to check if message has a reaction.

    @kaustubh-nair
    kaustubh-nair committed Oct 21, 2020
    Configuration menu
    Copy the full SHA
    5f76d93 View commit details
    Browse the repository at this point in the history

  7. views: model: Support adding first 10 reactions to messages. 

    Instead of 'thumbs-up', the user can add the first 10 reactions from
EMOJI_NAMES. A search box will be added subsequently to support adding
other reactions. This includes '+1', al alternative to 'thumbs-up' so this
commit should not cause any reduction in available features available to
the user.
    @kaustubh-nair
    kaustubh-nair committed Oct 21, 2020
    Configuration menu
    Copy the full SHA
    4e235ef View commit details
    Browse the repository at this point in the history

  8. views: Allow scrolling in PopUpView only if not in editor mode. 

    This ensures there is no scrolling if the pop-up contains an edit box.
    @kaustubh-nair
    kaustubh-nair committed Oct 21, 2020
    Configuration menu
    Copy the full SHA
    b862b3c View commit details
    Browse the repository at this point in the history

  9. views: Add search box to EmojiPickerView.

    @kaustubh-nair
    kaustubh-nair committed Oct 21, 2020
    Configuration menu
    Copy the full SHA
    566f291 View commit details
    Browse the repository at this point in the history

  10. views: Add DeleteReactionView.

    @kaustubh-nair
    kaustubh-nair committed Oct 21, 2020
    Configuration menu
    Copy the full SHA
    82a6f52 View commit details
    Browse the repository at this point in the history

  11. views: Remove reaction on unchecking box.

    @kaustubh-nair
    kaustubh-nair committed Oct 21, 2020
    Configuration menu
    Copy the full SHA
    a512681 View commit details
    Browse the repository at this point in the history