Skip to content

Conversation

@pranaychandekar
Copy link
Contributor

No description provided.

Signed-off-by: pranaychandekar <pranayc6@gmail.com>
@sre-ci-robot sre-ci-robot requested review from SimFG and cxie July 21, 2023 16:23
@sre-ci-robot
Copy link
Collaborator

Welcome @pranaychandekar! It looks like this is your first PR to zilliztech/GPTCache 🎉

@pranaychandekar
Copy link
Contributor Author

@cxie @SimFG All the methods of Weaviate vector class in weaviate.py is tested with a dev installation inside a docker container. They are working as expected. Eager to get this released as soon as possible.

Signed-off-by: pranaychandekar <pranayc6@gmail.com>
Signed-off-by: pranaychandekar <pranayc6@gmail.com>
Signed-off-by: pranaychandekar <pranayc6@gmail.com>
@codecov
Copy link

codecov bot commented Jul 22, 2023

Codecov Report

Merging #493 (0c1eebd) into dev (bd152a7) will increase coverage by 0.12%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #493      +/-   ##
==========================================
+ Coverage   94.07%   94.20%   +0.12%     
==========================================
  Files          93       94       +1     
  Lines        3817     3898      +81     
==========================================
+ Hits         3591     3672      +81     
  Misses        226      226              
Impacted Files Coverage Δ
gptcache/manager/vector_data/manager.py 99.19% <100.00%> (+0.10%) ⬆️
gptcache/manager/vector_data/weaviate.py 100.00% <100.00%> (ø)
gptcache/utils/__init__.py 89.34% <100.00%> (+0.17%) ⬆️

resolved pylint issues

pylint: disabled C0413

Signed-off-by: pranaychandekar <pranayc6@gmail.com>
@SimFG
Copy link
Contributor

SimFG commented Jul 22, 2023

/lgtm
/approve

@sre-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pranaychandekar, SimFG

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 07db497 into zilliztech:dev Jul 22, 2023
@pranaychandekar
Copy link
Contributor Author

Hi @SimFG

Thanks for merging this. Assuming that this would come in next release, when can we expect the next release?

@SimFG
Copy link
Contributor

SimFG commented Jul 22, 2023

@pranaychandekar maybe tomorrow 😆

@pranaychandekar
Copy link
Contributor Author

Thanks a lot @SimFG . Team GPTCache is awesome!

@pranaychandekar
Copy link
Contributor Author

@hsm207 Now we have what you requested for in #340

Rested pushed a commit to Rested/GPTCache that referenced this pull request Aug 16, 2023
* added support for weaviate vector databse

Signed-off-by: pranaychandekar <pranayc6@gmail.com>

* added support for in local db for weaviate vector store

Signed-off-by: pranaychandekar <pranayc6@gmail.com>

* added unit test case for weaviate vector store

Signed-off-by: pranaychandekar <pranayc6@gmail.com>

* resolved unit test case error for weaviate vector store

Signed-off-by: pranaychandekar <pranayc6@gmail.com>

* increased code coverage
resolved pylint issues

pylint: disabled C0413

Signed-off-by: pranaychandekar <pranayc6@gmail.com>

---------

Signed-off-by: pranaychandekar <pranayc6@gmail.com>
Signed-off-by: Reuben Thomas-Davis <reubenestd@gmail.com>
SimFG added a commit that referenced this pull request Sep 5, 2023
* Use the old version for the chromadb (#492)

Signed-off-by: SimFG <bang.fu@zilliz.com>
Signed-off-by: Reuben Thomas-Davis <reubenestd@gmail.com>

* added support for weaviate vector databse (#493)

* added support for weaviate vector databse

Signed-off-by: pranaychandekar <pranayc6@gmail.com>

* added support for in local db for weaviate vector store

Signed-off-by: pranaychandekar <pranayc6@gmail.com>

* added unit test case for weaviate vector store

Signed-off-by: pranaychandekar <pranayc6@gmail.com>

* resolved unit test case error for weaviate vector store

Signed-off-by: pranaychandekar <pranayc6@gmail.com>

* increased code coverage
resolved pylint issues

pylint: disabled C0413

Signed-off-by: pranaychandekar <pranayc6@gmail.com>

---------

Signed-off-by: pranaychandekar <pranayc6@gmail.com>
Signed-off-by: Reuben Thomas-Davis <reubenestd@gmail.com>

* Update the version to `0.1.37` (#494)

Signed-off-by: SimFG <bang.fu@zilliz.com>
Signed-off-by: Reuben Thomas-Davis <reubenestd@gmail.com>

* ✨ support caching of async completion and cache completion

Signed-off-by: Reuben Thomas-Davis <reubenestd@gmail.com>

* ✨ add streaming support for chatcompletion

Signed-off-by: Reuben Thomas-Davis <reubenestd@gmail.com>

* ✅ improve test coverage and formatting

Signed-off-by: Reuben Thomas-Davis <reubenestd@gmail.com>

* ✨ support caching of async completion and cache completion

Signed-off-by: Reuben Thomas-Davis <reubenestd@gmail.com>

* ✨ add streaming support for chatcompletion

Signed-off-by: Reuben Thomas-Davis <reubenestd@gmail.com>

* ✅ improve test coverage and formatting

Signed-off-by: Reuben Thomas-Davis <reubenestd@gmail.com>

* correct merge duplication

Signed-off-by: Reuben Thomas-Davis <reubenestd@gmail.com>

* correct update cache callback

Signed-off-by: Reuben Thomas-Davis <reubenestd@gmail.com>

* add additional tests for improved coverage

Signed-off-by: Reuben Thomas-Davis <reubenestd@gmail.com>

* remove redundant param in docstring

Signed-off-by: Reuben Thomas-Davis <reubenestd@gmail.com>

---------

Signed-off-by: SimFG <bang.fu@zilliz.com>
Signed-off-by: Reuben Thomas-Davis <reubenestd@gmail.com>
Signed-off-by: pranaychandekar <pranayc6@gmail.com>
Co-authored-by: SimFG <bang.fu@zilliz.com>
Co-authored-by: Pranay Chandekar <pranayc6@gmail.com>
@SimFG
Copy link
Contributor

SimFG commented Nov 11, 2023

@pranaychandekar the weaviate unit test can't work. if you have a free time, please help to fix it

dequeueing pushed a commit to dequeueing/GPTCache that referenced this pull request Mar 29, 2025
* added support for weaviate vector databse

Signed-off-by: pranaychandekar <pranayc6@gmail.com>

* added support for in local db for weaviate vector store

Signed-off-by: pranaychandekar <pranayc6@gmail.com>

* added unit test case for weaviate vector store

Signed-off-by: pranaychandekar <pranayc6@gmail.com>

* resolved unit test case error for weaviate vector store

Signed-off-by: pranaychandekar <pranayc6@gmail.com>

* increased code coverage
resolved pylint issues

pylint: disabled C0413

Signed-off-by: pranaychandekar <pranayc6@gmail.com>

---------

Signed-off-by: pranaychandekar <pranayc6@gmail.com>
dequeueing pushed a commit to dequeueing/GPTCache that referenced this pull request Mar 29, 2025
…#513)

* Use the old version for the chromadb (zilliztech#492)

Signed-off-by: SimFG <bang.fu@zilliz.com>
Signed-off-by: Reuben Thomas-Davis <reubenestd@gmail.com>

* added support for weaviate vector databse (zilliztech#493)

* added support for weaviate vector databse

Signed-off-by: pranaychandekar <pranayc6@gmail.com>

* added support for in local db for weaviate vector store

Signed-off-by: pranaychandekar <pranayc6@gmail.com>

* added unit test case for weaviate vector store

Signed-off-by: pranaychandekar <pranayc6@gmail.com>

* resolved unit test case error for weaviate vector store

Signed-off-by: pranaychandekar <pranayc6@gmail.com>

* increased code coverage
resolved pylint issues

pylint: disabled C0413

Signed-off-by: pranaychandekar <pranayc6@gmail.com>

---------

Signed-off-by: pranaychandekar <pranayc6@gmail.com>
Signed-off-by: Reuben Thomas-Davis <reubenestd@gmail.com>

* Update the version to `0.1.37` (zilliztech#494)

Signed-off-by: SimFG <bang.fu@zilliz.com>
Signed-off-by: Reuben Thomas-Davis <reubenestd@gmail.com>

* ✨ support caching of async completion and cache completion

Signed-off-by: Reuben Thomas-Davis <reubenestd@gmail.com>

* ✨ add streaming support for chatcompletion

Signed-off-by: Reuben Thomas-Davis <reubenestd@gmail.com>

* ✅ improve test coverage and formatting

Signed-off-by: Reuben Thomas-Davis <reubenestd@gmail.com>

* ✨ support caching of async completion and cache completion

Signed-off-by: Reuben Thomas-Davis <reubenestd@gmail.com>

* ✨ add streaming support for chatcompletion

Signed-off-by: Reuben Thomas-Davis <reubenestd@gmail.com>

* ✅ improve test coverage and formatting

Signed-off-by: Reuben Thomas-Davis <reubenestd@gmail.com>

* correct merge duplication

Signed-off-by: Reuben Thomas-Davis <reubenestd@gmail.com>

* correct update cache callback

Signed-off-by: Reuben Thomas-Davis <reubenestd@gmail.com>

* add additional tests for improved coverage

Signed-off-by: Reuben Thomas-Davis <reubenestd@gmail.com>

* remove redundant param in docstring

Signed-off-by: Reuben Thomas-Davis <reubenestd@gmail.com>

---------

Signed-off-by: SimFG <bang.fu@zilliz.com>
Signed-off-by: Reuben Thomas-Davis <reubenestd@gmail.com>
Signed-off-by: pranaychandekar <pranayc6@gmail.com>
Co-authored-by: SimFG <bang.fu@zilliz.com>
Co-authored-by: Pranay Chandekar <pranayc6@gmail.com>
DinSanGun pushed a commit to DinSanGun/GPTCache that referenced this pull request Sep 1, 2025
* added support for weaviate vector databse

Signed-off-by: pranaychandekar <pranayc6@gmail.com>

* added support for in local db for weaviate vector store

Signed-off-by: pranaychandekar <pranayc6@gmail.com>

* added unit test case for weaviate vector store

Signed-off-by: pranaychandekar <pranayc6@gmail.com>

* resolved unit test case error for weaviate vector store

Signed-off-by: pranaychandekar <pranayc6@gmail.com>

* increased code coverage
resolved pylint issues

pylint: disabled C0413

Signed-off-by: pranaychandekar <pranayc6@gmail.com>

---------

Signed-off-by: pranaychandekar <pranayc6@gmail.com>
DinSanGun pushed a commit to DinSanGun/GPTCache that referenced this pull request Sep 1, 2025
…#513)

* Use the old version for the chromadb (zilliztech#492)

Signed-off-by: SimFG <bang.fu@zilliz.com>
Signed-off-by: Reuben Thomas-Davis <reubenestd@gmail.com>

* added support for weaviate vector databse (zilliztech#493)

* added support for weaviate vector databse

Signed-off-by: pranaychandekar <pranayc6@gmail.com>

* added support for in local db for weaviate vector store

Signed-off-by: pranaychandekar <pranayc6@gmail.com>

* added unit test case for weaviate vector store

Signed-off-by: pranaychandekar <pranayc6@gmail.com>

* resolved unit test case error for weaviate vector store

Signed-off-by: pranaychandekar <pranayc6@gmail.com>

* increased code coverage
resolved pylint issues

pylint: disabled C0413

Signed-off-by: pranaychandekar <pranayc6@gmail.com>

---------

Signed-off-by: pranaychandekar <pranayc6@gmail.com>
Signed-off-by: Reuben Thomas-Davis <reubenestd@gmail.com>

* Update the version to `0.1.37` (zilliztech#494)

Signed-off-by: SimFG <bang.fu@zilliz.com>
Signed-off-by: Reuben Thomas-Davis <reubenestd@gmail.com>

* ✨ support caching of async completion and cache completion

Signed-off-by: Reuben Thomas-Davis <reubenestd@gmail.com>

* ✨ add streaming support for chatcompletion

Signed-off-by: Reuben Thomas-Davis <reubenestd@gmail.com>

* ✅ improve test coverage and formatting

Signed-off-by: Reuben Thomas-Davis <reubenestd@gmail.com>

* ✨ support caching of async completion and cache completion

Signed-off-by: Reuben Thomas-Davis <reubenestd@gmail.com>

* ✨ add streaming support for chatcompletion

Signed-off-by: Reuben Thomas-Davis <reubenestd@gmail.com>

* ✅ improve test coverage and formatting

Signed-off-by: Reuben Thomas-Davis <reubenestd@gmail.com>

* correct merge duplication

Signed-off-by: Reuben Thomas-Davis <reubenestd@gmail.com>

* correct update cache callback

Signed-off-by: Reuben Thomas-Davis <reubenestd@gmail.com>

* add additional tests for improved coverage

Signed-off-by: Reuben Thomas-Davis <reubenestd@gmail.com>

* remove redundant param in docstring

Signed-off-by: Reuben Thomas-Davis <reubenestd@gmail.com>

---------

Signed-off-by: SimFG <bang.fu@zilliz.com>
Signed-off-by: Reuben Thomas-Davis <reubenestd@gmail.com>
Signed-off-by: pranaychandekar <pranayc6@gmail.com>
Co-authored-by: SimFG <bang.fu@zilliz.com>
Co-authored-by: Pranay Chandekar <pranayc6@gmail.com>
DinSanGun pushed a commit to DinSanGun/GPTCache that referenced this pull request Sep 1, 2025
* added support for weaviate vector databse

Signed-off-by: pranaychandekar <pranayc6@gmail.com>

* added support for in local db for weaviate vector store

Signed-off-by: pranaychandekar <pranayc6@gmail.com>

* added unit test case for weaviate vector store

Signed-off-by: pranaychandekar <pranayc6@gmail.com>

* resolved unit test case error for weaviate vector store

Signed-off-by: pranaychandekar <pranayc6@gmail.com>

* increased code coverage
resolved pylint issues

pylint: disabled C0413

Signed-off-by: pranaychandekar <pranayc6@gmail.com>

---------

Signed-off-by: pranaychandekar <pranayc6@gmail.com>
DinSanGun pushed a commit to DinSanGun/GPTCache that referenced this pull request Sep 1, 2025
…#513)

* Use the old version for the chromadb (zilliztech#492)

Signed-off-by: SimFG <bang.fu@zilliz.com>
Signed-off-by: Reuben Thomas-Davis <reubenestd@gmail.com>

* added support for weaviate vector databse (zilliztech#493)

* added support for weaviate vector databse

Signed-off-by: pranaychandekar <pranayc6@gmail.com>

* added support for in local db for weaviate vector store

Signed-off-by: pranaychandekar <pranayc6@gmail.com>

* added unit test case for weaviate vector store

Signed-off-by: pranaychandekar <pranayc6@gmail.com>

* resolved unit test case error for weaviate vector store

Signed-off-by: pranaychandekar <pranayc6@gmail.com>

* increased code coverage
resolved pylint issues

pylint: disabled C0413

Signed-off-by: pranaychandekar <pranayc6@gmail.com>

---------

Signed-off-by: pranaychandekar <pranayc6@gmail.com>
Signed-off-by: Reuben Thomas-Davis <reubenestd@gmail.com>

* Update the version to `0.1.37` (zilliztech#494)

Signed-off-by: SimFG <bang.fu@zilliz.com>
Signed-off-by: Reuben Thomas-Davis <reubenestd@gmail.com>

* ✨ support caching of async completion and cache completion

Signed-off-by: Reuben Thomas-Davis <reubenestd@gmail.com>

* ✨ add streaming support for chatcompletion

Signed-off-by: Reuben Thomas-Davis <reubenestd@gmail.com>

* ✅ improve test coverage and formatting

Signed-off-by: Reuben Thomas-Davis <reubenestd@gmail.com>

* ✨ support caching of async completion and cache completion

Signed-off-by: Reuben Thomas-Davis <reubenestd@gmail.com>

* ✨ add streaming support for chatcompletion

Signed-off-by: Reuben Thomas-Davis <reubenestd@gmail.com>

* ✅ improve test coverage and formatting

Signed-off-by: Reuben Thomas-Davis <reubenestd@gmail.com>

* correct merge duplication

Signed-off-by: Reuben Thomas-Davis <reubenestd@gmail.com>

* correct update cache callback

Signed-off-by: Reuben Thomas-Davis <reubenestd@gmail.com>

* add additional tests for improved coverage

Signed-off-by: Reuben Thomas-Davis <reubenestd@gmail.com>

* remove redundant param in docstring

Signed-off-by: Reuben Thomas-Davis <reubenestd@gmail.com>

---------

Signed-off-by: SimFG <bang.fu@zilliz.com>
Signed-off-by: Reuben Thomas-Davis <reubenestd@gmail.com>
Signed-off-by: pranaychandekar <pranayc6@gmail.com>
Co-authored-by: SimFG <bang.fu@zilliz.com>
Co-authored-by: Pranay Chandekar <pranayc6@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants