Support caching of async completion and cache completion #513

Rested · 2023-08-12T00:17:41Z

#415 addresses some of the comments here

sre-ci-robot · 2023-08-12T00:17:50Z

Welcome @Rested! It looks like this is your first PR to zilliztech/GPTCache 🎉

codecov · 2023-08-12T03:41:51Z

Codecov Report

Merging #513 (6fc861e) into dev (a3328f2) will decrease coverage by 0.96%.
Report is 13 commits behind head on dev.
The diff coverage is 31.37%.

❗ Current head 6fc861e differs from pull request most recent head 69f8378. Consider uploading reports for the commit 69f8378 to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##              dev     #513      +/-   ##
==========================================
- Coverage   94.20%   93.24%   -0.96%     
==========================================
  Files          94       94              
  Lines        3898     3967      +69     
==========================================
+ Hits         3672     3699      +27     
- Misses        226      268      +42

Files Changed	Coverage Δ
gptcache/adapter/openai.py	`80.95% <29.16%> (-13.68%)`	⬇️
gptcache/adapter/adapter.py	`87.71% <66.66%> (-0.34%)`	⬇️

... and 7 files with indirect coverage changes

sre-ci-robot · 2023-08-16T02:48:55Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Rested
To complete the pull request process, please assign xiaofan-luan after the PR has been reviewed.
You can assign the PR to them by writing /assign @xiaofan-luan in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: SimFG <bang.fu@zilliz.com> Signed-off-by: Reuben Thomas-Davis <reubenestd@gmail.com>

* added support for weaviate vector databse Signed-off-by: pranaychandekar <pranayc6@gmail.com> * added support for in local db for weaviate vector store Signed-off-by: pranaychandekar <pranayc6@gmail.com> * added unit test case for weaviate vector store Signed-off-by: pranaychandekar <pranayc6@gmail.com> * resolved unit test case error for weaviate vector store Signed-off-by: pranaychandekar <pranayc6@gmail.com> * increased code coverage resolved pylint issues pylint: disabled C0413 Signed-off-by: pranaychandekar <pranayc6@gmail.com> --------- Signed-off-by: pranaychandekar <pranayc6@gmail.com> Signed-off-by: Reuben Thomas-Davis <reubenestd@gmail.com>

Signed-off-by: SimFG <bang.fu@zilliz.com> Signed-off-by: Reuben Thomas-Davis <reubenestd@gmail.com>

Signed-off-by: Reuben Thomas-Davis <reubenestd@gmail.com>

SimFG · 2023-08-16T03:35:32Z

Thank you for your patience with this pr

Signed-off-by: Reuben Thomas-Davis <reubenestd@gmail.com>

Rested · 2023-08-18T16:14:21Z

Not sure what's up with the last ci fail

…#513) * Use the old version for the chromadb (zilliztech#492) Signed-off-by: SimFG <bang.fu@zilliz.com> Signed-off-by: Reuben Thomas-Davis <reubenestd@gmail.com> * added support for weaviate vector databse (zilliztech#493) * added support for weaviate vector databse Signed-off-by: pranaychandekar <pranayc6@gmail.com> * added support for in local db for weaviate vector store Signed-off-by: pranaychandekar <pranayc6@gmail.com> * added unit test case for weaviate vector store Signed-off-by: pranaychandekar <pranayc6@gmail.com> * resolved unit test case error for weaviate vector store Signed-off-by: pranaychandekar <pranayc6@gmail.com> * increased code coverage resolved pylint issues pylint: disabled C0413 Signed-off-by: pranaychandekar <pranayc6@gmail.com> --------- Signed-off-by: pranaychandekar <pranayc6@gmail.com> Signed-off-by: Reuben Thomas-Davis <reubenestd@gmail.com> * Update the version to `0.1.37` (zilliztech#494) Signed-off-by: SimFG <bang.fu@zilliz.com> Signed-off-by: Reuben Thomas-Davis <reubenestd@gmail.com> * ✨ support caching of async completion and cache completion Signed-off-by: Reuben Thomas-Davis <reubenestd@gmail.com> * ✨ add streaming support for chatcompletion Signed-off-by: Reuben Thomas-Davis <reubenestd@gmail.com> * ✅ improve test coverage and formatting Signed-off-by: Reuben Thomas-Davis <reubenestd@gmail.com> * ✨ support caching of async completion and cache completion Signed-off-by: Reuben Thomas-Davis <reubenestd@gmail.com> * ✨ add streaming support for chatcompletion Signed-off-by: Reuben Thomas-Davis <reubenestd@gmail.com> * ✅ improve test coverage and formatting Signed-off-by: Reuben Thomas-Davis <reubenestd@gmail.com> * correct merge duplication Signed-off-by: Reuben Thomas-Davis <reubenestd@gmail.com> * correct update cache callback Signed-off-by: Reuben Thomas-Davis <reubenestd@gmail.com> * add additional tests for improved coverage Signed-off-by: Reuben Thomas-Davis <reubenestd@gmail.com> * remove redundant param in docstring Signed-off-by: Reuben Thomas-Davis <reubenestd@gmail.com> --------- Signed-off-by: SimFG <bang.fu@zilliz.com> Signed-off-by: Reuben Thomas-Davis <reubenestd@gmail.com> Signed-off-by: pranaychandekar <pranayc6@gmail.com> Co-authored-by: SimFG <bang.fu@zilliz.com> Co-authored-by: Pranay Chandekar <pranayc6@gmail.com>

sre-ci-robot requested review from cxie and xiaofan-luan August 12, 2023 00:17

sre-ci-robot added the size/L label Aug 12, 2023

mergify bot added the needs-dco label Aug 12, 2023

Rested force-pushed the main branch from cad24c2 to 72098e8 Compare August 12, 2023 00:19

mergify bot added dco-passed and removed needs-dco labels Aug 12, 2023

SimFG changed the base branch from main to dev August 12, 2023 03:52

mergify bot added needs-dco and removed dco-passed labels Aug 16, 2023

SimFG and others added 9 commits August 16, 2023 03:53

Use the old version for the chromadb (zilliztech#492)

e16568b

Signed-off-by: SimFG <bang.fu@zilliz.com> Signed-off-by: Reuben Thomas-Davis <reubenestd@gmail.com>

Update the version to 0.1.37 (zilliztech#494)

05e3fc8

Signed-off-by: SimFG <bang.fu@zilliz.com> Signed-off-by: Reuben Thomas-Davis <reubenestd@gmail.com>

✨ support caching of async completion and cache completion

42f2ae5

Signed-off-by: Reuben Thomas-Davis <reubenestd@gmail.com>

✨ add streaming support for chatcompletion

91752e1

Signed-off-by: Reuben Thomas-Davis <reubenestd@gmail.com>

✅ improve test coverage and formatting

f10eab3

Signed-off-by: Reuben Thomas-Davis <reubenestd@gmail.com>

✨ support caching of async completion and cache completion

bb6e53d

Signed-off-by: Reuben Thomas-Davis <reubenestd@gmail.com>

✨ add streaming support for chatcompletion

1733b69

Signed-off-by: Reuben Thomas-Davis <reubenestd@gmail.com>

✅ improve test coverage and formatting

0dab42e

Signed-off-by: Reuben Thomas-Davis <reubenestd@gmail.com>

Rested force-pushed the main branch from 5490089 to 0dab42e Compare August 16, 2023 02:58

sre-ci-robot added size/XL and removed size/L labels Aug 16, 2023

mergify bot added dco-passed and removed needs-dco labels Aug 16, 2023

Merge remote-tracking branch 'upstream/main' into main

bc6240d

sre-ci-robot added size/L and removed size/XL labels Aug 16, 2023

correct merge duplication

6fc861e

Signed-off-by: Reuben Thomas-Davis <reubenestd@gmail.com>

Rested added 3 commits August 17, 2023 23:23

correct update cache callback

003884d

Signed-off-by: Reuben Thomas-Davis <reubenestd@gmail.com>

add additional tests for improved coverage

a7b6887

Signed-off-by: Reuben Thomas-Davis <reubenestd@gmail.com>

remove redundant param in docstring

69f8378

Signed-off-by: Reuben Thomas-Davis <reubenestd@gmail.com>

SimFG merged commit d19bf74 into zilliztech:dev Sep 5, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Support caching of async completion and cache completion #513

Support caching of async completion and cache completion #513

Uh oh!

Rested commented Aug 12, 2023

Uh oh!

sre-ci-robot commented Aug 12, 2023

Uh oh!

codecov bot commented Aug 12, 2023 •

edited

Loading

Uh oh!

sre-ci-robot commented Aug 16, 2023

Uh oh!

SimFG commented Aug 16, 2023

Uh oh!

Rested commented Aug 18, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Support caching of async completion and cache completion #513

Support caching of async completion and cache completion #513

Uh oh!

Conversation

Rested commented Aug 12, 2023

Uh oh!

sre-ci-robot commented Aug 12, 2023

Uh oh!

codecov bot commented Aug 12, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

sre-ci-robot commented Aug 16, 2023

Uh oh!

SimFG commented Aug 16, 2023

Uh oh!

Rested commented Aug 18, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

codecov bot commented Aug 12, 2023 •

edited

Loading