arch: unify exception header naming across architectures #66325
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
requested review from
MaureenHelm,
SgrrZhf,
SiyuanCheng-CN,
abrodkin,
bbolen,
carlocaione,
evgeniy-paltsev,
galak,
ithinuel,
microbuilder,
npitre,
povergoing,
ruuddw and
stephanosio
nashif
force-pushed
the
topic/arch/exceptions
branch
from
2b314a2 to
f7819b3
Compare
dcpleung
previously approved these changes
Dec 8, 2023
|
You do: Maybe the |
carlescufi
previously approved these changes
Dec 11, 2023
microbuilder
previously approved these changes
Dec 11, 2023
Rename exception header and use the same name as all architecture ports. Signed-off-by: Anas Nashif <anas.nashif@intel.com>
Rename exception header and use the same name as all architecture ports. Signed-off-by: Anas Nashif <anas.nashif@intel.com>
Rename exception header and use the same name as all architecture ports. Signed-off-by: Anas Nashif <anas.nashif@intel.com>
Rename exception header and use the same name as all architecture ports. Signed-off-by: Anas Nashif <anas.nashif@intel.com>
Rename exception header and use the same name as all architecture ports. Signed-off-by: Anas Nashif <anas.nashif@intel.com>
Rename exception header and use the same name as all architecture ports. Signed-off-by: Anas Nashif <anas.nashif@intel.com>
Rename exception header and use the same name as all architecture ports. Signed-off-by: Anas Nashif <anas.nashif@intel.com>
Rename exception header and use the same name as all architecture ports. Signed-off-by: Anas Nashif <anas.nashif@intel.com>
Rename exception header and use the same name as all architecture ports. Signed-off-by: Anas Nashif <anas.nashif@intel.com>
nashif
dismissed stale reviews from microbuilder, carlescufi, ruuddw, and dcpleung
via
2196e86
nashif
force-pushed
the
topic/arch/exceptions
branch
from
f7819b3 to
2196e86
Compare
Match guard with header file name. Signed-off-by: Anas Nashif <anas.nashif@intel.com>
nashif
force-pushed
the
topic/arch/exceptions
branch
from
2196e86 to
d7c40c8
Compare
npitre
approved these changes
Dec 11, 2023
dcpleung
approved these changes
Dec 11, 2023
This was referenced Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of a large effort to unify architecture interfaces, documentation and structure.
mips/riscv use exp.h
x86 uses exception.h
others use exc.h
Making all use exception.h, this will make debugging and documentation easier, i.e. the porting guide and will not leave you wondering what is the right name to pick when introducing a new arch or port.