-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
boards: nrf: port to pinctrl #43926
Merged
carlescufi
merged 97 commits into
zephyrproject-rtos:main
from
teslabs:nrf-port-boards-pinctrl
Mar 21, 2022
Merged
boards: nrf: port to pinctrl #43926
carlescufi
merged 97 commits into
zephyrproject-rtos:main
from
teslabs:nrf-port-boards-pinctrl
Mar 21, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmarull
requested review from
jfischer-no,
anangl,
mbolivar-nordic and
carlescufi
March 17, 2022 15:37
gmarull
force-pushed
the
nrf-port-boards-pinctrl
branch
3 times, most recently
from
March 18, 2022 10:44
374ce9b
to
be5cb09
Compare
gmarull
commented
Mar 18, 2022
(GPIO_PIN_CNF_PULL_Pullup << GPIO_PIN_CNF_PULL_Pos) | | ||
(GPIO_PIN_CNF_DIR_Input << GPIO_PIN_CNF_DIR_Pos); | ||
|
||
|
||
return 0; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jfischer-no please check this + -pinctrl.dtsi
file (details in commit message)
gmarull
force-pushed
the
nrf-port-boards-pinctrl
branch
from
March 18, 2022 10:53
be5cb09
to
ba5a586
Compare
anangl
reviewed
Mar 18, 2022
samples/boards/nrf/nrfx_prs/boards/nrf5340dk_nrf5340_cpuapp.overlay
Outdated
Show resolved
Hide resolved
gmarull
force-pushed
the
nrf-port-boards-pinctrl
branch
from
March 18, 2022 11:01
ba5a586
to
a6b3930
Compare
gmarull
force-pushed
the
nrf-port-boards-pinctrl
branch
from
March 18, 2022 12:06
a6b3930
to
8e2a504
Compare
anangl
reviewed
Mar 18, 2022
gmarull
force-pushed
the
nrf-port-boards-pinctrl
branch
from
March 18, 2022 12:17
8e2a504
to
2220901
Compare
gmarull
force-pushed
the
nrf-port-boards-pinctrl
branch
from
March 18, 2022 12:29
2220901
to
f11d2ea
Compare
anangl
reviewed
Mar 18, 2022
gmarull
force-pushed
the
nrf-port-boards-pinctrl
branch
from
March 18, 2022 15:45
f11d2ea
to
52ff707
Compare
anangl
approved these changes
Mar 18, 2022
gmarull
requested review from
nashif,
MaureenHelm,
rlubos,
tbursztyka,
pfalcon and
jhedberg
as code owners
March 18, 2022 16:44
nRF boards now require usage of pinctrl, migrate them. Signed-off-by: Gerard Marull-Paretas <gerard.marull@nordicsemi.no>
nRF boards now require usage of pinctrl, migrate them. Signed-off-by: Gerard Marull-Paretas <gerard.marull@nordicsemi.no>
gmarull
force-pushed
the
nrf-port-boards-pinctrl
branch
from
March 21, 2022 09:32
52ff707
to
d19ff8c
Compare
gmarull
requested review from
anangl
and removed request for
galak and
mbolivar-nordic
March 21, 2022 09:32
anangl
reviewed
Mar 21, 2022
nRF boards now require usage of pinctrl, migrate the sample and overlays. Signed-off-by: Gerard Marull-Paretas <gerard.marull@nordicsemi.no>
nRF boards now require usage of pinctrl, migrate them. Signed-off-by: Gerard Marull-Paretas <gerard.marull@nordicsemi.no>
nRF boards now require usage of pinctrl, migrate them. Signed-off-by: Gerard Marull-Paretas <gerard.marull@nordicsemi.no>
nRF boards now require usage of pinctrl, migrate them. Signed-off-by: Gerard Marull-Paretas <gerard.marull@nordicsemi.no>
nRF boards now require usage of pinctrl, migrate them. Signed-off-by: Gerard Marull-Paretas <gerard.marull@nordicsemi.no>
nRF boards now require usage of pinctrl, migrate them. Signed-off-by: Gerard Marull-Paretas <gerard.marull@nordicsemi.no>
nRF boards now require usage of pinctrl, migrate them. Signed-off-by: Gerard Marull-Paretas <gerard.marull@nordicsemi.no>
nRF boards now require usage of pinctrl, migrate them. Signed-off-by: Gerard Marull-Paretas <gerard.marull@nordicsemi.no>
nRF boards now require usage of pinctrl, migrate them. Signed-off-by: Gerard Marull-Paretas <gerard.marull@nordicsemi.no>
nRF boards now require usage of pinctrl, migrate them. Signed-off-by: Gerard Marull-Paretas <gerard.marull@nordicsemi.no>
The sample relied on `-pin` properties from QSPI node, move to pinctrl. Signed-off-by: Gerard Marull-Paretas <gerard.marull@nordicsemi.no>
The nrf52840dk_nrf52840 board has been ported to pinctrl, so there's no need to keep duplicated definitions in the sample anymore. Signed-off-by: Gerard Marull-Paretas <gerard.marull@nordicsemi.no>
nRF boards are expected to use pinctrl now, so port this sample as well. Signed-off-by: Gerard Marull-Paretas <gerard.marull@nordicsemi.no>
gmarull
force-pushed
the
nrf-port-boards-pinctrl
branch
from
March 21, 2022 09:52
d19ff8c
to
72d5423
Compare
anangl
approved these changes
Mar 21, 2022
erwango
approved these changes
Mar 21, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 for shields changes
carlescufi
approved these changes
Mar 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port all nRF nased boards to pinctrl. Overlay files have also been updated.
Note: the process has been assisted by the
pinctrl_nrf_migrate.py
script:The script handles most cases, but some required manual adjustments.
_defconfig
files have been modified with this script:I created a commit per board/test/sample, so that it's easier to spot issues or to later check what was done for a particular board.