boards: arm: Add support for Arduino Nicla Sense ME #42143

benjaminbjornsson · 2022-01-25T19:37:37Z

This commit adds support for the Arduino Nicla Sense ME board.
The board functionality has been tested with various samples
such as hello_world, philosophers and peripheral_dis.

Signed-off-by: Benjamin Björnsson benjamin.bjornsson@gmail.com

tejlmand

Thanks for this contribution.

A minor request for removing an optional empty file.

tejlmand · 2022-02-15T21:21:27Z

boards/arm/arduino_nicla_sense_me/Kconfig

@@ -0,0 +1,8 @@
+# Arduino Nicla Sense ME board configuration


This file is optional, so as it is anyway empty it can simply be removed.

Yes, thank you 👍

mbolivar-nordic

Thanks for your contribution! I noticed a few issues, but I'd be glad to see support for this board added.

mbolivar-nordic · 2022-02-17T20:59:29Z

boards/arm/arduino_nicla_sense_me/arduino_nicla_sense_me.dts

+	aliases {
+
+	};


Please remove this node if you don't intend to define aliases here.

mbolivar-nordic · 2022-02-17T21:01:45Z

boards/arm/arduino_nicla_sense_me/board.cmake

@@ -0,0 +1,5 @@
+# SPDX-License-Identifier: Apache-2.0
+
+set(OPENOCD_NRF5_SUBFAMILY "nrf52")


Why is this here if you are not including openocd support? Please either remove this line or add openocd support to the board.

I probably thought it had some effect on pyocd... I'll just remove that line since it works without it 👍

Regarding support for openocd, I just can't get anything other than pyocd working.

mbolivar-nordic · 2022-02-17T21:02:37Z

boards/arm/arduino_nicla_sense_me/arduino_nicla_sense_me_defconfig

+# enable sam-ba bootloader
+CONFIG_BOOTLOADER_BOSSA=y


board.cmake is only declaring support for pyocd, so why is this enabling bossa here? I would have expected support for the bossac runner enabled in board.cmake.

To my understanding bossa doesn't support SAMD11 so I'll just remove this line 👍

benjaminbjornsson · 2022-03-10T05:00:26Z

@tejlmand ping

tejlmand

lgtm

benjaminbjornsson · 2022-03-17T18:31:29Z

Is there anything I should do about the failed test in order for this to get merged? Seems to me like it's unrelated to my pull request?

MaureenHelm · 2022-03-17T20:42:26Z

Is there anything I should do about the failed test in order for this to get merged? Seems to me like it's unrelated to my pull request?

Please rebase to pick up the fix

benjaminbjornsson · 2022-03-17T21:43:52Z

Should I re-request review?

tejlmand

lgtm - re-approved

gmarull

All in-tree boards have now been ported to pinctrl, so please do the same here. You can refer to #43926 for more details.

carlescufi · 2022-03-21T14:33:47Z

All in-tree boards have now been ported to pinctrl, so please do the same here. You can refer to #43926 for more details.

Sorry for this @benjaminbjornsson, your PR landed in the middle of a pinctrl transition.

gmarull · 2022-03-21T14:36:50Z

You can try with:

python scripts/utils/pinctrl_nrf_migrate.py -i boards/arm/arduino_nicla_sense_me/arduino_nicla_sense_me.dts --no-backup --header $'/*\n * Copyright (c) 2022 Benjamin Björnsson <benjamin.bjornsson@gmail.com>.\n * SPDX-License-Identifier: Apache-2.0\n */\n\n'

and add CONFIG_PINCTRL=y to the board defconfig

This commit adds support for the Arduino Nicla Sense ME board. The board functionality has been tested using the samples: - hello_world - philosophers - peripheral_dis - spi_flash Signed-off-by: Benjamin Björnsson <benjamin.bjornsson@gmail.com>

carlescufi

LGTM now, thank you!

carlescufi · 2022-03-21T17:36:47Z

@benjaminbjornsson ignore the compliance check failure, it's unrelated to your patches.

gmarull · 2022-03-21T17:39:49Z

looks like you'll need to rebase after #44042 (hotfix)...

benjaminbjornsson requested review from galak, MaureenHelm and nashif as code owners January 25, 2022 19:37

github-actions bot added area: Boards area: Devicetree area: Documentation labels Jan 25, 2022

benjaminbjornsson force-pushed the add_support_arduino_nano_sense_me branch from 840868f to e62e98f Compare January 25, 2022 20:52

zephyrbot added the area: Build System label Jan 26, 2022

zephyrbot requested review from carlescufi, gmarull, mbolivar-nordic, SebastianBoe, tejlmand and utzig January 26, 2022 15:18

zephyrbot assigned carlescufi Jan 26, 2022

benjaminbjornsson force-pushed the add_support_arduino_nano_sense_me branch 5 times, most recently from 4613703 to fcaa4e2 Compare January 30, 2022 20:32

github-actions bot added the area: Samples Samples label Jan 30, 2022

SebastianBoe removed their request for review January 31, 2022 14:02

tejlmand requested changes Feb 15, 2022

View reviewed changes

benjaminbjornsson force-pushed the add_support_arduino_nano_sense_me branch from fcaa4e2 to 04d2e81 Compare February 16, 2022 15:35

mbolivar-nordic suggested changes Feb 17, 2022

View reviewed changes

benjaminbjornsson force-pushed the add_support_arduino_nano_sense_me branch from 04d2e81 to fe2a080 Compare February 19, 2022 10:17

benjaminbjornsson requested review from tejlmand and mbolivar-nordic February 19, 2022 15:06

mbolivar-nordic previously approved these changes Feb 21, 2022

View reviewed changes

tejlmand previously approved these changes Mar 14, 2022

View reviewed changes

benjaminbjornsson dismissed stale reviews from tejlmand and mbolivar-nordic via c33a51e March 17, 2022 21:11

benjaminbjornsson force-pushed the add_support_arduino_nano_sense_me branch from fe2a080 to c33a51e Compare March 17, 2022 21:11

tejlmand previously approved these changes Mar 18, 2022

View reviewed changes

gmarull requested changes Mar 21, 2022

View reviewed changes

benjaminbjornsson dismissed tejlmand’s stale review via 834c211 March 21, 2022 17:14

benjaminbjornsson force-pushed the add_support_arduino_nano_sense_me branch from c33a51e to 834c211 Compare March 21, 2022 17:14

carlescufi requested a review from gmarull March 21, 2022 17:35

carlescufi approved these changes Mar 21, 2022

View reviewed changes

gmarull approved these changes Mar 21, 2022

View reviewed changes

carlescufi merged commit ab6f5cf into zephyrproject-rtos:main Mar 21, 2022

benjaminbjornsson deleted the add_support_arduino_nano_sense_me branch July 1, 2022 17:17

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

boards: arm: Add support for Arduino Nicla Sense ME #42143

boards: arm: Add support for Arduino Nicla Sense ME #42143

benjaminbjornsson commented Jan 25, 2022

tejlmand left a comment

tejlmand Feb 15, 2022

benjaminbjornsson Feb 16, 2022

mbolivar-nordic left a comment

mbolivar-nordic Feb 17, 2022

mbolivar-nordic Feb 17, 2022

benjaminbjornsson Feb 19, 2022 •

edited

Loading

benjaminbjornsson Feb 19, 2022

mbolivar-nordic Feb 17, 2022

benjaminbjornsson Feb 19, 2022

benjaminbjornsson commented Mar 10, 2022

tejlmand left a comment

benjaminbjornsson commented Mar 17, 2022 •

edited

Loading

MaureenHelm commented Mar 17, 2022

benjaminbjornsson commented Mar 17, 2022

tejlmand left a comment

gmarull left a comment

carlescufi commented Mar 21, 2022

gmarull commented Mar 21, 2022

carlescufi left a comment

carlescufi commented Mar 21, 2022

gmarull commented Mar 21, 2022

		@@ -0,0 +1,5 @@
		# SPDX-License-Identifier: Apache-2.0

		set(OPENOCD_NRF5_SUBFAMILY "nrf52")

boards: arm: Add support for Arduino Nicla Sense ME #42143

boards: arm: Add support for Arduino Nicla Sense ME #42143

Conversation

benjaminbjornsson commented Jan 25, 2022

tejlmand left a comment

Choose a reason for hiding this comment

tejlmand Feb 15, 2022

Choose a reason for hiding this comment

benjaminbjornsson Feb 16, 2022

Choose a reason for hiding this comment

mbolivar-nordic left a comment

Choose a reason for hiding this comment

mbolivar-nordic Feb 17, 2022

Choose a reason for hiding this comment

mbolivar-nordic Feb 17, 2022

Choose a reason for hiding this comment

benjaminbjornsson Feb 19, 2022 • edited Loading

Choose a reason for hiding this comment

benjaminbjornsson Feb 19, 2022

Choose a reason for hiding this comment

mbolivar-nordic Feb 17, 2022

Choose a reason for hiding this comment

benjaminbjornsson Feb 19, 2022

Choose a reason for hiding this comment

benjaminbjornsson commented Mar 10, 2022

tejlmand left a comment

Choose a reason for hiding this comment

benjaminbjornsson commented Mar 17, 2022 • edited Loading

MaureenHelm commented Mar 17, 2022

benjaminbjornsson commented Mar 17, 2022

tejlmand left a comment

Choose a reason for hiding this comment

gmarull left a comment

Choose a reason for hiding this comment

carlescufi commented Mar 21, 2022

gmarull commented Mar 21, 2022

carlescufi left a comment

Choose a reason for hiding this comment

carlescufi commented Mar 21, 2022

gmarull commented Mar 21, 2022

benjaminbjornsson Feb 19, 2022 •

edited

Loading

benjaminbjornsson commented Mar 17, 2022 •

edited

Loading