Use testcontainers to run redis-server
#1960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If it works we can also try to use it for etcd skipper/etcd/etcdtest/mocketcd.go Lines 45 to 47 in 100ef1b |
AlexanderYastrebov
force-pushed
the
use-test-containers-for-redis-server
branch
2 times, most recently
from
e147bf9
to
4417c1d
Compare
Mitigates build failures caused by package manager redirects during `redis-server` installation. Note that change adds many dependencies but they are only used for tests and do not end up in the build. Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
AlexanderYastrebov
force-pushed
the
use-test-containers-for-redis-server
branch
from
4417c1d
to
aaaff64
Compare
szuecs
reviewed
Feb 17, 2022
| ContainerRequest: testcontainers.ContainerRequest{ | ||
| Image: "redis:6-alpine", | ||
| Cmd: args, | ||
| ExposedPorts: []string{"6379/tcp"}, |
There was a problem hiding this comment.
Does a test container gets it's own IP?
There was a problem hiding this comment.
It gets a mapped port on localhost that we obtain using .Endpoint below
There was a problem hiding this comment.
sounds like we could test sharding with this too, but we need to change the port for the next ones :)
|
Do you also want to add etcd? |
I thought about doing it in separate PR, this one should fix build failures |
|
👍 |
| @@ -8,8 +8,6 @@ pipeline: | |||
| commands: | |||
| - desc: build-push | |||
| cmd: | | |||
| apt-get update -o Acquire::http::AllowRedirect=false | |||
| apt-get install -o Acquire::http::AllowRedirect=false -y bzr redis-server jq | |||
There was a problem hiding this comment.
I don't see bzr used anywhere but I think this would break a Makefile that depends on jq
|
👍 |
AlexanderYastrebov
added a commit
that referenced
this pull request
Feb 18, 2022
`jq` installation was removed by #1960 but it is required by `packaging/Makefile` Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
AlexanderYastrebov
added a commit
that referenced
this pull request
Feb 18, 2022
`jq` installation was removed by #1960 but it is required by `packaging/Makefile` Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mitigates build failures caused by package manager redirects during
redis-serverinstallation.Note that change adds many dependencies but they are only used for tests and do not end up in the build.
Signed-off-by: Alexander Yastrebov alexander.yastrebov@zalando.de