-
Notifications
You must be signed in to change notification settings - Fork 349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reconsider use of redis
build tag
#1854
Comments
#1960 introduced testcontainers to run redis tests |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
With in the #1853 (comment) it was discovered that
redis
tag condition is not used properly and that redis-dependent tests were always executed.This is not a bad thing to run as many tests as possible so maybe we should simply eliminate redis build tag altogether.
The idea behind the tag was to exclude tests that depend on the
redis-server
binary. The alternative could be to run all tests by default and introduce a make target to disable redis tests explicitlyThe text was updated successfully, but these errors were encountered: