Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconsider use of redis build tag #1854

Closed
AlexanderYastrebov opened this issue Sep 9, 2021 · 1 comment · Fixed by #2553
Closed

Reconsider use of redis build tag #1854

AlexanderYastrebov opened this issue Sep 9, 2021 · 1 comment · Fixed by #2553

Comments

@AlexanderYastrebov
Copy link
Member

AlexanderYastrebov commented Sep 9, 2021

With in the #1853 (comment) it was discovered that redis tag condition is not used properly and that redis-dependent tests were always executed.
This is not a bad thing to run as many tests as possible so maybe we should simply eliminate redis build tag altogether.

The idea behind the tag was to exclude tests that depend on the redis-server binary. The alternative could be to run all tests by default and introduce a make target to disable redis tests explicitly

@AlexanderYastrebov
Copy link
Member Author

AlexanderYastrebov commented Aug 31, 2023

#1960 introduced testcontainers to run redis tests

AlexanderYastrebov added a commit that referenced this issue Aug 31, 2023
Make cicheck is equvalent to shortcheck due to wrong redis build tag
use, see #1854

This change removes redis build tag and replaces cicheck with shortcheck
target.

Fixes #1854

Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
AlexanderYastrebov added a commit that referenced this issue Aug 31, 2023
Make cicheck is equvalent to shortcheck due to wrong redis build tag
use, see #1854

This change removes redis build tag, build comments and replaces cicheck
with the shortcheck target.

Fixes #1854

Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
AlexanderYastrebov added a commit that referenced this issue Aug 31, 2023
Make cicheck is equvalent to shortcheck due to wrong redis build tag
use, see #1854

This change removes redis build tag, build comments and replaces cicheck
with the shortcheck target.

Fixes #1854

Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant