Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use testcontainers to run etcd #2451

Open
AlexanderYastrebov opened this issue Jul 12, 2023 · 2 comments
Open

Use testcontainers to run etcd #2451

AlexanderYastrebov opened this issue Jul 12, 2023 · 2 comments

Comments

@AlexanderYastrebov
Copy link
Member

Is your feature request related to a problem? Please describe.

Currently etcd tests launch standalone binary, see https://github.com/zalando/skipper/blob/master/etcd/etcdtest/mocketcd.go

Describe the solution you would like

Launch etcd via testcontainers similar to Redis, see #1960

Would you like to work on it?
Yes

@AlexanderYastrebov AlexanderYastrebov changed the title Use testcontainers to run etcd test Use testcontainers to run etcd Jul 12, 2023
@remychantenay
Copy link
Contributor

@AlexanderYastrebov do you still plan on working on this?

@szuecs
Copy link
Member

szuecs commented Sep 27, 2023

@remychantenay if you want to contribute, then please open a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants