Skip to content

Conversation

@benlife5
Copy link
Contributor

Checked through the list of bug items that were marked as done -- a few things were broken with the default layout but working when I dragged on a new component so the default data just needed some prop updates

asanehisa
asanehisa previously approved these changes Nov 19, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 19, 2025

Walkthrough

The pull request makes structural updates to footer and card components in the visual editor. A migration simplifies the CopyrightSlot data structure in ExpandedFooter by removing the nested constantValue wrapper. The default layout data file is updated to localize CTA labels from strings to objects, add event tracking identifiers (eventName) to CTA slots, introduce conditional rendering logic on multiple insight cards based on category and publish date, and refactor the CopyrightMessageSlot with new IDs and a simplified data shape across footer sections.

Possibly related PRs

Suggested reviewers

  • mkilpatrick
  • briantstephan
  • asanehisa

Pre-merge checks and finishing touches

✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title 'fix: default layout data fixes' directly relates to the changeset, which updates default layout data structures in two files to fix broken default layouts.
Description check ✅ Passed The description explains that bugs were found in the default layout when checked against completed items, and that the fix adjusts props in the default data to match newly dragged components.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch final-fixes

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8427b65 and 5d98dbb.

📒 Files selected for processing (2)
  • packages/visual-editor/src/components/migrations/0041_expanded_footer_slots.ts (1 hunks)
  • packages/visual-editor/src/vite-plugin/defaultLayoutData.ts (11 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: call_unit_test / unit_tests (18.x)
  • GitHub Check: call_unit_test / unit_tests (20.x)
  • GitHub Check: semgrep/ci
🔇 Additional comments (4)
packages/visual-editor/src/components/migrations/0041_expanded_footer_slots.ts (1)

165-168: LGTM! Simplified data structure for CopyrightSlot.

The migration correctly flattens the CopyrightSlot data structure by removing the nested constantValue wrapper and setting text directly to either the provided copyrightMessage or a default multilingual object. This aligns with the PR's goal of matching newly dragged component behavior.

packages/visual-editor/src/vite-plugin/defaultLayoutData.ts (3)

898-898: LGTM! Consistent eventName additions for analytics tracking.

The eventName fields have been added consistently to ProductCard and InsightCard CTAs, following a clear pattern (cta0, cta1, cta2) that matches the card indices. This enables proper analytics tracking for these sections.

Also applies to: 1027-1027, 1156-1156, 2455-2455, 2613-2613, 2771-2771


2314-2317: LGTM! ConditionalRender logic added for InsightCards.

The conditionalRender blocks have been consistently added to all three InsightCards, enabling them to conditionally display based on the presence of category and publish time data. This matches the expected behavior of newly dragged components.

Also applies to: 2472-2475, 2630-2633


3763-3765: LGTM! CopyrightMessageSlot simplified and aligned with migration.

The CopyrightMessageSlot data structure has been updated consistently in both the main and directory layouts to match the migration in 0041_expanded_footer_slots.ts. The simplified structure removes nested wrapping and uses a direct text value with localization support, aligning with the new component behavior.

Also applies to: 4498-4500

Tip

📝 Customizable high-level summaries are now available in beta!

You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.

  • Provide your own instructions using the high_level_summary_instructions setting.
  • Format the summary however you like (bullet lists, tables, multi-section layouts, contributor stats, etc.).
  • Use high_level_summary_in_walkthrough to move the summary from the description to the walkthrough section.

Example instruction:

"Divide the high-level summary into five sections:

  1. 📝 Description — Summarize the main change in 50–60 words, explaining what was done.
  2. 📓 References — List relevant issues, discussions, documentation, or related PRs.
  3. 📦 Dependencies & Requirements — Mention any new/updated dependencies, environment variable changes, or configuration updates.
  4. 📊 Contributor Summary — Include a Markdown table showing contributions:
    | Contributor | Lines Added | Lines Removed | Files Changed |
  5. ✔️ Additional Notes — Add any extra reviewer context.
    Keep each section concise (under 200 words) and use bullet or numbered lists for clarity."

Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@benlife5 benlife5 merged commit 18ea615 into fall-2025-slot-ify-components Nov 19, 2025
15 checks passed
@benlife5 benlife5 deleted the final-fixes branch November 19, 2025 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants