fix: line height in rich text and reduced event description #972

rkeerthient · 2026-01-05T20:37:05Z

Reduced Event Section's description to 2 lines.
Updated body and heading to use proportional line-heights (1.5 for body text, 1.2 for headings) instead of calculated pixel-based values.

Screen.Recording.2026-01-06.at.2.03.00.AM.mov

github-actions · 2026-01-05T20:37:22Z

Warning: Component files have been updated but no migrations have been added. See https://github.com/yext/visual-editor/blob/main/packages/visual-editor/src/components/migrations/README.md for more information.

coderabbitai · 2026-01-05T20:40:07Z

Walkthrough

Replaces calc-based line-height rules in maybeRTF.css with fixed numeric values (1.5 for body text and 1.2 for headings/links) including responsive blocks. Adds an rtfHtml sample string and three new Grid test entries for BodyText variants (sm, base, lg); these entries are duplicated later in the test file. Removes the trailing sentence "Ut enim ad minim veniam." from several localized English rich-text strings (defaultEvent.description and multiple entries in mainDefaultLayout).

Sequence Diagram(s)

(omitted — changes do not introduce new multi-component control flow)

Possibly related PRs

fix: footer logo empty state and body font family for banner and hours table #934: Modifies default rich-text/localized layout text and RTF handling, touching the same defaultLayoutData content changed here.
feat: added global transformations to heading and body #926: Alters the same RTF CSS selectors (p, li, h1–h6), making it directly related to the line-height/styling adjustments.

Suggested reviewers

asanehisa
mkilpatrick

🚥 Pre-merge checks | ✅ 2

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately reflects the two main changes: fixing line height in rich text and reducing event description length.
Description check	✅ Passed	The description clearly relates to the changeset, explaining the line-height updates and event description reduction with referenced tickets.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

📝 Generate docstrings

📜 Recent review details

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3371d54 and 2f7f544.

📒 Files selected for processing (2)

packages/visual-editor/src/components/pageSections/EventSection/EventCard.tsx
packages/visual-editor/src/vite-plugin/defaultLayoutData.ts

🚧 Files skipped from review as they are similar to previous changes (2)

packages/visual-editor/src/components/pageSections/EventSection/EventCard.tsx
packages/visual-editor/src/vite-plugin/defaultLayoutData.ts

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)

GitHub Check: call_unit_test / unit_tests (20.x)
GitHub Check: call_unit_test / unit_tests (24.x)
GitHub Check: call_unit_test / unit_tests (22.x)
GitHub Check: semgrep/ci

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (1)

packages/visual-editor/src/components/layoutBlocks/Grid.test.tsx (1)

1680-1799: LGTM! Good test coverage for BodyText variants with new line-height.

The three test cases effectively verify rendering of all BodyText variants (sm, base, lg) with the updated proportional line-height values. The tests will capture any visual regressions through screenshot comparison.

💡 Optional: Consider parameterizing the variant tests

The three test cases have identical structure except for the variant property. You could reduce duplication by parameterizing:

+  ["sm", "base", "lg"].forEach((variant) => {
+    tests.push({
+      name: `version 49 - Body text - ${variant} variant`,
       document: {
         address: testAddress,
         id: "test-id",
         name: "Galaxy Grill",
       },
       props: {
         columns: 1,
         slots: [
           {
             Column: [
               {
                 type: "BodyText",
                 props: {
                   id: "BodyText-547941ef-1bc8-4e88-96e6-81b3b65a4f54",
                   data: {
                     text: {
                       field: "",
                       constantValue: {
                         en: {
                           html: rtfHtml,
                         },
                         hasLocalizedValue: "true",
                       },
                       constantValueEnabled: true,
                     },
                   },
-                  styles: { variant: "sm" },
+                  styles: { variant },
                 },
               },
             ],
           },
         ],
         backgroundColor: { bgColor: "bg-white", textColor: "text-black" },
         liveVisibility: true,
         analytics: { scope: "gridSection" },
       },
       version: 49,
+    });
+  });

However, the current explicit approach is also valid and may be easier to debug.

📜 Review details

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4099eb7 and 8546345.

⛔ Files ignored due to path filters (33)

packages/visual-editor/src/components/testing/screenshots/Grid/[desktop] version 18 - atoms used to make a CoreInfoSection.png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**
packages/visual-editor/src/components/testing/screenshots/Grid/[desktop] version 18 - atoms used to make a HeroSection.png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**
packages/visual-editor/src/components/testing/screenshots/Grid/[desktop] version 19 - single grid.png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**
packages/visual-editor/src/components/testing/screenshots/Grid/[desktop] version 19 - various CTAs.png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**
packages/visual-editor/src/components/testing/screenshots/Grid/[desktop] version 19 - various atoms.png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**
packages/visual-editor/src/components/testing/screenshots/Grid/[desktop] version 29 - various CTAs.png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**
packages/visual-editor/src/components/testing/screenshots/Grid/[desktop] version 45 - CTAs with Dark background.png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**
packages/visual-editor/src/components/testing/screenshots/Grid/[desktop] version 45 - CTAs with different site colors.png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**
packages/visual-editor/src/components/testing/screenshots/Grid/[desktop] version 49 - Body text - base variant.png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**
packages/visual-editor/src/components/testing/screenshots/Grid/[desktop] version 49 - Body text - large variant.png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**
packages/visual-editor/src/components/testing/screenshots/Grid/[desktop] version 49 - Body text - small variant.png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**
packages/visual-editor/src/components/testing/screenshots/Grid/[mobile] version 18 - atoms used to make a CoreInfoSection.png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**
packages/visual-editor/src/components/testing/screenshots/Grid/[mobile] version 18 - atoms used to make a HeroSection.png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**
packages/visual-editor/src/components/testing/screenshots/Grid/[mobile] version 19 - single grid.png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**
packages/visual-editor/src/components/testing/screenshots/Grid/[mobile] version 19 - various CTAs.png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**
packages/visual-editor/src/components/testing/screenshots/Grid/[mobile] version 19 - various atoms.png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**
packages/visual-editor/src/components/testing/screenshots/Grid/[mobile] version 29 - various CTAs.png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**
packages/visual-editor/src/components/testing/screenshots/Grid/[mobile] version 45 - CTAs with Dark background.png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**
packages/visual-editor/src/components/testing/screenshots/Grid/[mobile] version 45 - CTAs with different site colors.png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**
packages/visual-editor/src/components/testing/screenshots/Grid/[mobile] version 49 - Body text - base variant.png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**
packages/visual-editor/src/components/testing/screenshots/Grid/[mobile] version 49 - Body text - large variant.png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**
packages/visual-editor/src/components/testing/screenshots/Grid/[mobile] version 49 - Body text - small variant.png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**
packages/visual-editor/src/components/testing/screenshots/Grid/[tablet] version 18 - atoms used to make a CoreInfoSection.png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**
packages/visual-editor/src/components/testing/screenshots/Grid/[tablet] version 18 - atoms used to make a HeroSection.png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**
packages/visual-editor/src/components/testing/screenshots/Grid/[tablet] version 19 - single grid.png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**
packages/visual-editor/src/components/testing/screenshots/Grid/[tablet] version 19 - various CTAs.png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**
packages/visual-editor/src/components/testing/screenshots/Grid/[tablet] version 19 - various atoms.png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**
packages/visual-editor/src/components/testing/screenshots/Grid/[tablet] version 29 - various CTAs.png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**
packages/visual-editor/src/components/testing/screenshots/Grid/[tablet] version 45 - CTAs with Dark background.png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**
packages/visual-editor/src/components/testing/screenshots/Grid/[tablet] version 45 - CTAs with different site colors.png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**
packages/visual-editor/src/components/testing/screenshots/Grid/[tablet] version 49 - Body text - base variant.png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**
packages/visual-editor/src/components/testing/screenshots/Grid/[tablet] version 49 - Body text - large variant.png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**
packages/visual-editor/src/components/testing/screenshots/Grid/[tablet] version 49 - Body text - small variant.png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**

📒 Files selected for processing (3)

packages/visual-editor/src/components/atoms/maybeRTF.css
packages/visual-editor/src/components/layoutBlocks/Grid.test.tsx
packages/visual-editor/src/components/pageSections/EventSection/EventCard.tsx

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)

GitHub Check: call_unit_test / unit_tests (24.x)
GitHub Check: call_unit_test / unit_tests (22.x)
GitHub Check: call_unit_test / unit_tests (20.x)
GitHub Check: semgrep/ci

🔇 Additional comments (3)

packages/visual-editor/src/components/pageSections/EventSection/EventCard.tsx (1)

42-44: LGTM! Default description shortened appropriately.

The removal of the sentence aligns with the PR objective to reduce the Event Section's description to 2 lines for the default event card text.

packages/visual-editor/src/components/atoms/maybeRTF.css (1)

1-102: LGTM! Excellent switch to proportional line-height values.

The migration from calc(var(--fontSize-...) + 4px) to unitless proportional values (1.5 for body text/links, 1.2 for headings) is a CSS best practice. Unitless line-height scales proportionally with font-size changes and is more maintainable.

packages/visual-editor/src/components/layoutBlocks/Grid.test.tsx (1)

42-43: LGTM! Comprehensive RTF HTML test content added.

The rtfHtml constant provides comprehensive coverage of rich text elements (headings, paragraphs, lists, links, bold text) that will exercise the line-height changes introduced in maybeRTF.css.

…cription

.../components/testing/screenshots/EventSection/[mobile] version 0 props with entity values.png

…cription

packages/visual-editor/src/components/pageSections/EventSection/EventCard.tsx

coderabbitai

Actionable comments posted: 1

🤖 Fix all issues with AI agents

In @packages/visual-editor/src/vite-plugin/defaultLayoutData.ts:
- Around line 3224-3225: The first and third EventCard placeholder entries are
using the longer description; update the EventCard instances at index 0 and
index 2 in the default layout data so their json and html description fields
match the shortened two-line placeholder used by EventCard index 1 (i.e.,
replace the long "Ut enim ad minim veniam." text with the same truncated Lorem
ipsum string and equivalent HTML span/p tag styling used by index 1) so all
three EventCards have identical two-line default descriptions.

📜 Review details

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6f1ca92 and 51d4a79.

⛔ Files ignored due to path filters (49)

packages/visual-editor/src/components/testing/screenshots/NearbyLocationsSection/[mobile] default props with multiple nearby locations.png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**
packages/visual-editor/src/components/testing/screenshots/NearbyLocationsSection/[mobile] version 10 with multiple nearby locations.png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**
packages/visual-editor/src/components/testing/screenshots/NearbyLocationsSection/[mobile] version 36 with multiple nearby locations.png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**
packages/visual-editor/src/components/testing/screenshots/PromoSection/[desktop] [classic] version 50 props with constant values and image.png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**
packages/visual-editor/src/components/testing/screenshots/PromoSection/[desktop] [classic] version 50 with constant values and video.png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**
packages/visual-editor/src/components/testing/screenshots/PromoSection/[desktop] [classic] version 50 with entity values.png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**
packages/visual-editor/src/components/testing/screenshots/PromoSection/[desktop] [compact] version 50 with constant values and image.png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**
packages/visual-editor/src/components/testing/screenshots/PromoSection/[desktop] [compact] version 50 with constant values and video.png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**
packages/visual-editor/src/components/testing/screenshots/PromoSection/[desktop] [compact] version 50 with entity values.png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**
packages/visual-editor/src/components/testing/screenshots/PromoSection/[desktop] [immersive] version 50 with constant values.png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**
packages/visual-editor/src/components/testing/screenshots/PromoSection/[desktop] [immersive] version 50 with entity values.png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**
packages/visual-editor/src/components/testing/screenshots/PromoSection/[desktop] [spotlight] version 50 with constant values.png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**
packages/visual-editor/src/components/testing/screenshots/PromoSection/[desktop] [spotlight] version 50 with entity values.png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**
packages/visual-editor/src/components/testing/screenshots/PromoSection/[desktop] version 0 props with entity values.png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**
packages/visual-editor/src/components/testing/screenshots/PromoSection/[desktop] version 16 props using entity values with old CTA structure.png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**
packages/visual-editor/src/components/testing/screenshots/PromoSection/[desktop] version 30 props with entity values.png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**
packages/visual-editor/src/components/testing/screenshots/PromoSection/[mobile] [classic] version 50 props with constant values and image.png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**
packages/visual-editor/src/components/testing/screenshots/PromoSection/[mobile] [classic] version 50 with constant values and video.png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**
packages/visual-editor/src/components/testing/screenshots/PromoSection/[mobile] [classic] version 50 with entity values.png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**
packages/visual-editor/src/components/testing/screenshots/PromoSection/[mobile] [compact] version 50 with constant values and image.png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**
packages/visual-editor/src/components/testing/screenshots/PromoSection/[mobile] [compact] version 50 with constant values and video.png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**
packages/visual-editor/src/components/testing/screenshots/PromoSection/[mobile] [compact] version 50 with entity values.png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**
packages/visual-editor/src/components/testing/screenshots/PromoSection/[mobile] [immersive] version 50 with constant values.png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**
packages/visual-editor/src/components/testing/screenshots/PromoSection/[mobile] [immersive] version 50 with entity values.png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**
packages/visual-editor/src/components/testing/screenshots/PromoSection/[mobile] [spotlight] version 50 with constant values.png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**
packages/visual-editor/src/components/testing/screenshots/PromoSection/[mobile] [spotlight] version 50 with entity values.png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**
packages/visual-editor/src/components/testing/screenshots/PromoSection/[mobile] default props with document data.png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**
packages/visual-editor/src/components/testing/screenshots/PromoSection/[mobile] default props with empty document.png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**
packages/visual-editor/src/components/testing/screenshots/PromoSection/[mobile] version 0 props with entity values.png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**
packages/visual-editor/src/components/testing/screenshots/PromoSection/[mobile] version 16 props using entity values with old CTA structure.png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**
packages/visual-editor/src/components/testing/screenshots/PromoSection/[mobile] version 24 with constant values.png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**
packages/visual-editor/src/components/testing/screenshots/PromoSection/[mobile] version 30 props with entity values.png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**
packages/visual-editor/src/components/testing/screenshots/PromoSection/[tablet] [classic] version 50 props with constant values and image.png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**
packages/visual-editor/src/components/testing/screenshots/PromoSection/[tablet] [classic] version 50 with constant values and video.png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**
packages/visual-editor/src/components/testing/screenshots/PromoSection/[tablet] [classic] version 50 with entity values.png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**
packages/visual-editor/src/components/testing/screenshots/PromoSection/[tablet] [compact] version 50 with constant values and image.png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**
packages/visual-editor/src/components/testing/screenshots/PromoSection/[tablet] [compact] version 50 with constant values and video.png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**
packages/visual-editor/src/components/testing/screenshots/PromoSection/[tablet] [compact] version 50 with entity values.png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**
packages/visual-editor/src/components/testing/screenshots/PromoSection/[tablet] [immersive] version 50 with constant values.png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**
packages/visual-editor/src/components/testing/screenshots/PromoSection/[tablet] [immersive] version 50 with entity values.png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**
packages/visual-editor/src/components/testing/screenshots/PromoSection/[tablet] [spotlight] version 50 with constant values.png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**
packages/visual-editor/src/components/testing/screenshots/PromoSection/[tablet] [spotlight] version 50 with entity values.png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**
packages/visual-editor/src/components/testing/screenshots/PromoSection/[tablet] default props with document data.png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**
packages/visual-editor/src/components/testing/screenshots/PromoSection/[tablet] default props with empty document.png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**
packages/visual-editor/src/components/testing/screenshots/PromoSection/[tablet] version 0 props with entity values.png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**
packages/visual-editor/src/components/testing/screenshots/PromoSection/[tablet] version 16 props using entity values with old CTA structure.png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**
packages/visual-editor/src/components/testing/screenshots/PromoSection/[tablet] version 24 with constant values.png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**
packages/visual-editor/src/components/testing/screenshots/PromoSection/[tablet] version 30 props with entity values.png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**
packages/visual-editor/src/components/testing/screenshots/PromoSection/[xl] [compact] version 50 with entity values.png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**

📒 Files selected for processing (1)

packages/visual-editor/src/vite-plugin/defaultLayoutData.ts

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)

GitHub Check: call_unit_test / unit_tests (22.x)
GitHub Check: call_unit_test / unit_tests (20.x)
GitHub Check: call_unit_test / unit_tests (24.x)
GitHub Check: semgrep/ci

packages/visual-editor/src/vite-plugin/defaultLayoutData.ts

coderabbitai

Actionable comments posted: 1

🤖 Fix all issues with AI agents

In @packages/visual-editor/src/vite-plugin/defaultLayoutData.ts:
- Around line 3077-3078: The third EventCard (EventCard at index 2) still has
the long placeholder description in both its json and html strings while the
first two cards were shortened; update the json text field and the html span
content for EventCard index 2 to match the shortened description used by index 0
and 1 (and also fix the duplicate occurrences elsewhere), ensuring both the
serialized json string and the corresponding html string are updated
consistently.

📜 Review details

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 51d4a79 and 2a28058.

📒 Files selected for processing (1)

packages/visual-editor/src/vite-plugin/defaultLayoutData.ts

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)

GitHub Check: call_unit_test / unit_tests (22.x)
GitHub Check: call_unit_test / unit_tests (24.x)
GitHub Check: call_unit_test / unit_tests (20.x)
GitHub Check: semgrep/ci

packages/visual-editor/src/vite-plugin/defaultLayoutData.ts

…cription

Tickets - [OPAQF-49](https://yext.atlassian.net/browse/OPAQF-49), [OPAQF-59](https://yext.atlassian.net/browse/OPAQF-59) - Reduced Event Section's description to 2 lines. - Updated body and heading to use proportional line-heights (1.5 for body text, 1.2 for headings) instead of calculated pixel-based values. https://github.com/user-attachments/assets/c4cce286-9b5d-4bbd-9328-1dde7ddbcf48 --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

rkeerthient added 3 commits January 6, 2026 00:15

fix: line-height for RTFV2

610719f

reduced event card default text

e70e2bf

renamed test case

8546345

coderabbitai bot reviewed Jan 5, 2026

View reviewed changes

github-actions bot and others added 3 commits January 5, 2026 20:41

Update component screenshots for visual-editor

0f3964a

Update component screenshots for visual-editor

ce0d8d0

Merge remote-tracking branch 'origin/main' into line-height-event-des…

6f1ca92

…cription

rkeerthient requested review from asanehisa, benlife5 and mkilpatrick January 5, 2026 21:05

github-actions bot added 2 commits January 5, 2026 21:10

Update component screenshots for visual-editor

d104434

Update component screenshots for visual-editor

562d9a6

mkilpatrick reviewed Jan 5, 2026

View reviewed changes

.../components/testing/screenshots/EventSection/[mobile] version 0 props with entity values.png Show resolved Hide resolved

rkeerthient and others added 2 commits January 7, 2026 02:22

Merge remote-tracking branch 'origin/main' into line-height-event-des…

e7a4921

…cription

Update component screenshots for visual-editor

cd7fe25

rkeerthient requested a review from mkilpatrick January 6, 2026 21:02

asanehisa reviewed Jan 6, 2026

View reviewed changes

packages/visual-editor/src/components/pageSections/EventSection/EventCard.tsx Show resolved Hide resolved

mkilpatrick previously approved these changes Jan 6, 2026

View reviewed changes

updated default data

51d4a79

rkeerthient dismissed mkilpatrick’s stale review via 51d4a79 January 7, 2026 09:13

rkeerthient requested review from asanehisa and mkilpatrick January 7, 2026 09:14

coderabbitai bot reviewed Jan 7, 2026

View reviewed changes

packages/visual-editor/src/vite-plugin/defaultLayoutData.ts Show resolved Hide resolved

updated 2nd instance default text

2a28058

coderabbitai bot reviewed Jan 7, 2026

View reviewed changes

packages/visual-editor/src/vite-plugin/defaultLayoutData.ts Show resolved Hide resolved

rkeerthient and others added 3 commits January 7, 2026 18:04

updated default layout

3371d54

Update component screenshots for visual-editor

dabec2b

Merge branch 'main' into line-height-cta-padding

e468fea

github-actions bot added 2 commits January 8, 2026 09:40

Update component screenshots for visual-editor

08f46d5

Update component screenshots for visual-editor

303812f

mkilpatrick previously approved these changes Jan 8, 2026

View reviewed changes

benlife5 previously approved these changes Jan 8, 2026

View reviewed changes

Merge remote-tracking branch 'origin/main' into line-height-event-des…

2f7f544

…cription

rkeerthient dismissed stale reviews from benlife5 and mkilpatrick via 2f7f544 January 8, 2026 17:54

github-actions bot added 2 commits January 8, 2026 17:58

Update component screenshots for visual-editor

2095e5f

Update component screenshots for visual-editor

1b6caeb

mkilpatrick approved these changes Jan 8, 2026

View reviewed changes

mkilpatrick merged commit 886dce8 into main Jan 8, 2026
17 checks passed

mkilpatrick deleted the line-height-cta-padding branch January 8, 2026 18:17

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: line height in rich text and reduced event description #972

fix: line height in rich text and reduced event description #972

Uh oh!

rkeerthient commented Jan 5, 2026

Uh oh!

github-actions bot commented Jan 5, 2026

Uh oh!

coderabbitai bot commented Jan 5, 2026 •

edited

Loading

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

fix: line height in rich text and reduced event description #972

fix: line height in rich text and reduced event description #972

Uh oh!

Conversation

rkeerthient commented Jan 5, 2026

Uh oh!

github-actions bot commented Jan 5, 2026

Uh oh!

coderabbitai bot commented Jan 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Sequence Diagram(s)

Possibly related PRs

Suggested reviewers

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

coderabbitai bot commented Jan 5, 2026 •

edited

Loading