-
Notifications
You must be signed in to change notification settings - Fork 0
fix: copyright not updating and alignments not respected #899
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: copyright not updating and alignments not respected #899
Conversation
|
Warning: Component files have been updated but no migrations have been added. See https://github.com/yext/visual-editor/blob/main/packages/visual-editor/src/components/migrations/README.md for more information. |
WalkthroughThis PR simplifies copyright message data and propagates alignment through footer slots. Sequence Diagram(s)sequenceDiagram
autonumber
participant PageRenderer as Page Renderer
participant SecondaryFooter as SecondaryFooterSlot
participant Resolver as resolveData
participant CopyrightSlot as CopyrightMessageSlot
participant Body as Body Component
Note over SecondaryFooter,Resolver: New/changed behavior: propagate alignment
PageRenderer->>SecondaryFooter: render(footerProps)
SecondaryFooter->>Resolver: resolveData(styles, slots)
Resolver-->>SecondaryFooter: slotsWithAlignment
SecondaryFooter->>CopyrightSlot: render(slotProps { data.text: TranslatableString, alignment })
CopyrightSlot->>Body: render(text, className based on alignment)
Body-->>CopyrightSlot: rendered DOM
CopyrightSlot-->>PageRenderer: rendered slot
Suggested labels
Suggested reviewers
Pre-merge checks and finishing touches✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro ⛔ Files ignored due to path filters (6)
📒 Files selected for processing (1)
🔇 Additional comments (1)
Comment |
...s/testing/screenshots/ExpandedFooter/[desktop] version 41 props - expanded with all data.png
Show resolved
Hide resolved
.../src/components/testing/screenshots/ExpandedFooter/[desktop] version 10 props - expanded.png
Show resolved
Hide resolved
...r/src/components/testing/screenshots/ExpandedFooter/[tablet] version 20 props - expanded.png
Show resolved
Hide resolved
f695408
into
fall-2025-slot-ify-components
verified that copyright slot can now be updated and that alignments are now respected in secondary footer