Skip to content

Conversation

@colton-demetriou
Copy link
Contributor

verified that copyright slot can now be updated and that alignments are now respected in secondary footer

@github-actions
Copy link
Contributor

Warning: Component files have been updated but no migrations have been added. See https://github.com/yext/visual-editor/blob/main/packages/visual-editor/src/components/migrations/README.md for more information.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 12, 2025

Walkthrough

This PR simplifies copyright message data and propagates alignment through footer slots. CopyrightMessageSlot now accepts data.text: TranslatableString (replacing YextEntityField<TranslatableString>) and a new public prop alignment?: "left" | "right". The component renders the resolved text inside a Body element with alignment-aware classes. SecondaryFooterSlot was changed to propagate parent secondaryLinksAlignment into each CopyrightMessageSlot entry and to remove an alignment wrapper. FooterLinksSlot adjusted MD-breakpoint alignment utility classes. Docs and tests were updated to match the new prop shapes.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  participant PageRenderer as Page Renderer
  participant SecondaryFooter as SecondaryFooterSlot
  participant Resolver as resolveData
  participant CopyrightSlot as CopyrightMessageSlot
  participant Body as Body Component

  Note over SecondaryFooter,Resolver: New/changed behavior: propagate alignment

  PageRenderer->>SecondaryFooter: render(footerProps)
  SecondaryFooter->>Resolver: resolveData(styles, slots)
  Resolver-->>SecondaryFooter: slotsWithAlignment
  SecondaryFooter->>CopyrightSlot: render(slotProps { data.text: TranslatableString, alignment })
  CopyrightSlot->>Body: render(text, className based on alignment)
  Body-->>CopyrightSlot: rendered DOM
  CopyrightSlot-->>PageRenderer: rendered slot
Loading

Suggested labels

create-dev-release

Suggested reviewers

  • mkilpatrick
  • briantstephan
  • asanehisa

Pre-merge checks and finishing touches

✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title directly addresses the main changes: fixing copyright slot updates and respecting alignments in the secondary footer, which aligns with the core modifications across multiple footer components.
Description check ✅ Passed The description is related to the changeset, mentioning copyright slot updates and alignment respect in the secondary footer, which reflects the actual modifications made.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix-copyright

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d10415d and 509e248.

⛔ Files ignored due to path filters (6)
  • packages/visual-editor/src/components/testing/screenshots/ExpandedFooter/[desktop] version 10 props - expanded.png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**
  • packages/visual-editor/src/components/testing/screenshots/ExpandedFooter/[desktop] version 20 props - expanded.png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**
  • packages/visual-editor/src/components/testing/screenshots/ExpandedFooter/[desktop] version 41 props - expanded with all data.png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**
  • packages/visual-editor/src/components/testing/screenshots/ExpandedFooter/[tablet] version 10 props - expanded.png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**
  • packages/visual-editor/src/components/testing/screenshots/ExpandedFooter/[tablet] version 20 props - expanded.png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**
  • packages/visual-editor/src/components/testing/screenshots/ExpandedFooter/[tablet] version 41 props - expanded with all data.png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**
📒 Files selected for processing (1)
  • packages/visual-editor/src/components/footer/ExpandedFooter.test.tsx (3 hunks)
🔇 Additional comments (1)
packages/visual-editor/src/components/footer/ExpandedFooter.test.tsx (1)

683-683: LGTM! Test data correctly updated for new alignment prop.

The addition of the alignment prop to CopyrightMessageSlot test data is consistent across all version 41 test scenarios. The alignment values correctly match their parent SecondaryFooterSlot's linksAlignment settings, and both "left" and "right" alignment cases are covered.

Also applies to: 892-892, 1046-1046


Comment @coderabbitai help to get the list of available commands and usage tips.

@colton-demetriou colton-demetriou merged commit f695408 into fall-2025-slot-ify-components Nov 12, 2025
15 checks passed
@colton-demetriou colton-demetriou deleted the fix-copyright branch November 12, 2025 22:37
@coderabbitai coderabbitai bot mentioned this pull request Jan 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants