fix: slots qa part 3

[benlife5]

• updates defaultLayoutData
• merges main again (most significant change: url template functions)
• adds an additional migration test case

[pkg-pr-new]

pages-visual-editor-starter

npm i https://pkg.pr.new/yext/visual-editor/@yext/visual-editor@863

commit: a7864a0

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (2)

packages/visual-editor/src/components/pageSections/heroVariants/HeroContent.tsx (1)

80-84: Responsive CTA styling looks good.

The important modifiers (!) successfully enforce full-width on mobile and fit-content on desktop, which is a standard pattern for CTA buttons.

If the ! modifiers are being added to override competing styles, consider whether the source of the specificity conflict could be addressed to avoid relying on !important. However, this is a pragmatic solution that works well for the immediate need.

packages/visual-editor/src/components/Locator.test.tsx (1)

69-109: Good test coverage for non-default props.

This test case provides valuable coverage for the latest version with customized props (mapStyle and filters). The structure is consistent with existing test patterns.

The document structure (lines 72-100) is nearly identical to lines 35-64 and appears across multiple test cases. Consider extracting common document fixtures into a factory function to improve maintainability:

const createTestDocument = (overrides = {}) => ({
  locale: "en",
  businessId: "4174974",
  __: {
    isPrimaryLocale: true,
  },
  _env: {
    YEXT_PUBLIC_VISUAL_EDITOR_APP_API_KEY: import.meta.env.COMPONENT_TESTS_VISUAL_EDITOR_APP_API_KEY,
    // ... other env vars
  },
  _pageset: JSON.stringify({
    // ... pageset config
  }),
  ...overrides,
});

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f12e651 and a8d7429.

📒 Files selected for processing (4)

• packages/visual-editor/src/components/Locator.test.tsx (6 hunks)
• packages/visual-editor/src/components/migrations/0021_set_open_now_default.ts (1 hunks)
• packages/visual-editor/src/components/migrations/0022_adjust_locator_open_now_schema.ts (1 hunks)
• packages/visual-editor/src/components/pageSections/heroVariants/HeroContent.tsx (1 hunks)

🧰 Additional context used

🧠 Learnings (1)

📚 Learning: 2025-10-29T22:00:03.843Z

Learnt from: mkouzel-yext
Repo: yext/visual-editor PR: 833
File: packages/visual-editor/src/components/Locator.tsx:1050-1057
Timestamp: 2025-10-29T22:00:03.843Z
Learning: In packages/visual-editor/src/components/Locator.tsx, the AppliedFilters component is intentionally rendered in two locations (inside the filter modal and outside it) as per the design requirements. This dual rendering should not be flagged as a duplicate issue.

Applied to files:

• packages/visual-editor/src/components/migrations/0022_adjust_locator_open_now_schema.ts
• packages/visual-editor/src/components/Locator.test.tsx

🧬 Code graph analysis (1)

packages/visual-editor/src/components/Locator.test.tsx (4)

packages/visual-editor/src/components/Locator.tsx (1)

• LocatorComponent (542-551)

packages/visual-editor/src/components/index.ts (1)

• LocatorComponent (14-14)

packages/visual-editor/src/utils/migrate.test.ts (1)

• migrationRegistry (79-82)

packages/visual-editor/src/components/migrations/migrationRegistry.ts (1)

• migrationRegistry (49-91)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)

• GitHub Check: call_unit_test / unit_tests (18.x)
• GitHub Check: call_unit_test / unit_tests (20.x)
• GitHub Check: create-dev-release
• GitHub Check: semgrep/ci

🔇 Additional comments (6)

packages/visual-editor/src/components/migrations/0022_adjust_locator_open_now_schema.ts (1)

4-4: LGTM! Consistent rename and correct migration logic.

The key rename from LocatorComponent to Locator is consistent with migration 0021. The transformation correctly moves openNowButton from the top level into filters.openNowButton, maintaining the proper migration sequence.

packages/visual-editor/src/components/migrations/0021_set_open_now_default.ts (1)

4-4: LGTM! Migration correctly uses Locator key with proper prop transformation.

Verification confirms the change is correct:

• File 0021_set_open_now_default.ts properly uses Locator: as the migration identifier (line 4)
• No references to LocatorComponent exist in migration files, as expected
• Migration 0022 follows the same Locator: pattern, confirming consistency
• The openNow → openNowButton transformation with false default is correct

packages/visual-editor/src/components/Locator.test.tsx (4)

28-28: LGTM: Test naming improves clarity.

The explicit "latest version" prefix clearly indicates these tests verify behavior after all migrations are applied, distinguishing them from version-specific test cases.

Also applies to: 34-34

---

292-296: LGTM: Props align with migration structure.

The addition of filters: { openNowButton: false } correctly reflects the migration that restructured the openNowButton prop, ensuring the default behavior is preserved after version 22 migration.

---

336-336: LGTM: Tests new facet fields feature.

The addition of facetFields to the version 22 non-default props test case appropriately covers the new facet filtering functionality.

---

347-347: LGTM: Component registration updated consistently.

The change from implicit to explicit component registration (Locator: LocatorComponent) and the corresponding type reference update (type: "Locator") are consistent. This represents a breaking change in how the component is keyed in the Puck config but aligns with the refactored component structure.

Also applies to: 373-373