Skip to content

Conversation

@benlife5
Copy link
Contributor

Forgot to migrate the local starter to use data instead of document for schema

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 31, 2025

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (1)
  • packages/visual-editor/src/components/testing/screenshots/StaticMapSection/[desktop] default props with coordinate - with api key.png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

The getHeadConfig function in starter/src/templates/dev.tsx was refactored to accept a single data parameter instead of a destructured { document } parameter. Inside the function, document is now destructured from the data object. Additionally, the call to getSchema was updated to pass the entire data object as an argument rather than passing only document. The exported type signature GetHeadConfig<TemplateRenderProps> remains unchanged, with only the parameter structure modified.

Pre-merge checks and finishing touches

✅ Passed checks (2 passed)
Check name Status Explanation
Title Check ✅ Passed The title "fix: starter template" is related to the changeset and refers to the actual fix being made to the starter template. However, it is somewhat generic and doesn't specify the main point of the change — that the schema parameter migration from document to data was forgotten and needs to be completed. The title captures that this is a fix to the starter, but lacks specificity about what aspect is being fixed, making it overly broad rather than clearly summarizing the core change.
Description Check ✅ Passed The pull request description "Forgot to migrate the local starter to use data instead of document for schema" is directly related to the changeset. It accurately describes the main intent of the changes: migrating the getHeadConfig method to pass the entire data object to getSchema instead of just the document property, which aligns precisely with what the code modifications accomplish.

Comment @coderabbitai help to get the list of available commands and usage tips.

@benlife5 benlife5 merged commit cccf72a into main Oct 31, 2025
15 checks passed
@benlife5 benlife5 deleted the fix-starter-build branch October 31, 2025 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants