feat: provide default schema to parent window #791
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
briantstephan
requested review from
asanehisa,
benlife5,
colton-demetriou and
mkilpatrick
asanehisa
reviewed
Sep 29, 2025
packages/visual-editor/src/internal/components/AdvancedSettings.tsx
Outdated
Show resolved
Hide resolved
…al-editor into provide-default-schema
asanehisa
previously approved these changes
Sep 30, 2025
benlife5
previously approved these changes
Sep 30, 2025
mkilpatrick
reviewed
Sep 30, 2025
packages/visual-editor/src/internal/components/AdvancedSettings.tsx
Outdated
Show resolved
Hide resolved
packages/visual-editor/src/internal/components/AdvancedSettings.tsx
Outdated
Show resolved
Hide resolved
briantstephan
dismissed stale reviews from benlife5 and asanehisa
via
42b7e29
asanehisa
reviewed
Sep 30, 2025
mkilpatrick
approved these changes
Oct 1, 2025
benlife5
approved these changes
Oct 1, 2025
asanehisa
approved these changes
Oct 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When sending the user's schema to the parent to allow for editing, we now also send the default schema. A new option in the UI will allow the user to restore the default schema and clear any edits they've made.
Ran everything locally and logged the payload that was sent to the front-end, confirming that it included the new defaultValue field.