Skip to content

EOperationKind::WriteTx #976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 12, 2024
Merged

EOperationKind::WriteTx #976

merged 1 commit into from
Jan 12, 2024

Conversation

@azevaykin
Copy link
Collaborator

@azevaykin azevaykin commented Jan 12, 2024

KIKIMR-20703

@azevaykin azevaykin requested a review from snaury January 12, 2024 15:22
snaury
snaury approved these changes Jan 12, 2024
View reviewed changes
ydb/core/tx/datashard/check_write_unit.cpp
TTransactionContext &,
const TActorContext &ctx)
{
Y_ABORT_UNLESS(op->IsDataTx() || op->IsReadTable());
Copy link
Member

@snaury snaury Jan 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Тут можно было сделать Y_ABORT_UNLESS(op->IsWriteTx()).

Copy link
Collaborator Author

@azevaykin azevaykin Jan 12, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ниже в 52 строке есть TWriteOperation* writeOp = TWriteOperation::CastWriteOperation(op); , там внутри есть Y_ABORT_UNLESS(op->IsWriteTx()).

Но могу и тут продублировать.

@azevaykin azevaykin merged commit 5d59f2c into ydb-platform:main Jan 12, 2024
@github-actions
Copy link

github-actions bot commented Jan 12, 2024 •
edited
Loading

Note

This is an automated comment that will be appended during run.

🔴 linux-x86_64-relwithdebinfo: some tests FAILED for commit 54ee5cf.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
59892 50657 0 3 9207 25

🔴 linux-x86_64-release-asan: some tests FAILED for commit 54ee5cf.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15873 15703 0 24 126 20

@Dark-Avery Dark-Avery mentioned this pull request Jan 15, 2024
Closed
This was referenced Jan 15, 2024
Merged
Closed
@alexd65536 alexd65536 mentioned this pull request Jan 15, 2024
Merged
@pavelvelikhov pavelvelikhov mentioned this pull request Jan 15, 2024
Closed
@alexd65536 alexd65536 mentioned this pull request Jan 15, 2024
Merged
@alexvru alexvru mentioned this pull request Jan 18, 2024
Merged
@pavelvelikhov pavelvelikhov mentioned this pull request Jan 24, 2024
Merged
@FloatingCrowbar FloatingCrowbar mentioned this pull request Jan 24, 2024
Merged
@niksaveliev niksaveliev mentioned this pull request Jan 25, 2024
Merged
@vitstn vitstn mentioned this pull request Jan 25, 2024
Merged
@aakulaga-ydb aakulaga-ydb mentioned this pull request Jan 25, 2024
Merged
This was referenced Jan 25, 2024
Merged
Merged
Merged
Merged
Merged
@niksaveliev niksaveliev mentioned this pull request Jan 29, 2024
Merged
@vitstn vitstn mentioned this pull request Jan 29, 2024
Merged
@shnikd shnikd mentioned this pull request Jan 29, 2024
Merged
This was referenced Jan 29, 2024
Merged
Merged
Merged
@pavelvelikhov pavelvelikhov mentioned this pull request Jan 29, 2024
Merged
@vitstn vitstn mentioned this pull request Jan 29, 2024
Merged
@shnikd shnikd mentioned this pull request Feb 5, 2024
Merged
This was referenced Feb 5, 2024
Merged
Merged
@niksaveliev niksaveliev mentioned this pull request Feb 5, 2024
Merged
@pavelvelikhov pavelvelikhov mentioned this pull request Feb 5, 2024
Merged
@vitstn vitstn mentioned this pull request Feb 5, 2024
Merged
This was referenced Feb 6, 2024
Closed
Merged
This was referenced Feb 6, 2024
Merged
Merged
Merged
Merged
Merged
@ildar-khisambeev ildar-khisambeev mentioned this pull request Feb 8, 2024
Merged
@vitstn vitstn mentioned this pull request Feb 8, 2024
Merged
@niksaveliev niksaveliev mentioned this pull request Feb 9, 2024
Merged
@pavelvelikhov pavelvelikhov mentioned this pull request Feb 9, 2024
Merged
@niksaveliev niksaveliev mentioned this pull request Feb 12, 2024
Merged
@starlinskiy starlinskiy mentioned this pull request Feb 12, 2024
Closed
This was referenced Feb 12, 2024
Merged
Merged
@starlinskiy starlinskiy mentioned this pull request Feb 12, 2024
Merged
@pavelvelikhov pavelvelikhov mentioned this pull request Feb 13, 2024
Merged
This was referenced Feb 13, 2024
Merged
Merged
Merged
@pavelvelikhov pavelvelikhov mentioned this pull request Feb 15, 2024
Merged
@niksaveliev niksaveliev mentioned this pull request Feb 16, 2024
Merged
@vitstn vitstn mentioned this pull request Feb 16, 2024
Merged
@aakulaga-ydb aakulaga-ydb mentioned this pull request Feb 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@snaury snaury snaury approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@azevaykin @snaury