Skip to content

Kafka Connect docs #1369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 41 commits into from
Feb 19, 2024
Merged

Kafka Connect docs #1369

merged 41 commits into from
Feb 19, 2024

Conversation

niksaveliev
Copy link
Collaborator

@niksaveliev niksaveliev commented Jan 29, 2024 •
edited
Loading

No description provided.

@niksaveliev niksaveliev marked this pull request as ready for review January 29, 2024 08:48
@niksaveliev niksaveliev requested a review from a team as a code owner January 29, 2024 08:48
@github-actions GitHub Actions
Copy link

✅ Documentation build

Revision builded successful
Revision preview link

@github-actions GitHub Actions
Copy link

✅ Documentation build

Revision builded successful
Revision preview link

blinkov
blinkov reviewed Jan 30, 2024
View reviewed changes
ydb/docs/ru/core/reference/kafka-api/examples.md Outdated
Для запуска процесса-исполнителя выполните:
```bash
cd ~/opt/kafka/bin/ && \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

досыпать бы команд, создающих эту папку

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Переделал в пошаговую инструкцию

blinkov
blinkov previously requested changes Jan 30, 2024
View reviewed changes
Copy link
Member

@blinkov blinkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

плюс перевод на английский нужен

niksaveliev and others added 7 commits January 30, 2024 18:52
@niksaveliev @blinkov
Update ydb/docs/ru/core/reference/kafka-api/examples.md
710d678 
Co-authored-by: Ivan Blinkov <ivan@blinkov.ru>
@niksaveliev @blinkov
Update ydb/docs/ru/core/reference/kafka-api/examples.md
883384d 
Co-authored-by: Ivan Blinkov <ivan@blinkov.ru>
@niksaveliev @blinkov
Update ydb/docs/ru/core/reference/kafka-api/examples.md
3a2dacd 
Co-authored-by: Ivan Blinkov <ivan@blinkov.ru>
@niksaveliev @blinkov
Update ydb/docs/ru/core/reference/kafka-api/examples.md
230fd24 
Co-authored-by: Ivan Blinkov <ivan@blinkov.ru>
@niksaveliev @blinkov
Update ydb/docs/ru/core/reference/kafka-api/examples.md
7d001dc 
Co-authored-by: Ivan Blinkov <ivan@blinkov.ru>
@niksaveliev @blinkov
Update ydb/docs/ru/core/reference/kafka-api/examples.md
e98c990 
Co-authored-by: Ivan Blinkov <ivan@blinkov.ru>
@niksaveliev @blinkov
Update ydb/docs/ru/core/reference/kafka-api/examples.md
6f0457a 
Co-authored-by: Ivan Blinkov <ivan@blinkov.ru>
@github-actions GitHub Actions
Copy link

❌ Documentation build

Revision build failed

Build logs

Errors (1)

❌ Note must be closed in /ru/reference/kafka-api/examples.md

@github-actions GitHub Actions
Copy link

✅ Documentation build

Revision builded successful
Revision preview link

@github-actions GitHub Actions
Copy link

✅ Documentation build

Revision builded successful
Revision preview link

@github-actions GitHub Actions
Copy link

✅ Documentation build

Revision built successfully
Revision preview link

@github-actions GitHub Actions
Copy link

❌ Documentation build

Revision build failed

Build logs

Errors (1)

❌ Link is unreachable: connect.md in /ru/reference/kafka-api/index.md

@github-actions GitHub Actions
Copy link

✅ Documentation build

Revision built successfully
Revision preview link

@github-actions GitHub Actions
Copy link

✅ Documentation build

Revision built successfully
Revision preview link

@github-actions GitHub Actions
Copy link

✅ Documentation build

Revision built successfully
Revision preview link

@blinkov blinkov dismissed their stale review February 19, 2024 14:10

outdated

@blinkov blinkov enabled auto-merge (squash) February 19, 2024 14:11
blinkov
blinkov reviewed Feb 19, 2024
View reviewed changes
ydb/docs/ru/core/reference/kafka-api/auth.md Outdated

{% note warning %}

Обратите внимание, что при аутентификации после имени пользователя указывается [путь базы данных](../../concepts/connect#database) в формате `<user>@<db-path>`.
Обратите внимание, логика формирования `<sasl.username>` и `<sasl.password>` в облачных инсталляциях YDB может отличаться от приведенной здесь.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

не понятно что такое «облачная инсталляция» — это дока про open-source YDB

плюс вместо YDB надо писать {{ ydb-short-name }}

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Андрей предложил в угоду понятности сослаться на облачную доку, если надо. Тут просто без этого пункта запутаться можно

@github-actions GitHub Actions
Copy link

✅ Documentation build

Revision built successfully
Revision preview link

@github-actions GitHub Actions
Copy link

✅ Documentation build

Revision built successfully
Revision preview link

@blinkov blinkov merged commit 230ef6e into ydb-platform:main Feb 19, 2024
This was referenced Feb 20, 2024
Merged
Merged
Merged
Merged
This was referenced Mar 7, 2024
Merged
Merged
This was referenced Mar 19, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blinkov blinkov blinkov left review comments

@fomichev3000 fomichev3000 fomichev3000 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@niksaveliev @blinkov @fomichev3000