Skip to content

Enabled multiple join implementations in CBO #1396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jan 30, 2024
Merged

Enabled multiple join implementations in CBO #1396

merged 5 commits into from
Jan 30, 2024

Conversation

@pavelvelikhov
Copy link
Collaborator

@pavelvelikhov pavelvelikhov commented Jan 29, 2024 •
edited
Loading

  • Enabled multiple join implementations in CBO

Changelog entry

...

Changelog category

  • New feature
  • Experimental feature

Additional information

...

@pavelvelikhov pavelvelikhov requested a review from a team as a code owner January 29, 2024 18:06
@github-actions
Copy link

github-actions bot commented Jan 29, 2024 •
edited
Loading

⚪ 2024-01-29 18:09:39 UTC Pre-commit check for b11d10a has started.
⚪ 2024-01-29 18:09:43 UTC Build linux-x86_64-relwithdebinfo is running...
🔴 2024-01-29 18:15:39 UTC Build failed. see the build logs.
⚪ 2024-01-29 18:15:55 UTC Tests are running...
🔴 2024-01-29 19:58:36 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
60246 50968 0 2 9256 20

@github-actions
Copy link

github-actions bot commented Jan 29, 2024 •
edited
Loading

⚪ 2024-01-29 18:09:44 UTC Pre-commit check for b11d10a has started.
⚪ 2024-01-29 18:09:46 UTC Build linux-x86_64-release-asan is running...
🔴 2024-01-29 18:16:05 UTC Build failed. see the build logs.
⚪ 2024-01-29 18:16:20 UTC Tests are running...
🔴 2024-01-29 19:58:42 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
16000 15894 0 16 69 21

resetius
resetius reviewed Jan 29, 2024
View reviewed changes
resetius
resetius previously approved these changes Jan 29, 2024
View reviewed changes
Copy link
Contributor

@resetius resetius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pls fix my comments in next PR

ydb/library/yql/core/cbo/cbo_optimizer_new.h
return true;
}

static const TDummyProviderContext& instance() {
Copy link
Contributor

@resetius resetius Jan 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need singleton here?

Copy link
Collaborator Author

@pavelvelikhov pavelvelikhov Jan 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added it here to avoid to create a new DummyProvider every time.

@github-actions
Copy link

github-actions bot commented Jan 30, 2024 •
edited
Loading

⚪ 2024-01-30 05:58:55 UTC Pre-commit check for a7db3b2 has started.
⚪ 2024-01-30 05:58:58 UTC Build linux-x86_64-relwithdebinfo is running...
🔴 2024-01-30 06:02:44 UTC Build failed. see the build logs.

@github-actions
Copy link

github-actions bot commented Jan 30, 2024 •
edited
Loading

⚪ 2024-01-30 05:59:05 UTC Pre-commit check for a7db3b2 has started.
⚪ 2024-01-30 05:59:07 UTC Build linux-x86_64-release-asan is running...
🔴 2024-01-30 06:03:19 UTC Build failed. see the build logs.

@resetius resetius self-requested a review January 30, 2024 08:55
resetius
resetius previously approved these changes Jan 30, 2024
View reviewed changes
Copy link
Contributor

@resetius resetius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@github-actions
Copy link

github-actions bot commented Jan 30, 2024 •
edited
Loading

⚪ 2024-01-30 08:56:20 UTC Pre-commit check for b9f3d3f has started.
⚪ 2024-01-30 08:56:21 UTC Build linux-x86_64-relwithdebinfo is running...
🔴 2024-01-30 08:58:43 UTC Build failed. see the build logs.
⚪ 2024-01-30 08:58:54 UTC Tests are running...
🔴 2024-01-30 10:39:44 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
60149 50866 0 1 9257 25

@github-actions
Copy link

github-actions bot commented Jan 30, 2024 •
edited
Loading

⚪ 2024-01-30 08:56:44 UTC Pre-commit check for b9f3d3f has started.
⚪ 2024-01-30 08:56:50 UTC Build linux-x86_64-release-asan is running...
🔴 2024-01-30 08:59:06 UTC Build failed. see the build logs.
⚪ 2024-01-30 08:59:18 UTC Tests are running...
🔴 2024-01-30 10:43:55 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
16004 15876 0 17 70 41

@github-actions
Copy link

github-actions bot commented Jan 30, 2024 •
edited
Loading

⚪ 2024-01-30 12:06:06 UTC Pre-commit check for 05ab73d has started.
⚪ 2024-01-30 12:06:08 UTC Build linux-x86_64-release-asan is running...
🟢 2024-01-30 12:11:54 UTC Build successful.
⚪ 2024-01-30 12:12:06 UTC Tests are running...
🔴 2024-01-30 14:00:32 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
16012 15908 0 15 61 28

@github-actions
Copy link

github-actions bot commented Jan 30, 2024 •
edited
Loading

⚪ 2024-01-30 12:06:57 UTC Pre-commit check for 05ab73d has started.
⚪ 2024-01-30 12:06:58 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-01-30 12:12:58 UTC Build successful.
⚪ 2024-01-30 12:13:09 UTC Tests are running...
🟢 2024-01-30 13:56:00 UTC Tests successful.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
60271 50979 0 0 9256 36

@pavelvelikhov pavelvelikhov merged commit 544c631 into ydb-platform:main Jan 30, 2024
This was referenced Jan 30, 2024
Merged
Merged
@Jornydb Jornydb mentioned this pull request Jan 31, 2024
Merged
@pavelvelikhov pavelvelikhov mentioned this pull request Jan 31, 2024
Merged
@vitstn vitstn mentioned this pull request Jan 31, 2024
Merged
This was referenced Jan 31, 2024
Closed
Merged
@vitstn vitstn mentioned this pull request Feb 7, 2024
Merged
@GrigoriyPA GrigoriyPA mentioned this pull request Feb 7, 2024
Merged
This was referenced Feb 7, 2024
Merged
Merged
Merged
@ildar-khisambeev ildar-khisambeev mentioned this pull request Feb 8, 2024
Merged
@vitstn vitstn mentioned this pull request Feb 8, 2024
Merged
@niksaveliev niksaveliev mentioned this pull request Feb 9, 2024
Merged
@GrigoriyPA GrigoriyPA mentioned this pull request Feb 9, 2024
Merged
@pavelvelikhov pavelvelikhov mentioned this pull request Feb 9, 2024
Merged
@niksaveliev niksaveliev mentioned this pull request Feb 12, 2024
Merged
@starlinskiy starlinskiy mentioned this pull request Feb 12, 2024
Closed
@vitstn vitstn mentioned this pull request Feb 12, 2024
Merged
@GrigoriyPA GrigoriyPA mentioned this pull request Feb 12, 2024
Merged
@vitstn vitstn mentioned this pull request Feb 12, 2024
Merged
@starlinskiy starlinskiy mentioned this pull request Feb 12, 2024
Merged
@pavelvelikhov pavelvelikhov mentioned this pull request Feb 13, 2024
Merged
This was referenced Feb 13, 2024
Merged
Merged
Merged
@pavelvelikhov pavelvelikhov mentioned this pull request Feb 15, 2024
Merged
@niksaveliev niksaveliev mentioned this pull request Feb 16, 2024
Merged
@vitstn vitstn mentioned this pull request Feb 16, 2024
Merged
This was referenced Feb 17, 2024
Merged
Merged
Merged
Merged
Merged
@aakulaga-ydb aakulaga-ydb mentioned this pull request Feb 24, 2024
Merged
@GrigoriyPA GrigoriyPA mentioned this pull request Feb 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@resetius resetius resetius approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

new-feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pavelvelikhov @resetius